From: Alexander Shukaev <emacs@Alexander.Shukaev.name>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 25189@debbugs.gnu.org
Subject: bug#25189: Use `current-global-map' in `comint-insert-input'
Date: Wed, 25 Dec 2019 10:59:56 +0100 [thread overview]
Message-ID: <40a05d64-0907-6b83-6961-dd4a2c510d31@Alexander.Shukaev.name> (raw)
In-Reply-To: <87k16l6689.fsf@gnus.org>
On 12/24/19 5:25 PM, Lars Ingebrigtsen wrote:
> Alexander Shukaev <emacs@Alexander.Shukaev.name> writes:
>
>> On 7/27/19 1:29 PM, Lars Ingebrigtsen wrote:
>>> Alexander Shukaev <emacs@Alexander.Shukaev.name> writes:
>>>
>>>> I think according to Emacs documentation it's more correct to change the
>>>>
>>>> (lookup-key global-map (vector last-key))
>>>>
>>>> form to the
>>>>
>>>> (lookup-key (current-global-map) (vector last-key))
>>>>
>>>> form.
>>> (I'm going through older Emacs bug reports that have received no
>>> response.)
>>> Looking at the manual section in "Controlling Active Maps", there
>>> doesn't seem to be anything to discourage using `global-map' directly
>>> there. I've grepped through the sources, though, and `global-map' is
>>> used all over the place (while `current-global-map' is used less).
>>> So this doesn't seem like something to be fixed, and I'm closing
>>> this
>>> bug report.
>>>
>>
>> I believe you want to read the docstring of `global-map' for that point.
>
> It would help if you could point to where you think Emacs says this.
>
> This is the doc string of global-map:
>
> global-map is a variable defined in ‘subr.el’.
> Its value is shown below.
>
> This variable may be risky if used as a file-local variable.
> Probably introduced at or before Emacs version 21.1.
>
> Documentation:
> Default global keymap mapping Emacs keyboard input into commands.
> The value is a keymap that is usually (but not necessarily) Emacs’s
> global map.
>
>
In particular,
> The value is a keymap that is usually (but not necessarily) Emacs’s
> global map.
So it's not necessarily the current global keymap. Hence, applying
`define-key' (or any other mutating function to it), may not take any
effect and do what is expected. It is safer to always use
`current-global-map'. At least that is my understanding why there are
special functions like `current-global-map' for accessing and
`use-global-map' for assignment.
next prev parent reply other threads:[~2019-12-25 9:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-13 0:36 bug#25189: Use `current-global-map' in `comint-insert-input' Alexander Shukaev
2019-07-27 11:29 ` Lars Ingebrigtsen
2019-12-16 1:58 ` Alexander Shukaev
[not found] ` <45ae521c-6f37-292e-c169-9ed591cb0504@Alexander.Shukaev.name>
2019-12-24 16:25 ` Lars Ingebrigtsen
2019-12-25 9:59 ` Alexander Shukaev [this message]
2019-12-25 21:39 ` Lars Ingebrigtsen
2019-12-26 0:32 ` Alexander Shukaev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40a05d64-0907-6b83-6961-dd4a2c510d31@Alexander.Shukaev.name \
--to=emacs@alexander.shukaev.name \
--cc=25189@debbugs.gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.