From: Carsten Dominik <carsten.dominik@gmail.com>
To: Bernt Hansen <bernt@norang.ca>
Cc: emacs-orgmode@gnu.org
Subject: Re: Org-mode version 6.32trans (release_6.32b.127.g471c2); Clocking out moves point to clock entry
Date: Mon, 9 Nov 2009 22:55:28 +0100 [thread overview]
Message-ID: <40E226D8-F9E2-482A-8A2B-097FB324CE45@gmail.com> (raw)
In-Reply-To: <87ocnbe56i.fsf@gollum.intra.norang.ca>
Hmmm.
I do not understand why this makes a difference, but I will make these
changes. Thanks a lot.
This was on of the big-sweep changes that happen in Emacs all the
time, where someone thinks we should use this and that style.
This looked trivial, so I accepted the changes. Too early it seems.
- Carsten
On Nov 9, 2009, at 10:53 PM, Bernt Hansen wrote:
> Reverting just the org-clock.el patches seems to fix it too.
>
> -Bernt
>
> --8<---------------cut here---------------start------------->8---
> commit 01b1eb143f027bc6cdf54d95bd15fc03f2e03208
> Author: Bernt Hansen <bernt@norang.ca>
> Date: Mon Nov 9 14:27:03 2009 -0500
>
> Revert part of "Use with-current-buffer instead of save-excursion
> set-buffer where possible"
>
> This reverts the clocking changes in commit
> 7c0a16e2566e1cc3bb3c9f6b7571efe21f323a3c.
>
> diff --git a/lisp/org-clock.el b/lisp/org-clock.el
> index fc1e977..29cdf83 100644
> --- a/lisp/org-clock.el
> +++ b/lisp/org-clock.el
> @@ -1103,7 +1103,8 @@ If there is no running clock, throw an error,
> unless FAIL-QUIETLY is set."
> (if (not (marker-buffer org-clock-marker))
> (if fail-quietly (throw 'exit t) (error "No active clock")))
> (let (ts te s h m remove)
> - (with-current-buffer (marker-buffer org-clock-marker)
> + (save-excursion
> + (set-buffer (marker-buffer org-clock-marker))
> (save-restriction
> (widen)
> (goto-char org-clock-marker)
> @@ -1168,7 +1169,8 @@ If there is no running clock, throw an error,
> unless FAIL-QUIETLY is set."
> (interactive)
> (if (not (marker-buffer org-clock-marker))
> (error "No active clock"))
> - (with-current-buffer (marker-buffer org-clock-marker)
> + (save-excursion
> + (set-buffer (marker-buffer org-clock-marker))
> (goto-char org-clock-marker)
> (delete-region (1- (point-at-bol)) (point-at-eol))
> ;; Just in case, remove any empty LOGBOOK left over
> --8<---------------cut here---------------end--------------->8---
>
>
> Carsten Dominik <carsten.dominik@gmail.com> writes:
>
>> Hi Bernt,
>>
>> could I ask you to only revert that patch in org-clock.el and
>> see if that is enought to fix it?
>>
>> - Carsten
>>
>>
>> On Nov 9, 2009, at 8:30 PM, Bernt Hansen wrote:
>>
>>> Bernt Hansen <bernt@norang.ca> writes:
>>>
>>>> Remember to cover the basics, that is, what you expected to happen
>>>> and
>>>> what in fact did happen. You don't know how to make a good
>>>> report? See
>>>>
>>>> http://orgmode.org/manual/Feedback.html#Feedback
>>>>
>>>> Your bug report will be posted to the Org-mode mailing list.
>>>> ------------------------------------------------------------------------
>>>>
>>>> Clocking out of a task moves point to the clock entry being closed.
>>>> This makes my workaround for clocking in a new task (just use a
>>>> speed
>>>> key O to clock out and I to clock in) fail since we jump away from
>>>> the
>>>> task that I want to clock in.
>>>>
>>>> Emacs : GNU Emacs 22.2.1 (i486-pc-linux-gnu, GTK+ Version 2.12.11)
>>>> of 2008-11-09 on raven, modified by Debian
>>>> Package: Org-mode version 6.32trans (release_6.32b.127.g471c2)
>>>
>>> Reverting this commit seems to fix it
>>> 7c0a16e (Use with-current-buffer instead of save-excursion set-
>>> buffer where possible, 2009-11-05)
>>>
>>> -Bernt
>>>
>>>
>>> _______________________________________________
>>> Emacs-orgmode mailing list
>>> Remember: use `Reply All' to send replies to the list.
>>> Emacs-orgmode@gnu.org
>>> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
>>
>> - Carsten
>>
>>
>>
>>
>>
>> _______________________________________________
>> Emacs-orgmode mailing list
>> Remember: use `Reply All' to send replies to the list.
>> Emacs-orgmode@gnu.org
>> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
- Carsten
next prev parent reply other threads:[~2009-11-09 21:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-09 17:12 Org-mode version 6.32trans (release_6.32b.127.g471c2); Clocking out moves point to clock entry Bernt Hansen
2009-11-09 19:30 ` Bernt Hansen
2009-11-09 21:37 ` Carsten Dominik
2009-11-09 21:42 ` Bernt Hansen
2009-11-09 21:53 ` Bernt Hansen
2009-11-09 21:55 ` Carsten Dominik [this message]
2009-11-09 22:00 ` Bernt Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40E226D8-F9E2-482A-8A2B-097FB324CE45@gmail.com \
--to=carsten.dominik@gmail.com \
--cc=bernt@norang.ca \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.