From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: LinSun via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#47521: 28.0.50; [PATCH] [image-mode] reduce calling for image-toggle-display-text Date: Wed, 31 Mar 2021 20:17:57 +0800 Message-ID: <40B0A46C-9AFD-49AF-BCDE-0B5E2CF8ED6B@hxcore.ol> Reply-To: LinSun Mime-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20664"; mail-complaints-to="usenet@ciao.gmane.io" To: 47521@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Mar 31 14:20:20 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lRZpb-0005Gc-US for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 31 Mar 2021 14:20:20 +0200 Original-Received: from localhost ([::1]:33506 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lRZpa-0007Ue-W0 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 31 Mar 2021 08:20:19 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58838) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lRZoM-0006aQ-Ep for bug-gnu-emacs@gnu.org; Wed, 31 Mar 2021 08:19:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42178) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lRZoM-0003vt-59 for bug-gnu-emacs@gnu.org; Wed, 31 Mar 2021 08:19:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lRZoM-00014d-0k for bug-gnu-emacs@gnu.org; Wed, 31 Mar 2021 08:19:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: LinSun Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 31 Mar 2021 12:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 47521 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: "bug-gnu-emacs@gnu.org" Original-Received: via spool by submit@debbugs.gnu.org id=B.16171930944069 (code B ref -1); Wed, 31 Mar 2021 12:19:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 31 Mar 2021 12:18:14 +0000 Original-Received: from localhost ([127.0.0.1]:53724 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lRZna-00013Z-6x for submit@debbugs.gnu.org; Wed, 31 Mar 2021 08:18:14 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:60622) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lRZnY-00013R-FT for submit@debbugs.gnu.org; Wed, 31 Mar 2021 08:18:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58690) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lRZnY-0006Jb-9w for bug-gnu-emacs@gnu.org; Wed, 31 Mar 2021 08:18:12 -0400 Original-Received: from mail-pf1-x42b.google.com ([2607:f8b0:4864:20::42b]:41628) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lRZnW-0003TL-8t for bug-gnu-emacs@gnu.org; Wed, 31 Mar 2021 08:18:11 -0400 Original-Received: by mail-pf1-x42b.google.com with SMTP id l123so14402522pfl.8 for ; Wed, 31 Mar 2021 05:18:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zoom.us; s=google; h=mime-version:date:from:subject:thread-topic:message-id:to :content-transfer-encoding; bh=j8fS7PgcseQ446QGqBb1VtT8Fl1PtNbyXuowr4qxkuc=; b=JowGAmauE4Y8Ena3r8IeYinFoUjkM+FzwIvrUfmFxGb2OhdmntFAyqkcPpWm0YZvXC CH6in8ffeL69XVKxqI4PnfqjtIAtqW8DEMxTrIP7Bk2jVtgR0nEGNncjpW8drUIPf5JJ Y99mbbwbCllP+hanItpQ4wxqBiWwln13UtJ6Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:date:from:subject:thread-topic :message-id:to:content-transfer-encoding; bh=j8fS7PgcseQ446QGqBb1VtT8Fl1PtNbyXuowr4qxkuc=; b=kjcje+ZvIbn1sMq53GA3FP8d35LEkLhKjUDK9OQg9jiFUt+Fr0Y6l0fwi8+k1BXBY9 wRxCm0sUL05A1icFuGokTeYShtksgZPVS7E9EEQMEzgpokoqyFcIbcPMSrIooohGSEPa Lx/gUX7phW/BGJhmWSeM2Q2SY7KoQskHQMLj3UelZUHkG1ydLGqkGt9yr3vt12edSojQ HReRdee2o4Rojc4niHc//3PLZaBOLg3qLBMFJ2/uN/GH7772/o82mPgU3XRQpoCJo7V/ zqRHtQ8HKITTjLjFhkqwalph8PffmwfvYaydLiiDPDfF8BSZZCCMmqeogIVLhVfgySHh BIZQ== X-Gm-Message-State: AOAM532VtuZnYQQdptf3upIn4iQU0CLkLVTfYqfSfq3yppaPiSC5Sv13 Bo7xkSNmR0dHlb78d+ymCscuVOQJI0S0xImIyQGgedMovId1nNoC2z+OGFtAIWA0UIn2Gvt/lkl 0wA12oNe4gM8qNopBQILPzjK/sy9eohlcLG1RsKxLfsSOsFVzulTT5lwKp96o2AM= X-Google-Smtp-Source: ABdhPJxFxkjG3bIVY4qATUnpbam87R+XmUO6Esr9AHgdNlrZQuUp9GkL0+X+zp4sOWEYEvK6aEmzpA== X-Received: by 2002:aa7:8d8a:0:b029:1f8:aa27:7203 with SMTP id i10-20020aa78d8a0000b02901f8aa277203mr2705124pfr.64.1617193086017; Wed, 31 Mar 2021 05:18:06 -0700 (PDT) Original-Received: from DESKTOP-LINSUN ([38.99.100.2]) by smtp.gmail.com with ESMTPSA id u24sm2342242pfm.214.2021.03.31.05.18.03 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 31 Mar 2021 05:18:04 -0700 (PDT) Thread-Topic: 28.0.50; [PATCH] [image-mode] reduce calling for image-toggle-display-text Received-SPF: pass client-ip=2607:f8b0:4864:20::42b; envelope-from=lin.sun@zoom.us; helo=mail-pf1-x42b.google.com X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, MIME_HTML_ONLY=0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:203350 Archived-At:

Hi,

&n= bsp;

When open a png file and toggle display = from image to text by C-c C-c, the `image-toggle-display-text` will be call= ed twice in function `image-toggle-display-text`.

T= he first call is from major mode change hook, in follow line will cause `ch= ange-major-mode-hook` be run and it=E2=80=99s `image-toggle-display-text` f= or image-mode.

image-mode.el:730=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (major-mode-restore '(image-mode image-mode-= as-text))

 

The second call is from the direct call at

image-m= ode.el:736=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (image-toggle-d= isplay-text)

 

You can debug-on-entry `image-toggle-display-text` then switch image to= text in image-mode by C-c C-c to observe the issue.

 

And the patch is try to reduce = calling for `image-toggle-display-text`.

 = ;

Best Regards

Lin Sun

=