From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#21559: 25.0.50; auto-revert-mode breaks git rebase Date: Tue, 20 Feb 2018 13:37:18 +0200 Message-ID: <40817863-9c34-9745-6fff-4357d623de20@yandex.ru> References: <5d7808ef-d61f-534d-53b3-bc1227b4c3b1@yandex.ru> <87fu5w2jnh.fsf@gmx.de> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1519126575 13306 195.159.176.226 (20 Feb 2018 11:36:15 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 20 Feb 2018 11:36:15 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:59.0) Gecko/20100101 Thunderbird/59.0 Cc: 21559@debbugs.gnu.org, Alexei Khlebnikov To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Feb 20 12:36:10 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eo6DR-0002q2-Fw for geb-bug-gnu-emacs@m.gmane.org; Tue, 20 Feb 2018 12:36:09 +0100 Original-Received: from localhost ([::1]:54780 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eo6FR-0002U4-Q4 for geb-bug-gnu-emacs@m.gmane.org; Tue, 20 Feb 2018 06:38:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43043) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eo6FJ-0002RM-UH for bug-gnu-emacs@gnu.org; Tue, 20 Feb 2018 06:38:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eo6FG-0007eI-Sc for bug-gnu-emacs@gnu.org; Tue, 20 Feb 2018 06:38:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:44283) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eo6FG-0007e8-O9 for bug-gnu-emacs@gnu.org; Tue, 20 Feb 2018 06:38:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eo6FG-0002GJ-D7 for bug-gnu-emacs@gnu.org; Tue, 20 Feb 2018 06:38:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 20 Feb 2018 11:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21559 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 21559-submit@debbugs.gnu.org id=B21559.15191266518655 (code B ref 21559); Tue, 20 Feb 2018 11:38:02 +0000 Original-Received: (at 21559) by debbugs.gnu.org; 20 Feb 2018 11:37:31 +0000 Original-Received: from localhost ([127.0.0.1]:52180 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eo6El-0002FX-9g for submit@debbugs.gnu.org; Tue, 20 Feb 2018 06:37:31 -0500 Original-Received: from mail-wr0-f172.google.com ([209.85.128.172]:36148) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eo6Ei-0002FJ-TO for 21559@debbugs.gnu.org; Tue, 20 Feb 2018 06:37:29 -0500 Original-Received: by mail-wr0-f172.google.com with SMTP id u15so13435117wrg.3 for <21559@debbugs.gnu.org>; Tue, 20 Feb 2018 03:37:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=BFrJ/+ltl7K7dps/H44hHowRUcHirZ03iwFtZyl89BA=; b=Y10gh/WDL4neb69HQmlX+eVCumxkHteMvc9Pr2zxOe5XOmIiwckiRTSEFMP6u1nmgf PaNGIEVhub/C+GtgmOOVsski4h0OEWQxgH8oi02WovNOv7ScoyJvOplIslPIYmMXupek 3IIGp40gdx5t22XpBtCZaTwO22yQCgmWgoyH3xU317GFTxegQtgGkYSsSzYso0Urxkjr QpWB3X+FvVWFtD6y59TgdxUlr7aWOXhAiaYyuoLidmyCWow2y1agPUv7x725jqjnO3HO byFrPn3jVZ5yat5xpdMu+mencX83pXlE3R2PK7bKXNEjAkI9LCURS4dJD55D0SToFaXe ZHkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=BFrJ/+ltl7K7dps/H44hHowRUcHirZ03iwFtZyl89BA=; b=FqZKYskHsLtrgf9rOyWmgWNMiM+Fk8mOz1ywp09cCDSQ+dHGIzOODzF3sUWTpm4Bu1 tWkT7Q/bMaHu8GkfnVdH5GvQ2rmP4bvb6nNSzxUzUqeXNteB3WME72bMJbXjVNO1lzxq VopMLqw9sHuuD6Gv8jYjttMNFM6+rLiPHGwa+HB8FmMZGZe+dokkAzY2bfS+hEcZ9QKt tKdOPSXH4GtN6ImlA+WttN8nQCpsQoft3XADYk9IIMXhtrXM0DQlSb08yhKLSSKw+bsQ IGA+M9Nbbfu9wXA63vqcJd2DWVzCJ8/fmaVuC0f4KP8WSwoenTy/ZN+vVf6FnRUByy/o HOrg== X-Gm-Message-State: APf1xPAjjFqIwoMKwd7khRhusNY7sU6Sa7XvIJGyySKxojCrs4rz/SAP daVay9jp0sYc6BGbpLz4dNprjtFJ X-Google-Smtp-Source: AH8x227PSEwvjZR17dQniPXNY68GiBv9VM+OslY/eZx2070jnxXk9EqIwMc2yk0/v856rXMMAh7J6w== X-Received: by 10.80.171.166 with SMTP id u35mr10075984edc.117.1519126642693; Tue, 20 Feb 2018 03:37:22 -0800 (PST) Original-Received: from [192.168.1.3] ([185.105.174.193]) by smtp.googlemail.com with ESMTPSA id a14sm14944959edn.93.2018.02.20.03.37.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 20 Feb 2018 03:37:21 -0800 (PST) In-Reply-To: <87fu5w2jnh.fsf@gmx.de> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:143486 Archived-At: On 2/20/18 9:40 AM, Michael Albinus wrote: > I'm not so happy seeing git specific code in autorevert.el (yes, I know, > it's just an environment variable). All git specifics shall be kept in > vc-git.el. Otherwise, we would go into a dependency nightmare, soon. But this way the patch is much smaller, isn't it? That has maintainability benefits too. And using a variable would make more sense if we determine that other facilities, not just autorevert, make VC calls that we want to consider "background". > Do > you know, that magit would like to see this setting? I imagine it would, if it makes Git calls during autorevert (and if doesn't, the var won't do anything). But we could let it make that choice by itself, of course. > If this variable hurts for standard operation of vc-git, we could set it > depending whether (auto)revert is running, or not. There is the variable > `revert-buffer-in-progress-p', which is non-nil if reverting is in > progress. I could set it also before calling `vc-refresh-state' in > `auto-revert-handler'. And in vc-git.el, `process-environment' could be > extended or not, depending on the value of `revert-buffer-in-progress-p'. In which part of vc-git.el? Changing the implementation of two commands, like the original patch proposed, makes for a bigger change. We could do that in vc-git-command, I suppose...