From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: vc-dir operation is very slow on large git repositories in Emacs 26.1 Date: Thu, 28 Jun 2018 03:30:36 +0300 Message-ID: <40619f2d-1628-a9e7-7674-4d44789f2437@yandex.ru> References: <83k1qtsbgi.fsf@gnu.org> <30712254-6225-c6a8-1457-698c64e37739@yandex.ru> <83zhzltyii.fsf@gnu.org> <5218794b-b9ef-3c0d-d3c1-bf40c42e64b2@yandex.ru> <83r2kxtk9w.fsf@gnu.org> <5095ed13-d4a8-1699-26f9-746afaee0248@yandex.ru> <83in66sxig.fsf@gnu.org> <87bmbxbmvz.fsf@javad.com> <132e0090-3e44-dacf-2926-63624b3bb718@yandex.ru> <87fu19rlir.fsf@tromey.com> <340e65ee-dd83-74e9-4531-e8422064536b@yandex.ru> <837emkqn5o.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1530146168 26537 195.159.176.226 (28 Jun 2018 00:36:08 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 28 Jun 2018 00:36:08 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 Cc: alexharsanyi@gmail.com, tom@tromey.com, sorganov@gmail.com, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jun 28 02:36:04 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fYKup-0006o8-7T for ged-emacs-devel@m.gmane.org; Thu, 28 Jun 2018 02:36:04 +0200 Original-Received: from localhost ([::1]:33944 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fYKww-0002T6-F6 for ged-emacs-devel@m.gmane.org; Wed, 27 Jun 2018 20:38:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38067) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fYKpg-00069F-TM for emacs-devel@gnu.org; Wed, 27 Jun 2018 20:30:45 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fYKpd-00067J-OT for emacs-devel@gnu.org; Wed, 27 Jun 2018 20:30:44 -0400 Original-Received: from mail-wr0-x22b.google.com ([2a00:1450:400c:c0c::22b]:33860) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fYKpd-00067A-HA; Wed, 27 Jun 2018 20:30:41 -0400 Original-Received: by mail-wr0-x22b.google.com with SMTP id a12-v6so3696582wro.1; Wed, 27 Jun 2018 17:30:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=2DfUkOBMf99OjOxb0FRlP90PrwcRF1OF1bQzCRqyQzg=; b=opo5f/uHTxPRRd19sd/MkrEZ+bQewpgsM8JTak8zPha/yjNf1i3eZ3/TJuzxUc5RDF uqfO8uo/AoOaAtT9A/NXP1trP/GR0GkSD8/xNiR/6QnPGp1DPMqhEL1NoHSPguVbSNBS ZTmXv+ZvNuh1jeWHvF+0jx6ZSZbDEBw5qQWoHfbTaok7xud2DRoVXyVsOyTEXvBAWNVO wM1lj67PchAyw6Z9gTRCV6oHjatmYqS4q8FdkLkWH1rWHlgzmy3X/wKmEYHJyKN0NzKT CKvuFbpqu5AmJJkBHYj3GBfTLuWL+audmE50noQM++7MCoNZ7UJ3Ah/+XhdxmkNSLfdp MiZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=2DfUkOBMf99OjOxb0FRlP90PrwcRF1OF1bQzCRqyQzg=; b=NWgQKWQkE4CxCQqq/fdFkBekHo20L4obS5gUN8RpdXRR0N8+NgWQw8z0TjYKjl1MSt 9zq5xYyygQKWrUJ35QLWm5IGhyIC1B/lWMlQj0pNLjyI1rO6q/h1tIKRvoWAIuBPRO2o qGFQDGLFFPqSerHi0FBOAI2sQg4M10t8kJfElPieA/BgAxQfR7Po98MBtGdRK/9HsKsJ H8kRV9JA7/L4ke/R0o8Zy9Tyl0mK0W3SpYkat3cdBXIBHHu2RFSEbICAFz/4RYOxMOpb 5UBi/otM0K0NyjT0WrcG+cajulK+Yb2lfTwgx0lCkhfbFJUXbFwylCJIvmgLzFrvyelZ xULg== X-Gm-Message-State: APt69E2pC19wShUmVa1c/2Wzeiqe8sjguqhpVpMNsGqVDP18Tnuoylya 7Cj4tQfSKRJlvPF+fJpWoZza2AGb X-Google-Smtp-Source: AAOMgpd6AhwDkuh9oGl4ab2kmx+x/yMJPNRSqIhO6HxR13kc4pT7WlxLRTfmfZRj5MSf9G9noRwZmQ== X-Received: by 2002:adf:c892:: with SMTP id k18-v6mr7177020wrh.6.1530145840058; Wed, 27 Jun 2018 17:30:40 -0700 (PDT) Original-Received: from [192.168.1.3] ([185.105.174.23]) by smtp.googlemail.com with ESMTPSA id o13-v6sm4921381wmc.33.2018.06.27.17.30.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 27 Jun 2018 17:30:39 -0700 (PDT) In-Reply-To: <837emkqn5o.fsf@gnu.org> Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c0c::22b X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:226794 Archived-At: On 6/27/18 6:12 PM, Eli Zaretskii wrote: >> So I think we should try it and see if anything broken comes up? > > Yes. Although I'm slightly scared because the man pages say > > OPTIONS > -c > --cached > Show cached files in the output (default) > ... > -u > --unmerged > Show unmerged files in the output (forces --stage) > > which doesn't sound equivalent to me. But then I can never understand > the Git documentation well enough to be sure what it says... We don't need equivalent. The first option returns *all* files in the repository, which we want to get away from. >> Eli, OK for emacs-26? > > If you are sure -c and -u are equivalent here, yes, please. It works in my testing. But if I were 100% sure, I wouldn't be asking. Pushed, with a couple more tweaks (orthogonal ones).