From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#28864: 25.3.50; next-error-no-select does select Date: Tue, 17 Oct 2017 16:37:07 +0300 Message-ID: <4045abe7-1acb-314b-b9ac-72b62db30570@yandex.ru> References: <87bml72qck.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1508247659 24887 195.159.176.226 (17 Oct 2017 13:40:59 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 17 Oct 2017 13:40:59 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:56.0) Gecko/20100101 Thunderbird/56.0 To: Tino Calancha , 28864@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Oct 17 15:40:47 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e4S6r-0004J6-Ay for geb-bug-gnu-emacs@m.gmane.org; Tue, 17 Oct 2017 15:40:41 +0200 Original-Received: from localhost ([::1]:39425 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e4S6y-0004Bm-MJ for geb-bug-gnu-emacs@m.gmane.org; Tue, 17 Oct 2017 09:40:48 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45749) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e4S4P-00020q-1R for bug-gnu-emacs@gnu.org; Tue, 17 Oct 2017 09:38:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e4S4I-0006L0-P1 for bug-gnu-emacs@gnu.org; Tue, 17 Oct 2017 09:38:09 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:36420) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e4S4I-0006Kh-I9 for bug-gnu-emacs@gnu.org; Tue, 17 Oct 2017 09:38:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1e4S4I-00028M-9H for bug-gnu-emacs@gnu.org; Tue, 17 Oct 2017 09:38:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 17 Oct 2017 13:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28864 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 28864-submit@debbugs.gnu.org id=B28864.15082474398145 (code B ref 28864); Tue, 17 Oct 2017 13:38:02 +0000 Original-Received: (at 28864) by debbugs.gnu.org; 17 Oct 2017 13:37:19 +0000 Original-Received: from localhost ([127.0.0.1]:45101 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e4S3b-00027J-D0 for submit@debbugs.gnu.org; Tue, 17 Oct 2017 09:37:19 -0400 Original-Received: from mail-wm0-f68.google.com ([74.125.82.68]:43687) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e4S3Y-000270-U2 for 28864@debbugs.gnu.org; Tue, 17 Oct 2017 09:37:17 -0400 Original-Received: by mail-wm0-f68.google.com with SMTP id m72so9074874wmc.0 for <28864@debbugs.gnu.org>; Tue, 17 Oct 2017 06:37:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=gULiBf4NBgyOnqH0HlxU896gLWwT2z7mnrHpyAFdHRM=; b=pn2uP5rjmxlI3fUEitiEkiBFRYNVah0XFJnNKcu+CJ2dBj8aMCHMw7pAs5y9ISGhYi 5Sr9y9K2bUdGDhFYcMV4rDbde1sYbOTXVUsIWpaZ3sGGjdnkn5xWfT9NnV5Yf0Xjh4VA 2ngxOVAgNoC6sTb/eabPDZKDKAMV0kRgSMcuEAnyv8VNDTD7osoQKicqek/OCQletlpX GXl+VSK0QDGzJmAvHPgCNOb3WGiXv5Ar0JBEXDfjtxBPOu/ksKn4gdocjtDwQjh50vcU w+1xA2plEgYNrNocEbKL8ub4Kdsy+3YlysWypC5byhw69kVAdKBtd5s/O/b/4tPWL0wn uSjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=gULiBf4NBgyOnqH0HlxU896gLWwT2z7mnrHpyAFdHRM=; b=przitzRNVjdAv0Vhl/DrPnt7joBXvHDF1RT+vL33KFmONH8nsXxHUtDiwuqR7RwofV UUaNREGVfjkk17bvUZkLX3ET5crSdfLt3lk7X+WPXS24elN65E0beriTZ4z0ba2nogYy lhUyRb0T3/Iua2YYTaghFzg6shrIaaprvlwy9X5ZvcjWKH6RJtHibmKWjRHJ19hn1TyJ yeU5GHNO2Rj0p3zwC4Pnrm3DVO4bZDyJ+cUl3qMZbO9LFETl9N7uTjZWuIJHNqgm2v04 BqjNp1njUWhaiDgTPgDfAc4nhTske5TwKewZbtzK+aOvUP1+TWzO4NhZP6v4JediEckz WL0g== X-Gm-Message-State: AMCzsaWuzmUzq+8iT5ogAP6wQoEdnPO3B+9DomLuSZCA6NtJUrEGl8zY oDdRXMJAKaDjjZjeJbp7yOUzd+Rx X-Google-Smtp-Source: ABhQp+SH+Fsa4YL9e70rYzrQQfansZwTSxC5hP0P55yMERt0oS7slxma+XBviVKsxzkFo9PRCaKojg== X-Received: by 10.28.155.18 with SMTP id d18mr3748647wme.107.1508247430712; Tue, 17 Oct 2017 06:37:10 -0700 (PDT) Original-Received: from [192.168.0.133] (static-nbl2-118.cytanet.com.cy. [212.31.107.118]) by smtp.googlemail.com with ESMTPSA id i76sm3794563wmd.2.2017.10.17.06.37.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 17 Oct 2017 06:37:09 -0700 (PDT) In-Reply-To: <87bml72qck.fsf@gmail.com> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:138616 Archived-At: Hi! On 10/16/17 4:07 PM, Tino Calancha wrote: > X-Debbugs-CC: Dmitry Gutov I'm happy to commiserate, but it's hard to tell for me which part of next-error* is broken for this use case. If not all of it, basically. For instance, I don't understand why the patch at the end doesn't fix the problem, and makes it worse instead (the behavior becomes less predictable). Why doesn't it? If we have to call next-error, and it normally changes window configuration, save-selected-window seems like a natural fix. > ;; Start emacs in the emacs root source dir > emacs -Q > > M-x grep-find RET > ;; Use following command: > find . -type f -name ChangeLog\* -exec grep --color -nH -e baz {} + > C-x o n ; This selects the source (shouldn't) > ;; If doesn't select the source, try 'n' a few times more; eventually > ;; you will be in the source. It selects the source at the first try here, ever time. Here's the patch that doesn't work: diff --git a/lisp/simple.el b/lisp/simple.el index 5ef511ce0a..16ac4b6788 100644 --- a/lisp/simple.el +++ b/lisp/simple.el @@ -325,8 +325,8 @@ next-error-no-select select the source buffer." (interactive "p") (let ((next-error-highlight next-error-highlight-no-select)) - (next-error n)) - (pop-to-buffer next-error-last-buffer)) + (save-selected-window + (next-error n)))) (defun previous-error-no-select (&optional n) "Move point to the previous error in the `next-error' buffer and highlight match.