From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eric Gillespie Newsgroups: gmane.emacs.bugs Subject: bug#60897: 29.0.60; vc-revert fails to revert buffer Date: Fri, 20 Jan 2023 18:54:14 -0600 Message-ID: <40201.1674262454@hassadar.pretzelnet.org> References: <29401.1674004194@hassadar.pretzelnet.org> <86edrr4zcz.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14403"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 60897@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jan 21 01:55:28 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pJ2AJ-0003Tk-Df for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 21 Jan 2023 01:55:27 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pJ29z-0005cR-9C; Fri, 20 Jan 2023 19:55:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pJ29u-0005bm-So for bug-gnu-emacs@gnu.org; Fri, 20 Jan 2023 19:55:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pJ29u-0006Gm-Bi for bug-gnu-emacs@gnu.org; Fri, 20 Jan 2023 19:55:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pJ29t-0007bn-MR for bug-gnu-emacs@gnu.org; Fri, 20 Jan 2023 19:55:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eric Gillespie Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 21 Jan 2023 00:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60897 X-GNU-PR-Package: emacs Original-Received: via spool by 60897-submit@debbugs.gnu.org id=B60897.167426246929204 (code B ref 60897); Sat, 21 Jan 2023 00:55:01 +0000 Original-Received: (at 60897) by debbugs.gnu.org; 21 Jan 2023 00:54:29 +0000 Original-Received: from localhost ([127.0.0.1]:47574 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pJ29N-0007ax-47 for submit@debbugs.gnu.org; Fri, 20 Jan 2023 19:54:29 -0500 Original-Received: from relay1-d.mail.gandi.net ([217.70.183.193]:38021) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pJ29J-0007ad-2h for 60897@debbugs.gnu.org; Fri, 20 Jan 2023 19:54:27 -0500 Original-Received: (Authenticated sender: epg@pretzelnet.org) by mail.gandi.net (Postfix) with ESMTPSA id A4450240003; Sat, 21 Jan 2023 00:54:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pretzelnet.org; s=gm1; t=1674262458; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hEIMyKvdiRcKbOdtmYwC7YQ5gLo86BBG1cfFv6CzJK0=; b=VpuTD0ceNtx+0lwky+XMPXZGm8dphogbKPbLQXGz70HFr8MlRFdyi9Q+J8xwIxAU644WBn Lv3kXe7/UQjwjEoSq66PWkUbGSnKFco8tu/8LyBSP5OK8OGDqdjSDFczIq64zFK5LoIk9E KbVhswG+1/NxWgBvGD0s7oyByD40vCCwOgGJXuas68o19WfzmolXYSC2auF94gbhKEdrWB bXgUZlNQfukxugjM/PQEAsO66Az2upCE/1JpOOM63dAMB33j46IrahKX4mNJBTUDqBZAzV AhVrB2FPlNHZDlNfF+G55tKSR9i1Mq4FxjGaK+PEaTfXlq/mxRpa7gCpsj2IgA== In-reply-to: <86edrr4zcz.fsf@mail.linkov.net> X-Mailer: MH-E 8.6+git; nmh 1.7+dev; GNU Emacs 28.1 Content-ID: <40200.1674262453.1@hassadar.pretzelnet.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:253816 Archived-At: Juri Linkov writes: > The behavior of C-x v u in the diff buffer was improved in emacs-29 > to revert all files mentioned in the diff. In emacs-28 it reverted > only one file, but in emacs-29 when the diff buffer shows many files, > such as after C-x v D, all these files are reverted. Interesting, I hadn't noticed. Actually, I just tried reverting two files from the diff buffer in 28.2 and it worked. I've been regretting not finding the time to report the vc bug I ran across in emacs 28, but then when 4803fba487d41f0817feab48b5095ef4b4940ff6 showed up and fixed what I HAD noticed, I stopped worrying about it. I'm getting worried again :) Here's what I see: 1. edit two versioned files 2. mark them both in vc-dired 3. =3D to show the diff for the two marked files 4. C-x v u In emacs 27 and 28, both files are reverted. Now, do the same first 3 steps again but now: 4. C-x v v 5. write a log message 6. C-c C-c In 23.1 and 27: commits, as it has since vc-dired was born in 23.1 (I have 23.1 handy and just confirmed I was not misremembering). In 28, you get this baffling prompt: 'Buffer *vc-diff* modified; save it? (yes or no)' Neither option commits :) It seemed to go back to normal with commit 4803fba487d41f0817feab48b5095ef4b4940ff6 on my daily driver openSUSE laptop, but it's not working on my home FreeBSD box! I'll look into that more... I can't seem to make that fail a second time. But this was the error message I got: vc-do-command: Failed (status 128): git --no-pager apply --cached ../../..= /../tmp/git-patch11lenk Which is a pretty strange path and which does not exist. If you add one more ../ (five total) you will indeed reach /tmp but that would be a strange way to reference it. Thanks!