* [PATCH 0/5] EWW: Various minor fixes
@ 2013-12-19 23:44 Rüdiger Sonderfeld
2013-12-21 20:14 ` Ted Zlatanov
0 siblings, 1 reply; 2+ messages in thread
From: Rüdiger Sonderfeld @ 2013-12-19 23:44 UTC (permalink / raw)
To: emacs-devel; +Cc: Lars Magne Ingebrigtsen, Ted Zlatanov
Hello,
I did some minor fixes for eww.el. I guess most changes are uncontroversial.
But I wanted to check back before committing them.
Maybe the tool bar support needs a bit more discussion. I know most users
(including me) disable the tool bar anyway. But for the sake of user
friendliness we should support it. I only added commands where I could find
an existing icon for in /etc/images.
Regards,
Rüdiger
Rüdiger Sonderfeld (5):
eww: Use `user-error'.
eww: Add menu for `eww-bookmark-mode'.
eww: Use `setq-local'.
eww: Add tool bar support.
eww: Check for `html-mode' using `fboundp'.
lisp/ChangeLog | 13 +++++++++
lisp/net/eww.el | 84
++++++++++++++++++++++++++++++++++++++-------------------
2 files changed, 69 insertions(+), 28 deletions(-)
--
1.8.5
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 0/5] EWW: Various minor fixes
2013-12-19 23:44 [PATCH 0/5] EWW: Various minor fixes Rüdiger Sonderfeld
@ 2013-12-21 20:14 ` Ted Zlatanov
0 siblings, 0 replies; 2+ messages in thread
From: Ted Zlatanov @ 2013-12-21 20:14 UTC (permalink / raw)
To: Rüdiger Sonderfeld; +Cc: Lars Magne Ingebrigtsen, emacs-devel
On Fri, 20 Dec 2013 00:44:09 +0100 Rüdiger Sonderfeld <ruediger@c-plusplus.de> wrote:
RS> I did some minor fixes for eww.el. I guess most changes are uncontroversial.
RS> But I wanted to check back before committing them.
RS> Maybe the tool bar support needs a bit more discussion. I know most users
RS> (including me) disable the tool bar anyway. But for the sake of user
RS> friendliness we should support it. I only added commands where I could find
RS> an existing icon for in /etc/images.
RS> Regards,
RS> Rüdiger
RS> Rüdiger Sonderfeld (5):
RS> eww: Use `user-error'.
RS> eww: Add menu for `eww-bookmark-mode'.
RS> eww: Use `setq-local'.
RS> eww: Add tool bar support.
RS> eww: Check for `html-mode' using `fboundp'.
Since we didn't hear from Lars and all the changes looked good, I
committed them, thank you. Lars, please let us know if you object to
any of it.
Thanks
Ted
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-12-21 20:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-19 23:44 [PATCH 0/5] EWW: Various minor fixes Rüdiger Sonderfeld
2013-12-21 20:14 ` Ted Zlatanov
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.