From: Dmitry Gutov <dgutov@yandex.ru>
To: Michael Arndt <michael@rndt.dev>, 56624@debbugs.gnu.org
Subject: bug#56624: 28.1.50; dired-do-find-regexp fails when using ripgrep
Date: Sat, 23 Jul 2022 16:14:48 +0300 [thread overview]
Message-ID: <4007a633-f154-c379-0b7b-c08bc43de9d0@yandex.ru> (raw)
In-Reply-To: <eb5e3163-8e47-e789-294e-18ce31ee51db@rndt.dev>
Hi!
Thanks for the report.
On 17.07.2022 22:05, Michael Arndt wrote:
> Hi,
>
> I have the following problem when using dired-do-find-regexp. When I use
> it in a
> directory that contains a binary file the search will fail with the
> following message:
>
> xref-matches-in-files: Search failed with status 0: /tmp/test/hello_bin:
> binary file matches (found "\0" byte around offset 5)
>
> If there are matches in non binary files they won't be shown. This only
> happens
> when xref-search-program is set to 'ripgrep.
>
> Steps the reproduce the issue with emacs -Q:
>
> 1. (customize-set-variable 'xref-search-program 'ripgrep)
> 2. Create the following files in a new directory (^@ is a null byte):
>
> hello_bin:
> hello^@world
>
> hello.txt:
> hello world
>
> 3. Open the directory in dired
> 4. Use dired-do-find-regexp on the current directory and search for "hello"
>
> A bit of testing revealed that the issue seems to be related to the
> ordering of
> the files. Renaming hello_bin to ahello_bin makes the problem go away.
This is due to a change in Ripgrep 13, which made it incompatible with
GNU Grep in that respect:
https://github.com/BurntSushi/ripgrep/releases/tag/13.0.0
I've pushed as fix to master in commit 38d5e346df. Please test it out.
next prev parent reply other threads:[~2022-07-23 13:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-17 19:05 bug#56624: 28.1.50; dired-do-find-regexp fails when using ripgrep Michael Arndt
2022-07-23 8:24 ` Lars Ingebrigtsen
2022-07-23 13:14 ` Dmitry Gutov [this message]
2022-07-23 17:40 ` Michael Arndt
2022-07-23 18:12 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4007a633-f154-c379-0b7b-c08bc43de9d0@yandex.ru \
--to=dgutov@yandex.ru \
--cc=56624@debbugs.gnu.org \
--cc=michael@rndt.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.