From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: Change in vc-git ls-files-unknown makes emacs hang Date: Fri, 20 Dec 2019 00:42:24 +0200 Message-ID: <3ffa93fe-06af-2920-812c-4a67367f2933@yandex.ru> References: <08cfaf0c-215f-1b02-37f8-2b3886a319c7@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="255436"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 To: emacs-devel@gnu.org, andreyk.mad@gmail.com Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Dec 19 23:43:16 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1ii4Vk-0014Jx-9M for ged-emacs-devel@m.gmane.org; Thu, 19 Dec 2019 23:43:12 +0100 Original-Received: from localhost ([::1]:48502 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ii4Vj-0007X7-0W for ged-emacs-devel@m.gmane.org; Thu, 19 Dec 2019 17:43:11 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49190) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ii4V3-00075S-Hq for emacs-devel@gnu.org; Thu, 19 Dec 2019 17:42:30 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ii4V2-0005aZ-CN for emacs-devel@gnu.org; Thu, 19 Dec 2019 17:42:29 -0500 Original-Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]:50352) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ii4V2-0005WV-2y for emacs-devel@gnu.org; Thu, 19 Dec 2019 17:42:28 -0500 Original-Received: by mail-wm1-x335.google.com with SMTP id a5so7056158wmb.0 for ; Thu, 19 Dec 2019 14:42:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=6N0snRTKB7OwZLq7OwQhzJCG43UMWm3xtXiCnyGFFN0=; b=Ou1EpL90mcNTK4FRUz4h6CUBuRfzbyrO1JcuUiFFi5rtlHPPgeZkgX7PAhrtsvm1Xl VgZqZSgcTxgUZaKnQASp4Z7eIxBWaIFQ4oBKPz51V2a3LNI4Y2NydAlCoxRPsVcpG3/K MY+sQkIxJfNnI2Ic6QOIlZRiElno1qbjkceqaO0uZfoLgdgeTvEBJlyrkys5wPl+wSr8 CjWA2w6RM+Mn3fuXBTqXxJk6hh6iEzqHv/+/WJ83LJUU0YXguR68meNImMtwkk9xTz1+ xuIdK6gd4lsL8d0NiicJiDwBTelGuvASIXrNmz9aQCBByaddZnyCwugao8t+aTGPw1Ka kSRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=6N0snRTKB7OwZLq7OwQhzJCG43UMWm3xtXiCnyGFFN0=; b=R6gusnSmqky97l/8AfdjySDq7MZpx4ZlsLspn5VG4RPcqNCXakTWo3WBECpf9BX8b2 jMioPfwBIFMPT4Gwukd+G1r/C2V1R210F0mYoLz2mkMl+wIb6RDJsnE79xCp3wubtqZP ptSVt38FlX5PA6Q6DjS6qkukH16Akgu3tzgpPGs4ehBFWC2n1nanSy5X8tIgIE+otkd/ CnXF+bBrK3hMaodpVy5Pvrl/F+cqEu3u7OcmhpftAZScvGpmgbuKIaguSDTzU0MnMzX9 C3v+KwIqt6022hmtv1pY7F0+Y2gXWO5a2oy8Z7txMiRudiT+7fP2GHuKlotS/D36bvlr F4Mg== X-Gm-Message-State: APjAAAUd9yuzibKoeImihaZoR5Jb7MBcVNe1F8QT7Uef87bRv9sGnNQ0 D65Pq9VXVpnS5Bk6P09VkYM= X-Google-Smtp-Source: APXvYqxh4ZsKVLQ+GRD8f0UQo6zS6BzglB0aFl34SNCnGCUNIgzvnmB16Q93eVq1R3WzkUa1Xwh3Zg== X-Received: by 2002:a1c:b603:: with SMTP id g3mr12141574wmf.133.1576795346827; Thu, 19 Dec 2019 14:42:26 -0800 (PST) Original-Received: from [192.168.0.5] ([212.50.117.215]) by smtp.googlemail.com with ESMTPSA id o194sm7919393wme.45.2019.12.19.14.42.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 19 Dec 2019 14:42:26 -0800 (PST) In-Reply-To: Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::335 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:243498 Archived-At: On 19.12.2019 22:44, Filipp Gunbin wrote: > Yes, I caught it, and this: > >> UUIC, the only case where this change should lead to a performance >> problem is a Git repository with lots of unregistered files. Ones not >> hidden by gitignore. > > is exactly my use case. I have git repo right in my home dir, mainly > for dot-files. Most other stuff there is in .gitignore, but there're > some not-ignored directories with large amount of files, Then, first of all, you know the workaround: add some gitignore entries. > like .ivy2 with > cache of jars from ivy repositories. I wonder: how many files? And it would be helpful, of course, to figure out which code calls it during desktop-read. It's probably not VC-Dir, or you would have have noticed it much earlier. Maybe some third-party code? > And vc-dir there (or in a subdirectory) leads to a freeze. I'm hesitant to revert it because VC-Dir really doesn't deal with the previous format very well (meaning, directories with statuses returned only sometimes). And before the latest change you couldn't easily register new files from the VC-Dir buffer if the directory they are in is also new. So, opinions welcome.