all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Dmitry Gutov <dgutov@yandex.ru>
To: Eli Zaretskii <eliz@gnu.org>, Paul Rankin <hello@paulwrankin.com>
Cc: 28855@debbugs.gnu.org
Subject: bug#28855: 26.0.90; display-line-numbers-mode does not respect (line|wrap)-prefix '(space :align-to N) text property
Date: Wed, 18 Oct 2017 12:29:08 +0300	[thread overview]
Message-ID: <3fdce54f-f704-66df-75db-843dbd98ec50@yandex.ru> (raw)
In-Reply-To: <83po9nf58h.fsf@gnu.org>

Hi Eli,

On 10/16/17 7:05 PM, Eli Zaretskii wrote:

> When this was briefly discussed during development, we decided not to
> change the reported window dimensions and geometry, including those of
> the text area, to account for the screen estate taken by the
> line-number display.

FTR, I'd have preferred for the line numbers to be considered outside of 
the window edge, together with fringes and margins. And I still don't 
see any downside to it (except it might be harder to implement).

As it is now, third-party code has to adapt instead, by handling the 
line numbers specially.

> But maybe :align-to should be an exception, when
> used to align buffer text (as opposed to header-line or mode-line)?
> Though I'm bothered whether some users of :align-to may not want this
> automatic offset.  :align-to is a very popular feature; does anyone
> know or imagine why a Lisp program would NOT like such an offset?
> 
> What do people think?  Dmitry, what about company-mode popups, for
> example?

Not sure. What about them? We don't use align-to in the popups (though 
we could, for space-only offsets, now that I've read about this spec; 
not sure if the change will be worth it, performance or memory-wise).

And as for align-to's used in the buffer text, we probably don't support 
them very well, but the proposed change shouldn't make it any worse, I 
think.





  parent reply	other threads:[~2017-10-18  9:29 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-16  3:38 bug#28855: 26.0.90; display-line-numbers-mode does not respect (line|wrap)-prefix '(space :align-to N) text property Paul Rankin
2017-10-16 16:05 ` Eli Zaretskii
2017-10-17  0:47   ` Paul Rankin
2017-10-17  2:44     ` Eli Zaretskii
2017-10-17  4:04       ` Eli Zaretskii
2017-10-17  4:32         ` Paul Rankin
2017-10-17  5:49           ` Eli Zaretskii
2017-10-17  7:17             ` Paul Rankin
2017-10-18  9:29   ` Dmitry Gutov [this message]
2017-10-18 16:47     ` Eli Zaretskii
2017-10-18 17:44       ` martin rudalics
2017-10-18 17:55         ` Eli Zaretskii
2017-10-20  9:40           ` Eli Zaretskii
2017-10-18 18:05         ` Eli Zaretskii
2017-10-18 18:34           ` martin rudalics
2017-10-18 18:44             ` Eli Zaretskii
2017-10-18 23:58           ` Alex
2017-10-19  3:26             ` Eli Zaretskii
2017-10-19  5:54               ` Alex
2017-10-20  7:03                 ` Eli Zaretskii
2017-10-18 22:52       ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3fdce54f-f704-66df-75db-843dbd98ec50@yandex.ru \
    --to=dgutov@yandex.ru \
    --cc=28855@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=hello@paulwrankin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.