From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.bugs Subject: bug#67357: [PATCH] Fix c-ts-mode block indent when first-siblings are comments Date: Sun, 10 Dec 2023 17:11:42 -0800 Message-ID: <3fa4a664-0b5c-46d8-a3c0-2d954744a5e6@gmail.com> References: <834jhchqha.fsf@gnu.org> <08e16d44-174d-87e6-aa17-8cf55202227b@gutov.dev> <83wmu8fsj7.fsf@gnu.org> <8334wvfdna.fsf@gnu.org> <83y1endx9z.fsf@gnu.org> <83cyvs7jte.fsf@gnu.org> <83ttoryebi.fsf@gnu.org> <8c7e244d-5dad-4111-89b8-ca7722657ce0@gmail.com> <834jgqwg4s.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39082"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: noah.v.peart@gmail.com, 67357@debbugs.gnu.org, dmitry@gutov.dev To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Dec 11 02:13:02 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rCUqz-0009xo-AZ for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 11 Dec 2023 02:13:01 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rCUqo-0008KX-9v; Sun, 10 Dec 2023 20:12:50 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rCUqm-0008Hw-K3 for bug-gnu-emacs@gnu.org; Sun, 10 Dec 2023 20:12:48 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rCUqm-0000Pd-99 for bug-gnu-emacs@gnu.org; Sun, 10 Dec 2023 20:12:48 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rCUr0-00041y-Is for bug-gnu-emacs@gnu.org; Sun, 10 Dec 2023 20:13:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 11 Dec 2023 01:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67357 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 67357-submit@debbugs.gnu.org id=B67357.170225712915384 (code B ref 67357); Mon, 11 Dec 2023 01:13:02 +0000 Original-Received: (at 67357) by debbugs.gnu.org; 11 Dec 2023 01:12:09 +0000 Original-Received: from localhost ([127.0.0.1]:52152 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rCUq8-000404-Rt for submit@debbugs.gnu.org; Sun, 10 Dec 2023 20:12:09 -0500 Original-Received: from mail-pl1-x632.google.com ([2607:f8b0:4864:20::632]:53538) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rCUq4-0003zL-Gm for 67357@debbugs.gnu.org; Sun, 10 Dec 2023 20:12:07 -0500 Original-Received: by mail-pl1-x632.google.com with SMTP id d9443c01a7336-1d307cf18fdso1950195ad.3 for <67357@debbugs.gnu.org>; Sun, 10 Dec 2023 17:11:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702257104; x=1702861904; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=/+XuQI8dPrrQNccnVQJOCvO4rH+jbMQPtwd3hmazd7w=; b=arqlNtQ+eVlc2D/T/WljJzMkttQWqMvMi9S0ZfTqKRzot19uZIQH0YT9U8Rf6CLlJq vlDzFaJaWNLsK2wV3GaIcpozMMXBe1mp6DHG7yfWcJ2MgJ8zSnPlra1zEs6g9iNUxode avZ5bLA/3gP+cLcluZlZHuH+tPtitwZ9NcolYf/tuv1ZxQk8LStEUn6b8nRvyAbRFgMo kobkHlAwSM5aX+4WQnbaeoh8J8z2v4H/D4HtbSs/OJJ+gPZzp9El8YJhOmlcMYY2jYYH VMh2eicxF7+9ssIYcqO8c/qhUC/3vURikmOMp5pFx7ctzI+kwuZgi0udzbp52TjG7vtu c2oQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702257104; x=1702861904; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/+XuQI8dPrrQNccnVQJOCvO4rH+jbMQPtwd3hmazd7w=; b=FfSTJv45tohj9zJWihTcJV2y0E/tt4anmOtl5J7uk5ZxxL0DQXNf9DdJ/I03HEaGfZ V4ipBVpxKO/yEWI0eQu0zVPfHaZWyb/xP8EtuxpmlrL5N4ytt87zcSjaHO3NLUgDFipb btwkTtTCkof6KVxpJT7yYfMybU4uJf2ChdxYIbJ6hW0QXID/vq9KJX5tHQ46/ROFJnRG kW2z0qaRab20ZtPLjXU0VGauIMayeGMMJpVqCgxfiCX32EAveNZDFFxyyDkKLgeYRxKp A7OU8Vt08zmWeNylV9wuV5feyoxV1QhS/S2b6iDqsd9xULoopvZVbyRXs4HtH319O1+p 07NA== X-Gm-Message-State: AOJu0YwtZC6VOIVyBk2tRBD9LkA9zNJYJx4sPdek61ElpwRz8KqPCYNS RMLvXYUJgKAAcXpi4r9W8/k= X-Google-Smtp-Source: AGHT+IE06IRDWFtN8Q2zNWbcCah2jfUXXE6Esevm/ebK+fPPY9wq+0cjYEmo753m/p3Up82cFGLfgQ== X-Received: by 2002:a17:903:11cf:b0:1d3:1bea:eb56 with SMTP id q15-20020a17090311cf00b001d31beaeb56mr396625plh.115.1702257103714; Sun, 10 Dec 2023 17:11:43 -0800 (PST) Original-Received: from [192.168.1.7] (172-117-161-177.res.spectrum.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id n6-20020a170902e54600b001d1cd7e4ad2sm5301678plf.125.2023.12.10.17.11.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 10 Dec 2023 17:11:43 -0800 (PST) Content-Language: en-US In-Reply-To: <834jgqwg4s.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:275956 Archived-At: On 12/10/23 1:39 AM, Eli Zaretskii wrote: >> Date: Sun, 10 Dec 2023 01:09:15 -0800 >> Cc: noah.v.peart@gmail.com, 67357@debbugs.gnu.org, dmitry@gutov.dev >> From: Yuan Fu >> >> >>> Ping! Ping! Yuan, please chime is, as I'm waiting for your comments >>> before we install on the release branch. >>> >>> This and other patches for TS-based modes are currently delaying the >>> release of Emacs 29.2, so please try to be more responsive, okay? >>> >> Whoa! Sorry, I just switched to a new email client, and direct CC isn't >> highlight as they were before :-( (And admittedly I haven't been >> browsing the bug tracker lately.) > OK, but please look also at other bugs and issues where I asked for > your opinions. Yes, I'm trying to setup something that can prevent this in the future, and there are so many CC's that I missed, apologies! >> As for the patch, first of all, thank you, Noah, it's very good. I try >> to avoid query matchers since they could be slow, plus the fundamental >> problem isn't with comments, IMO. The problem is when the first sibling >> isn't on it's own line. (Though in normal C source code, when the first >> sibling isn't on its own line, that sibling is usually a comment.) >> Anyway, please see my reasoning in the commit message for 08fc6bace20. >> >> I also removed the else_clause rule since it's already added by the >> patch for bug#67417, and added another test. > Thanks, but please in the future mention _all_ relevant bug numbers > in the log message, or merge them if appropriate. I'll keep that in mind. Yuan