From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#65470: 29.1.50; js-ts-mode: regex pattern can cause incorrect parenthesis matching Date: Fri, 25 Aug 2023 03:18:54 +0300 Message-ID: <3f955b21-1394-a7bd-ed35-064d8731e751@gutov.dev> References: <59d884e2-4190-7111-8a37-548eb5a2c732@gutov.dev> <83fs49q8ui.fsf@gnu.org> <87bkew6x4y.fsf@thornhill.no> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------y7wmXBhAaJpiuERO0BijYQkc" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5447"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Cc: btuin@mailo.com, 65470@debbugs.gnu.org To: Theodor Thornhill , Eli Zaretskii , Jostein Kjonigsen , Yuan Fu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Aug 25 02:20:27 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qZKYr-0001DR-Tn for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 25 Aug 2023 02:20:27 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qZKYR-0002os-S5; Thu, 24 Aug 2023 20:19:59 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qZKYQ-0002oa-G7 for bug-gnu-emacs@gnu.org; Thu, 24 Aug 2023 20:19:58 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qZKYQ-0003SP-7n for bug-gnu-emacs@gnu.org; Thu, 24 Aug 2023 20:19:58 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qZKYT-0001c3-U3 for bug-gnu-emacs@gnu.org; Thu, 24 Aug 2023 20:20:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 25 Aug 2023 00:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65470 X-GNU-PR-Package: emacs Original-Received: via spool by 65470-submit@debbugs.gnu.org id=B65470.16929227536127 (code B ref 65470); Fri, 25 Aug 2023 00:20:01 +0000 Original-Received: (at 65470) by debbugs.gnu.org; 25 Aug 2023 00:19:13 +0000 Original-Received: from localhost ([127.0.0.1]:38827 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qZKXg-0001ak-J2 for submit@debbugs.gnu.org; Thu, 24 Aug 2023 20:19:13 -0400 Original-Received: from out2-smtp.messagingengine.com ([66.111.4.26]:49935) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qZKXe-0001aV-DT for 65470@debbugs.gnu.org; Thu, 24 Aug 2023 20:19:11 -0400 Original-Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id CBA695C0276; Thu, 24 Aug 2023 20:19:00 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Thu, 24 Aug 2023 20:19:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm3; t=1692922740; x=1693009140; bh=oZ S+mHjpeYXb2Wr7DDBY6nl9gNrcCOdQLFndJrOK3QI=; b=SbwDS5lQtznWBsrfLU bE1GqGjc9TKWZNQNzqShpXWt7kqf2bTY6xvDhexnm0wbWXa6ZeeOWKwLww8NpvjD ktqxYmCIoAsmihxlufswk3aQdZWuCp/3ok5LFTxxJw1OYkmv1Nw5eHii76jTPL6L 6VyYPQI37L7W0PcZA3PaIK4Wr0/UCE8sBdOF3eFzf1jDP8fhHocOGKqoJKF67Ybn rs03bJmNaOM6YFK8tnZHDF/73Afk0INUBpeaVXKYQXbvmujUvpbIC+tur+rGrmrT 7TX4WdAYuF2psqsIjeTX3qsbYIut3gCxsCcDyYrhg+NVDpVB8xHGa6gojQOUDomA pEjQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1692922740; x=1693009140; bh=oZS+mHjpeYXb2 Wr7DDBY6nl9gNrcCOdQLFndJrOK3QI=; b=FqnuzwmFsrtneTCsqZvWz0upfJamS rkVV4yRtr84ZhlFlcalh7HmSSj3QaHZVl9z3pzFQ+qo2HWzgpRaWv8hMnnUjqaGu UGVEWLmwjLXgPMmhIwA0JwHPu+BAtAD5b+AQKbjM7z0xzawiFO+/OW2yeWKVJ+Le 3WsgQrHgD9T0aC8WMfF2pnI2qALii1Lzdxchm4R5Gdy+qZAY138petgDlkIFPpV5 Zm/hQ0HELA3IfnrbSvnmz8rhByPxR3PWo8zs5u+FSccd+y6djx+8sT5XOKv2h1jq XrYF4sBd/Y8X4m2e7stRgGIZK/SnUYhihT6SjEt+h3rENp2xXGASrNeoQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedruddvjedgfedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurheptgfkffggfgfuvfevfhfhjgesmhdtreertdefjeenucfhrhhomhepffhmihht rhihucfiuhhtohhvuceoughmihhtrhihsehguhhtohhvrdguvghvqeenucggtffrrghtth gvrhhnpeehteekgfetieeujeeuvddtvdelteffleejteduvdefffejieehheeuteffveei jeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegumh hithhrhiesghhuthhovhdruggvvh X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 24 Aug 2023 20:18:58 -0400 (EDT) Content-Language: en-US In-Reply-To: <87bkew6x4y.fsf@thornhill.no> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:268373 Archived-At: This is a multi-part message in MIME format. --------------y7wmXBhAaJpiuERO0BijYQkc Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 24/08/2023 22:47, Theodor Thornhill wrote: > Eli Zaretskii writes: > >>> Date: Wed, 23 Aug 2023 16:23:13 +0300 >>> From: Dmitry Gutov >>> >>> On 23/08/2023 12:05, Augustin Chéneau (BTuin) wrote: >>>> With the mode js-ts-mode, matching tokens (such as '()', '[]') can be >>>> incorrectly paired by `show-paren-mode`. This is trivially reproducible >>>> with this simple example: >>>> >>>> (/foobar)/) >>>> >>>> The first parenthesis is matched with the second one, which is inside a >>>> regular expression pattern (between slashes), and the last one is not >>>> paired. >>>> >>>> The behavior should be the same as for string, the content of the regex >>>> pattern should have no influence on the structure of the code. The first >>>> parenthesis should match with the third one. Here, the first parenthesis >>>> is matched with the last one: >>>> >>>> ("foobar)") >>>> >>>> js-mode behaves correctly in both cases. >>> Sounds like js-ts-mode also needs a syntax-propertize-function, similar >>> to c-ts-mode, ruby-ts-mode and rust-ts-mode. >>> >>> Others (typescript-ts-mode?) probably need it as well, at least modes >>> for those languages that have dedicated regexp or heredoc syntax. >> Would someone please add syntax-propertize-function in modes that need >> it? I think this should be done on the emacs-29 branch. >> >> TIA > I'll add it to my list, but if someone will grab it that's fine, as I'm > a little short on time the next couple of weeks 🙁 This one seems to work for js-ts-mode. typescript is a bit more fiddly (two separate modes, one with jsx and one without), but should be able to follow the similar pattern. --------------y7wmXBhAaJpiuERO0BijYQkc Content-Type: text/x-patch; charset=UTF-8; name="js-ts--syntax-propertize.diff" Content-Disposition: attachment; filename="js-ts--syntax-propertize.diff" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL2xpc3AvcHJvZ21vZGVzL2pzLmVsIGIvbGlzcC9wcm9nbW9kZXMvanMu ZWwKaW5kZXggOWQyOTkwZTdiYzkuLjIzZmRjNTc1MzNkIDEwMDY0NAotLS0gYS9saXNwL3By b2dtb2Rlcy9qcy5lbAorKysgYi9saXNwL3Byb2dtb2Rlcy9qcy5lbApAQCAtMzgyOSw2ICsz ODI5LDcgQEAganMtdHMtbW9kZQogICAgICAgICAgICAgICAgIChhcHBlbmQgInt9KCk6Oyw8 Pi8iIGVsZWN0cmljLWluZGVudC1jaGFycykpIDtGSVhNRToganMyLW1vZGUgYWRkcyAiW10q Ii4KICAgICAoc2V0cS1sb2NhbCBlbGVjdHJpYy1sYXlvdXQtcnVsZXMKIAkgICAgICAgICco KD9cOyAuIGFmdGVyKSAoP1x7IC4gYWZ0ZXIpICg/XH0gLiBiZWZvcmUpKSkKKyAgICAoc2V0 cS1sb2NhbCBzeW50YXgtcHJvcGVydGl6ZS1mdW5jdGlvbiAjJ2pzLXRzLS1zeW50YXgtcHJv cGVydGl6ZSkKIAogICAgIDs7IFRyZWUtc2l0dGVyIHNldHVwLgogICAgICh0cmVlc2l0LXBh cnNlci1jcmVhdGUgJ2phdmFzY3JpcHQpCkBAIC0zODY0LDYgKzM4NjUsMjYgQEAganMtdHMt bW9kZQogICAgIChhZGQtdG8tbGlzdCAnYXV0by1tb2RlLWFsaXN0CiAgICAgICAgICAgICAg ICAgICcoIlxcKFxcLmpzW214XVxcfFxcLmhhclxcKVxcJyIgLiBqcy10cy1tb2RlKSkpKQog CisoZGVmdmFyIGpzLXRzLS1zLXAtcXVlcnkKKyAgKHdoZW4gKHRyZWVzaXQtYXZhaWxhYmxl LXApCisgICAgKHRyZWVzaXQtcXVlcnktY29tcGlsZSAnamF2YXNjcmlwdAorICAgICAgICAg ICAgICAgICAgICAgICAgICAgJygoKHJlZ2V4IHBhdHRlcm46IChyZWdleF9wYXR0ZXJuKSBA cmVnZXhwKSkKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKCh2YXJpYWJsZV9kZWNs YXJhdG9yIHZhbHVlOiAoanN4X2VsZW1lbnQpIEBqc3gpKQorICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAoKGFzc2lnbm1lbnRfZXhwcmVzc2lvbiByaWdodDogKGpzeF9lbGVtZW50 KSBAanN4KSkpKSkpCisKKyhkZWZ1biBqcy10cy0tc3ludGF4LXByb3BlcnRpemUgKGJlZyBl bmQpCisgIChsZXQgKChjYXB0dXJlcyAodHJlZXNpdC1xdWVyeS1jYXB0dXJlICdqYXZhc2Ny aXB0IGpzLXRzLS1zLXAtcXVlcnkgYmVnIGVuZCkpKQorICAgIChwY2FzZS1kb2xpc3QgKGAo LG5hbWUgLiAsbm9kZSkgY2FwdHVyZXMpCisgICAgICAobGV0ICgoc3ludGF4IChwY2FzZS1l eGhhdXN0aXZlIG5hbWUKKyAgICAgICAgICAgICAgICAgICAgICAoJ3JlZ2V4cAorICAgICAg ICAgICAgICAgICAgICAgICAoc3RyaW5nLXRvLXN5bnRheCAiXCIvIikpCisgICAgICAgICAg ICAgICAgICAgICAgKCdqc3gKKyAgICAgICAgICAgICAgICAgICAgICAgKHN0cmluZy10by1z eW50YXggInwiKSkpKSkKKyAgICAgICAgKHB1dC10ZXh0LXByb3BlcnR5ICh0cmVlc2l0LW5v ZGUtc3RhcnQgbm9kZSkgKDErICh0cmVlc2l0LW5vZGUtc3RhcnQgbm9kZSkpCisgICAgICAg ICAgICAgICAgICAgICAgICAgICAnc3ludGF4LXRhYmxlIHN5bnRheCkKKyAgICAgICAgKHB1 dC10ZXh0LXByb3BlcnR5ICgxLSAodHJlZXNpdC1ub2RlLWVuZCBub2RlKSkgKHRyZWVzaXQt bm9kZS1lbmQgbm9kZSkKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICdzeW50YXgtdGFi bGUgc3ludGF4KSkpKSkKKwogOzs7IyMjYXV0b2xvYWQKIChkZWZpbmUtZGVyaXZlZC1tb2Rl IGpzLWpzb24tbW9kZSBqcy1tb2RlICJKU09OIgogICAoc2V0cS1sb2NhbCBqcy1lbmFibGVk LWZyYW1ld29ya3MgbmlsKQo= --------------y7wmXBhAaJpiuERO0BijYQkc--