From: Dmitry Gutov <dmitry@gutov.dev>
To: Eshel Yaron <me@eshelyaron.com>, 67650@debbugs.gnu.org
Subject: bug#67650: [PATCH] ; Hide completion preview when switching windows
Date: Wed, 6 Dec 2023 22:02:25 +0200 [thread overview]
Message-ID: <3f7a2df8-f673-9098-030e-ed00542d3bdb@gutov.dev> (raw)
In-Reply-To: <m1sf4gwg3w.fsf@dazzs-mbp.home>
On 05/12/2023 22:26, Eshel Yaron via Bug reports for GNU Emacs, the
Swiss army knife of text editors wrote:
> This patch ensures that we dismiss the completion preview when users
> switch to another window. Previously, the completion preview would
> remain in a window after switching to another window showing another
> buffer, since the `post-command-hook` that Completion Preview mode sets
> up locally doesn't run after a command switches to another buffer.
Another way to do this would look like this:
diff --git a/lisp/completion-preview.el b/lisp/completion-preview.el
index 1d5f1253702..f2560a98b23 100644
--- a/lisp/completion-preview.el
+++ b/lisp/completion-preview.el
@@ -182,6 +182,7 @@ completion-preview--make-overlay
(eq (get-text-property 0 'face previous)
(get-text-property 0 'face string)))
(add-text-properties 0 1 '(cursor 1) string)
+ (overlay-put completion-preview--overlay 'window (selected-window))
(overlay-put completion-preview--overlay 'after-string string))
completion-preview--overlay))
Although it depends on whether the overlay itself staying around is a
good thing for this feature.
You could also move some cleanup logic to pre-command-hook, which should
be fine with the buffer-locality of the value.
next prev parent reply other threads:[~2023-12-06 20:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-05 20:26 bug#67650: [PATCH] ; Hide completion preview when switching windows Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-06 12:04 ` Eli Zaretskii
2023-12-06 13:33 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-06 16:43 ` Eli Zaretskii
2023-12-06 18:29 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-06 19:02 ` Eli Zaretskii
2023-12-06 21:16 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-09 9:08 ` Eli Zaretskii
2023-12-06 20:02 ` Dmitry Gutov [this message]
2023-12-06 20:54 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3f7a2df8-f673-9098-030e-ed00542d3bdb@gutov.dev \
--to=dmitry@gutov.dev \
--cc=67650@debbugs.gnu.org \
--cc=me@eshelyaron.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.