From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#62693: 28.2; VC: CVS: Fix lost file reporting and enable reverting it Date: Wed, 19 Apr 2023 03:54:15 +0300 Message-ID: <3f5b3502-95a1-26f2-3889-cb99eab05af7@gutov.dev> References: <2029306.bkXEbi1Pq8@ravel> <83y1mtcx4g.fsf@gnu.org> <2020915.n1Ql7ez4OO@ravel> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36086"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Cc: 62693-done@debbugs.gnu.org To: Olivier Certner , Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Apr 19 02:55:34 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pow6f-0009Bd-M6 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 19 Apr 2023 02:55:34 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pow6D-0003fV-V6; Tue, 18 Apr 2023 20:55:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pow6B-0003fF-8Q for bug-gnu-emacs@gnu.org; Tue, 18 Apr 2023 20:55:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pow6A-0004X3-W2 for bug-gnu-emacs@gnu.org; Tue, 18 Apr 2023 20:55:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pow6A-00066V-CP for bug-gnu-emacs@gnu.org; Tue, 18 Apr 2023 20:55:02 -0400 Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Wed, 19 Apr 2023 00:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 62693 X-GNU-PR-Package: emacs Mail-Followup-To: 62693@debbugs.gnu.org, dmitry@gutov.dev, ocert.dev@free.fr Original-Received: via spool by 62693-done@debbugs.gnu.org id=D62693.168186567023247 (code D ref 62693); Wed, 19 Apr 2023 00:55:02 +0000 Original-Received: (at 62693-done) by debbugs.gnu.org; 19 Apr 2023 00:54:30 +0000 Original-Received: from localhost ([127.0.0.1]:60718 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pow5d-00062r-QX for submit@debbugs.gnu.org; Tue, 18 Apr 2023 20:54:30 -0400 Original-Received: from wnew2-smtp.messagingengine.com ([64.147.123.27]:57619) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pow5Z-00061n-E1 for 62693-done@debbugs.gnu.org; Tue, 18 Apr 2023 20:54:27 -0400 Original-Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailnew.west.internal (Postfix) with ESMTP id 7F4E62B0679E; Tue, 18 Apr 2023 20:54:19 -0400 (EDT) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Tue, 18 Apr 2023 20:54:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1681865659; x=1681869259; bh=s0YAtPvolHYYfHChhCE3LF4PkTqP5J21B0j G89r3QF0=; b=an2XzhQiTUFxBy20A9stJqvnRpY1vL2NBi7NqN7BUrLb4qS1HfY GO+CmseseFxWpTAjFWskFxbsswpPYcstXi3ke4+64/w6spu9ankpsGtkp8S33I4O rx0P/o6qRN/y0jOze48HkG7RU4okb6t/UVK/Baak5W+hEirVcqZgEEUkX0uSQfD1 Col+sDAe1tkQmlI6DfjGXjraXJjoFqi4M7o7Z3HQ8VjfBCqxHYcFkqb7bK3mFJqJ 37g+C8/XhafGyy9JGwlapeMEDB7zOZFOg1NykXCi3G4TP7/F8/R/07bidQwOUqae /Rky0Ue0Ouw3xj1YOXg65Vix8HeCEewwsJg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1681865659; x=1681869259; bh=s0YAtPvolHYYfHChhCE3LF4PkTqP5J21B0j G89r3QF0=; b=DHfGreWA9eZriyfpyP6VqjMJ8hjK+FN2MlNPgdcYcr+yMxb4aO8 XbyV91PmmTh4Tr7g5MMadl6EqO5O7ybTsqkTw8rKPkf0QhPO8RPZSnzFrbYyPPlJ Z4N8N4hFZepI13t2zfMDoO9F3Z9+a6w08TvI4QEubBe1yMwKmo+HgaGhdIlCEaXj 0oFzWWmT28BTsj0ehdVv2IQjBBeabiuQAttMC90Ep7pyImSJV9rWeiRPzRFwQnk4 8TCAfrJgaWLENYOcJ+gjnhtTVfd1UlhIHBGa6893V9wk8H7e7nLXwkrTPXFapYqK oW+3vePiNZkn1LW9jMYM8/nSA6T3iITmXXw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdelledggeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtfeejnecuhfhrohhmpeffmhhi thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth htvghrnhepiefgteevheevveffheeltdeukeeiieekueefgedugfefgefhudelgfefveel vdevnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepug hmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 18 Apr 2023 20:54:17 -0400 (EDT) Content-Language: en-US In-Reply-To: <2020915.n1Ql7ez4OO@ravel> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:260250 Archived-At: Version: 30.1 On 17/04/2023 12:24, Olivier Certner wrote: >>> Regarding the new patch, it's great to see the list of examples, but >>> could you instead move it to a test or several inside >>> test/lisp/vc/vc-cvs-tests.el? This file does not exist yet, but you can >>> use vc-git-test.el as an example, in the same directory. >> Yes, having a test for this would be most welcome. > The examples in the commit messages have been removed and replaced by a test > file. > > New patch attached. The only new functional change is to test for an empty > hostname in `vc-cvs-repository-hostname', in an attempt to make it easier for > you to see that nothing can be broken as long as `vc-cvs-parse-root' works > correctly. Compared to the old code, the new implementation can, on an > *invalid* CVS/Root specifications, return an empty hostname where the older > would return nil (assuming a correct parsing case). This has no real practical > consequences since 'cvs' commands are anyway bound to fail at a later point in > such a case, but may reassure you about the innocuity of this change. Very good, I've pushed the three patches to 'master'. Thank you for your work, and closing.