Re: master 583995c: GnuTLS HMAC and symmetric cipher support

[Paul Eggert <eggert@cs.ucla.edu>]

Glenn Morris wrote:

> Seems a bit like a happy accident?):

It's not an accident, as every valid cipher etc. has a name.

> 1. Fgnutls_ciphers. Can intern NULL and crash.
> const gnutls_cipher_algorithm_t *gciphers = gnutls_cipher_list ();
> for (ptrdiff_t pos = 0; gciphers[pos] != GNUTLS_CIPHER_NULL; pos++)
> {
>    gnutls_cipher_algorithm_t gca = gciphers[pos];
>    Lisp_Object cipher_symbol = intern (gnutls_cipher_get_name (gca));
>    ...
> }

It's OK, as every cipher other than GNUTLS_CIPHER_NULL has a non-NULL name.

> 2. Fgnutls_macs.
> const gnutls_mac_algorithm_t *macs = gnutls_mac_list ();
> for (ptrdiff_t pos = 0; macs[pos] != 0; pos++)
> {
>    const gnutls_mac_algorithm_t gma = macs[pos];
>    Lisp_Object gma_symbol = intern (gnutls_mac_get_name (gma));
>    ...
> }

Also OK, as every mac algorithm has a non-NULL name.

> 3. Fgnutls_digests.
> const gnutls_digest_algorithm_t *digests = gnutls_digest_list ();
> for (ptrdiff_t pos = 0; digests[pos] != 0; pos++)
> {
>    const gnutls_digest_algorithm_t gda = digests[pos];
>    Lisp_Object gda_symbol = intern (gnutls_digest_get_name (gda));
>    ...
> }

Likewise.