From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#71554: 29.3; eshell-command async buffer behavior Date: Sun, 23 Jun 2024 22:36:47 -0700 Message-ID: <3ed3832f-e874-ab89-52c3-c0c32650cb33@gmail.com> References: <87frtfpqyn.fsf@librehacker.com> <87ikyb8igc.fsf@posteo.net> <86tthvwdxp.fsf@gnu.org> <87ed8z8duo.fsf@posteo.net> <87a5jm94b6.fsf@posteo.net> <874j9ogjfo.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16992"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 71554@debbugs.gnu.org, Eli Zaretskii , christopher@librehacker.com To: Thierry Volpiatto Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jun 24 07:38:24 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sLcPH-0004Ez-Q9 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 24 Jun 2024 07:38:23 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sLcOz-0006xF-N2; Mon, 24 Jun 2024 01:38:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sLcOw-0006tZ-KX for bug-gnu-emacs@gnu.org; Mon, 24 Jun 2024 01:38:04 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sLcOw-0005ax-7W for bug-gnu-emacs@gnu.org; Mon, 24 Jun 2024 01:38:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sLcOw-0006A7-Df for bug-gnu-emacs@gnu.org; Mon, 24 Jun 2024 01:38:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 24 Jun 2024 05:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71554 X-GNU-PR-Package: emacs Original-Received: via spool by 71554-submit@debbugs.gnu.org id=B71554.171920747723674 (code B ref 71554); Mon, 24 Jun 2024 05:38:02 +0000 Original-Received: (at 71554) by debbugs.gnu.org; 24 Jun 2024 05:37:57 +0000 Original-Received: from localhost ([127.0.0.1]:40392 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sLcOq-00069k-Pu for submit@debbugs.gnu.org; Mon, 24 Jun 2024 01:37:57 -0400 Original-Received: from mail-pj1-f44.google.com ([209.85.216.44]:44118) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sLcOp-00069T-0u for 71554@debbugs.gnu.org; Mon, 24 Jun 2024 01:37:55 -0400 Original-Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-2c7a6da20f2so3078391a91.0 for <71554@debbugs.gnu.org>; Sun, 23 Jun 2024 22:37:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719207408; x=1719812208; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=t6FL6a4pdDDXpbF2P57poGqWw0rt/z0n7Rn0cht+V7U=; b=EMe7kgboz2BTX0VBE82dJ+wKUrmxm1Z9mL4h4sKUJBDepR6sUTC6yvkYl5DQfgBzcc Yj1sni/xu1xHViCdkU0oV4VIVf3phsP2jqwKUUCbSnDPSPSKWOAyxu/voHQ6XhDA1VLY ZaPQT2lqHhuE/66nPrIlK5accrCQ7BuZGCYO7he15o6bNIIk3m1bjFV7xFSPiC8ebX5h eBxGEXpfRgallJDP1d/wNcNk6dD6Vr9wC9nRvbA3s7+OdkuLVQZOl2s+8uq8hMV3gNSy NTxuHASsYv1sgrHpGyRciW2rVHhvbBud4KL6zNjEOLH7oSXoP8EqgoOPTeSvJA9By2UP gW1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719207408; x=1719812208; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=t6FL6a4pdDDXpbF2P57poGqWw0rt/z0n7Rn0cht+V7U=; b=KTAg6jhLdf/OIKqZjtWUW/HdtiXOvsMFmtHzsmsurEM7l8Dm33aPZx9Vi/VvOupZ4T pdLTWFM4vgOmXciZv7DzQx5m7QolAnJnnkALTwn/GSfcoDiopz6t3raXKfOOtlBT+I7K WUxHjcXk5MRc/VhiTNbiecu6CeRjCK3yZ630ykgXTcjAJwTnZtL9HTEW6Vd/7ViRicf9 3V6nPPGc0RgNRLXynrTsiCriqZAall7T3Q6wGlrPqorvnW2+C2FpH56n7C2U9ZwoVH0f qQLMWS/UVGmbhSqaKa2+H5TcllZx2PSNqkTlI3Kc7pvevh+GeD48IFIh0VS5RMv2/0X1 unpA== X-Forwarded-Encrypted: i=1; AJvYcCUoNpyu7XxVEzphNSyaD13z+mrzsz3jD3Ge/l7FHXWNxDi6KVAOokzX+vir4CQlLnSrQXzq6GRGKl0k5DztPJx3UXlaIu8= X-Gm-Message-State: AOJu0YzvruH1kaJNGx3uhD45UOthW8U4vUBowu/XCYfJfP4eooy8b6x9 yiyvt7VU9PMTBI1wXDpUXs9afUYFct6POrcSydHKMngJX1fUP+Cn X-Google-Smtp-Source: AGHT+IGJIInEZG9K0tYyzJHiAZ92eaeCEQG3YqvfxmQJbDYEPGtJpU2s1EFVnP7NNdYy13LchDa4Tg== X-Received: by 2002:a17:90b:1958:b0:2bf:8824:c043 with SMTP id 98e67ed59e1d1-2c8504f68eamr2908251a91.18.1719207408125; Sun, 23 Jun 2024 22:36:48 -0700 (PDT) Original-Received: from [192.168.1.2] (syn-023-240-098-037.res.spectrum.com. [23.240.98.37]) by smtp.googlemail.com with ESMTPSA id 98e67ed59e1d1-2c819a7a979sm5819015a91.14.2024.06.23.22.36.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 23 Jun 2024 22:36:47 -0700 (PDT) Content-Language: en-US In-Reply-To: <874j9ogjfo.fsf@posteo.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:287820 Archived-At: On 6/20/2024 12:30 AM, Thierry Volpiatto wrote: > This patch doesn't work if user kill for some reason the initial process > buffer, we have to check if other buffers are alive. Also having a new > variable eshell-command-async-buffer instead of reusing > async-shell-command-buffer is better IMO. > Here a patch that fix these issues. I haven't tried it yet, but this patch makes sense to me, with the tiny exception that I think defaulting to 'confirm-new-buffer' would be better for consistency. (It's not my preferred setting, but I think we should stay the same as Comint unless we have a good reason for why that value has some problems unique to Eshell.) Eli, what do you think about merging this into the Emacs 30 branch? I have no strong preference myself, but I think it's small enough that it should be safe, and it fixes an annoyance with Eshell today. (I can also write a regression test or two if that would help matters.)