From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#59935: 29.0.60; project-list-buffers is slow Date: Sun, 11 Dec 2022 20:35:24 +0200 Message-ID: <3eb92bd5-7552-0529-19a7-b9db315b382a@yandex.ru> References: <86a63vi2lu.fsf@mail.linkov.net> <4a78ffcc-15fb-27ac-48b9-82fe84c596aa@yandex.ru> <86bko9na29.fsf@mail.linkov.net> <83bko9u8yy.fsf@gnu.org> <0c3df029-1e0b-7965-59c2-062018a0af7a@yandex.ru> <838rjdu7np.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11359"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Cc: 59935@debbugs.gnu.org, juri@linkov.net To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 11 19:36:41 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p4RBp-0002p0-I2 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 11 Dec 2022 19:36:41 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p4RBX-0004g4-Si; Sun, 11 Dec 2022 13:36:23 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4RBE-0004ch-Ia for bug-gnu-emacs@gnu.org; Sun, 11 Dec 2022 13:36:08 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p4RBC-0007mz-2O for bug-gnu-emacs@gnu.org; Sun, 11 Dec 2022 13:36:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p4RBB-0001dC-Tp for bug-gnu-emacs@gnu.org; Sun, 11 Dec 2022 13:36:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 11 Dec 2022 18:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59935 X-GNU-PR-Package: emacs Original-Received: via spool by 59935-submit@debbugs.gnu.org id=B59935.16707837346246 (code B ref 59935); Sun, 11 Dec 2022 18:36:01 +0000 Original-Received: (at 59935) by debbugs.gnu.org; 11 Dec 2022 18:35:34 +0000 Original-Received: from localhost ([127.0.0.1]:47577 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4RAj-0001cg-Us for submit@debbugs.gnu.org; Sun, 11 Dec 2022 13:35:34 -0500 Original-Received: from mail-wm1-f42.google.com ([209.85.128.42]:44739) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4RAi-0001cX-Iy for 59935@debbugs.gnu.org; Sun, 11 Dec 2022 13:35:32 -0500 Original-Received: by mail-wm1-f42.google.com with SMTP id b24-20020a05600c4a9800b003d21efdd61dso1845157wmp.3 for <59935@debbugs.gnu.org>; Sun, 11 Dec 2022 10:35:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=PykR7canuO7Y9PU8YL4bmp9m8HTcSsx5fLqoJHbNoYk=; b=gqwHcgtE6JQ7pJUW1m6bJQ10z83SERccs3zGQ+oStos7RPEnMDtnFzm5J958mVdGHU DRs83l6nZXpzcNhYY2NKNDMJhbi3m25hFR6TfBRdaeum5jNL2G/wbCJI6EabpwN6wI95 7UKcV+fqT7pcAJHwXxYnFeKXTelEZ5A8vzaBA57ZzChfHfjp+zvjMKELp7iLTPHLZG3B vLVT4tvbbOc4eTw+VIZXwd+PdyOYU07ng0NIHoke4whhmbbUFI3PLJsws0oukRF54aEo jNJnEXpr8Gsyco6f4uk1xz5swZZpSLFOKfro+IJguB3V4tOHlYTygKVhELIDA+V6rp2S Ybaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=PykR7canuO7Y9PU8YL4bmp9m8HTcSsx5fLqoJHbNoYk=; b=5p2rQnWxCV5Yt5mm3eymnY6Z3UZVBjZSmgmMcniAmHxMoVDH8+hS5ZskEjvBZ8jwkK IZ9jLgWLdQRbXFjvh2BpGisZAZZP0exOr5w76SbmATT4TzoOQuMpg5/IzqthgY7lZjWf lfVY2uurVaPxBV9+z9ko1bxz0T4ev2Qa0abJ9d4bElQtCp7Waic4Sz4r6t5hzWjx4N7L 8GCBiSlmv76KVBLuNinMNeC9Q81+Of0or+UkL1M8rarY2mJghvTq8jNRDCMFhMcRySU5 LZN6IiDz0vg8mEz8Ws/MTWG0XD/w94gCtId0RUn7s6itDuVmlBB8zIulGYphcq4124sn 4rRA== X-Gm-Message-State: ANoB5plng/eK8WAcVSp/vCVTnMK5DdElR2T7c/NUSbHMGPLrhviojxip /fqpGGJ7/RV5R1Olq110u2E= X-Google-Smtp-Source: AA0mqf7UaMpRmPqojKN7n3r7RZpLwtCnAtvVoKbN3VHr1XmdciMymJrtNoJGsIw0PSlO0SwdnUVB7Q== X-Received: by 2002:a7b:c30e:0:b0:3cf:ab98:2245 with SMTP id k14-20020a7bc30e000000b003cfab982245mr10503688wmj.28.1670783726667; Sun, 11 Dec 2022 10:35:26 -0800 (PST) Original-Received: from [192.168.0.2] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id t17-20020a05600c199100b003c6f1732f65sm6819761wmq.38.2022.12.11.10.35.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 11 Dec 2022 10:35:26 -0800 (PST) Content-Language: en-US In-Reply-To: <838rjdu7np.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:250646 Archived-At: On 11/12/2022 20:17, Eli Zaretskii wrote: > Why not leave alone that additional PREDICATE > argument of list-buffers-noselect, and add a feature where the > BUFFER-LIST argument could be a function? That's be a compatible > change. Just keep the PREDICATE argument and the code which supports > it, and document that if PREDICATE is a function, BUFFER-LIST cannot > be a function. While that should work, that change would *also* change the signature. Though in a safer way, yes. Are you worried about some out-of-tree clients that started using the new feature in the meantime? Otherwise, this change could be split into two steps: - Rollback that signature to pre-commit 125b5684c (i.e. revert its part in buff-menu.el). This is something we usually considered to be safe. - Add new change that allows BUFFER-LIST to be a function.