From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: chmod update-game-score now causes fatal error Date: Fri, 24 Mar 2017 10:12:02 -0500 Message-ID: <3eb3268f-933d-3a8a-f03f-1f2f06601218@cs.ucla.edu> References: <86o9wqrdq1.fsf@phe.ftfl.ca> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------56FA0A739A9F94113A83C74E" X-Trace: blaine.gmane.org 1490368382 15916 195.159.176.226 (24 Mar 2017 15:13:02 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 24 Mar 2017 15:13:02 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 To: Joseph Mingrone , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Mar 24 16:12:56 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1crQtX-00032g-BF for ged-emacs-devel@m.gmane.org; Fri, 24 Mar 2017 16:12:51 +0100 Original-Received: from localhost ([::1]:33563 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1crQtd-00073w-Bw for ged-emacs-devel@m.gmane.org; Fri, 24 Mar 2017 11:12:57 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45689) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1crQsy-0006xm-W2 for emacs-devel@gnu.org; Fri, 24 Mar 2017 11:12:21 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1crQsu-0001vl-6e for emacs-devel@gnu.org; Fri, 24 Mar 2017 11:12:16 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:45262) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1crQst-0001vB-T9 for emacs-devel@gnu.org; Fri, 24 Mar 2017 11:12:12 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 90049160060; Fri, 24 Mar 2017 08:12:08 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id CvAmopSyBg3l; Fri, 24 Mar 2017 08:12:06 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 6C56E16008C; Fri, 24 Mar 2017 08:12:06 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id TSzx4ZYUNNZE; Fri, 24 Mar 2017 08:12:06 -0700 (PDT) Original-Received: from [192.168.1.4] (ip70-178-249-247.ks.ks.cox.net [70.178.249.247]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 1BBEB160060; Fri, 24 Mar 2017 08:12:06 -0700 (PDT) In-Reply-To: <86o9wqrdq1.fsf@phe.ftfl.ca> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 131.179.128.68 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:213299 Archived-At: This is a multi-part message in MIME format. --------------56FA0A739A9F94113A83C74E Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Thanks for reporting that. I installed the attached. --------------56FA0A739A9F94113A83C74E Content-Type: text/plain; charset=UTF-8; name="0001-Don-t-require-chown-chgrp-for-game-installation.txt" Content-Disposition: attachment; filename*0="0001-Don-t-require-chown-chgrp-for-game-installation.txt" Content-Transfer-Encoding: quoted-printable >From cbc518a5ece507c4d5214a06a9c1644852da8e74 Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Fri, 24 Mar 2017 10:09:25 -0500 Subject: [PATCH] =3D?UTF-8?q?Don=3DE2=3D80=3D99t=3D20require=3D20chown/ch= grp=3D20for=3D20g?=3D =3D?UTF-8?q?ame=3D20installation?=3D MIME-Version: 1.0 Content-Type: text/plain; charset=3DUTF-8 Content-Transfer-Encoding: 8bit Problem reported by Joseph Mingrone in: http://lists.gnu.org/archive/html/emacs-devel/2017-03/msg00622.html * lib-src/Makefile.in (exp_archlibdir): Don=E2=80=99t fail if chown or chgrp fails with update-game-score and the game directory. Instead, expect the installer to fix this up afterwards. --- lib-src/Makefile.in | 24 +++++++++++++++--------- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git a/lib-src/Makefile.in b/lib-src/Makefile.in index b2cd66c..086d0dc 100644 --- a/lib-src/Makefile.in +++ b/lib-src/Makefile.in @@ -266,7 +266,9 @@ need-blessmail: maybe-blessmail: $(BLESSMAIL_TARGET) =20 ## Install the internal utilities. Until they are installed, we can -## just run them directly from lib-src. +## just run them directly from lib-src. When installing, do not give +## up if chown or chgrp fails, as the package responsible for +## installing Emacs can fix this problem later. $(DESTDIR)${archlibdir}: all @echo @echo "Installing utilities run internally by Emacs." @@ -283,15 +285,19 @@ $(DESTDIR)${archlibdir}: touch "$(DESTDIR)${gamedir}/snake-scores" \ "$(DESTDIR)${gamedir}/tetris-scores" ifneq (,$(gameuser)) - chown ${gameuser} "$(DESTDIR)${archlibdir}/update-game-score${EXEEXT}" - chmod u+s,go-r "$(DESTDIR)${archlibdir}/update-game-score${EXEEXT}" - chown ${gameuser} "$(DESTDIR)${gamedir}" - chmod u=3Drwx,g=3Drx,o=3Drx "$(DESTDIR)${gamedir}" + -chown ${gameuser} \ + "$(DESTDIR)${archlibdir}/update-game-score${EXEEXT}" \ + "$(DESTDIR)${gamedir}" && \ + chmod u+s,go-r \ + "$(DESTDIR)${archlibdir}/update-game-score${EXEEXT}" && \ + chmod u=3Drwx,g=3Drx,o=3Drx "$(DESTDIR)${gamedir}" else - chgrp ${gamegroup} "$(DESTDIR)${archlibdir}/update-game-score${EXEEXT}" - chmod g+s,o-r "$(DESTDIR)${archlibdir}/update-game-score${EXEEXT}" - chgrp ${gamegroup} "$(DESTDIR)${gamedir}" - chmod u=3Drwx,g=3Drwx,o=3Drx "$(DESTDIR)${gamedir}" + -chgrp ${gamegroup} \ + "$(DESTDIR)${archlibdir}/update-game-score${EXEEXT}" && \ + "$(DESTDIR)${gamedir}" && \ + chmod g+s,o-r \ + "$(DESTDIR)${archlibdir}/update-game-score${EXEEXT}" && \ + chmod u=3Drwx,g=3Drwx,o=3Drx "$(DESTDIR)${gamedir}" endif endif exp_archlibdir=3D`cd "$(DESTDIR)${archlibdir}" && /bin/pwd` && \ --=20 2.9.3 --------------56FA0A739A9F94113A83C74E--