From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: =?UTF-8?Q?Cl=c3=a9ment_Pit--Claudel?= Newsgroups: gmane.emacs.devel Subject: Re: systemd @ in filenames not supported by thing-at-point Date: Sat, 30 Jul 2016 21:00:52 -0400 Message-ID: <3e9c56ad-29a7-512f-845d-1863c497c14e@gmail.com> References: <867fc3zz5d.fsf@student.uu.se> <86shury87u.fsf@student.uu.se> <86k2g3y4ib.fsf@student.uu.se> <8637mrrvi2.fsf@student.uu.se> <427733f7-6ad9-f476-6831-1899e4fb3257@gmail.com> <86k2g2r6y3.fsf@student.uu.se> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="BBj3dgI5C41TA2xMSUsOtUEs7nDjPT3b2" X-Trace: blaine.gmane.org 1469926920 4143 80.91.229.8 (31 Jul 2016 01:02:00 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 31 Jul 2016 01:02:00 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jul 31 03:01:46 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bTf8U-00012U-8F for ged-emacs-devel@m.gmane.org; Sun, 31 Jul 2016 03:01:46 +0200 Original-Received: from localhost ([::1]:38004 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bTf8O-0006V5-FE for ged-emacs-devel@m.gmane.org; Sat, 30 Jul 2016 21:01:40 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40864) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bTf7o-0006Uh-RL for emacs-devel@gnu.org; Sat, 30 Jul 2016 21:01:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bTf7k-0006C7-Iw for emacs-devel@gnu.org; Sat, 30 Jul 2016 21:01:03 -0400 Original-Received: from mout.kundenserver.de ([212.227.126.130]:57644) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bTf7k-0006C3-8K for emacs-devel@gnu.org; Sat, 30 Jul 2016 21:01:00 -0400 Original-Received: from [18.189.62.146] ([18.189.62.146]) by mrelayeu.kundenserver.de (mreue004) with ESMTPSA (Nemesis) id 0MaoHu-1bjXHM2jyU-00KOAi for ; Sun, 31 Jul 2016 03:00:58 +0200 In-Reply-To: <86k2g2r6y3.fsf@student.uu.se> X-Provags-ID: V03:K0:rD4TN7JJpA25T65o3y1j1bHcD0XNDF/2CYTlbNPFa0WUkQQD9fP VAug3WRakVTFRZgTuCuKnuEmGptUD1IMs8ImW8GNE69uiBVqfUe9un+772Enotu6T5YnMM2 edPhE7XjbNPIututBpd6CnglmkVhzNiSYGk3lw/6Gq/2Xv467JvYLT050C/Ku5+vslYeCsu pCJhy+vG4OubxjjaKgVBQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:Ai/RY2gt4yg=:YCgtGWkTZNFb3YazNWmtE8 ZchHELNx9F6GwwZIPu6HFEsyMFs6Gx+huOZPqHoQN33UN0pCRFDYzwGPj8wPDVi1ElfIQp0bD SSJLciEkZCv+pWqyrMKqtOXB8t0nAJMv8qVRceHwNgFFUZ2XSXXa4KnTG9RSE6QGJvGZ904rj ULFDuAAgC/C70PpIOd2GhEhVU3u2SnDcKrRGP0NMwInuCutpcC45qSTFW5VL5nhPeZy5fR3By 8Y4hvke0ZJ/yvXqf77Cgx/S0G1qbfEibF9VUiQ2xluQyE3ckzt/V2wew6YbVSQf2yNydnRzne f+QDuvZGKBJWxxa0I7GcTjrYmy/RdBuBrkJsfOXrTLtHevsHyeOZEU+Vss8hX4l+t6iUbu6tT Q+CmwE1iTCECt04/jmuCxZRdOkpCEa1Xcirsw0JMfhbQXpasHZeQGmwBXpJTh1X0fX0PP7CS2 IncWqQ08xrMGCBFarMvKhGoNyUW3EeCEOh1JHw4d6L0MnFCEQmzeKZZNnbBX5HnjuxGViVj4R JApndJnlcQmHiaDl1pTrVDGY9bCOj886NlmaMDxlIXXRRAGHnrJG0YnDUTBRSzSEJ0S8iQ2c+ 7RMHFc0rDxS2kJ5lKm7y0C/0PrdzGusMLoZyUkG/84cm1KvXHTTCjKQBTV1zCtd/U3NkkM8pn Tl/zb9MQna9UhJI85xg1seByyhYefLVy4m3JhiyLCaC8MSlNPPUTFBxZ7+kGPZY1rbuA= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 212.227.126.130 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:206258 Archived-At: This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --BBj3dgI5C41TA2xMSUsOtUEs7nDjPT3b2 Content-Type: multipart/mixed; boundary="nCNnthiaxjPbS7usb3tpGUc9RlJwR2u3m" From: =?UTF-8?Q?Cl=c3=a9ment_Pit--Claudel?= To: emacs-devel@gnu.org Message-ID: <3e9c56ad-29a7-512f-845d-1863c497c14e@gmail.com> Subject: Re: systemd @ in filenames not supported by thing-at-point References: <867fc3zz5d.fsf@student.uu.se> <86shury87u.fsf@student.uu.se> <86k2g3y4ib.fsf@student.uu.se> <8637mrrvi2.fsf@student.uu.se> <427733f7-6ad9-f476-6831-1899e4fb3257@gmail.com> <86k2g2r6y3.fsf@student.uu.se> In-Reply-To: <86k2g2r6y3.fsf@student.uu.se> --nCNnthiaxjPbS7usb3tpGUc9RlJwR2u3m Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2016-07-30 20:23, Emanuel Berg wrote: > Cl=C3=A9ment Pit--Claudel wrote: >=20 >> I have no idea what this is about, or what it >> has to do with Emacs. In any case, the >> original issue sounds like a bug to me, and >> you seem to have a reasonable-looking fix for >> it. Can you prepare a patch and send it with >> M-x report-emacs-bug? That would be very >> useful; we could probably discuss that >> fix there. >=20 > By "preparing a patch", do you mean there is > some formal way of doing that? If so, I am not > familiar with that. (I know of > `report-emacs-bug', of course.) :) It's very easy. You checkout the Emacs source tree with git, then make= your change, commit it with a message in Changelog format), test it, and= finally use `git-format-patch HEAD~1` to save it as a .patch file. Then = you can post it as an attachment to a report-emacs-bug email summarizing = the issue and the proposed fix. As a small bonus, this process ensures that you're credited for finding a= nd fixing the issue in the Emacs history, which is nice :); also, it make= s it easy for people to test the proposed fix (although, arguably, it's a= lready easy in this case). In general, you need to sign a contributor agreement to send patches to E= macs; this particular fix however counts as a "trivial" fix, and thus is = exempted from this. But if you haven't yet done so, signing the CLA is ve= ry easy, and will make it smoother to contribute more significant patches= in the future :) > However, in my initial post I added the @ > *first* which I have since learned on > gnu.emacs.help turns the original, initial dash > into an interval (when it doesn't appear first > anymore), i.e., all of [@, ~] in math notation > are included which wasn't the intention, > for sure! That's right; nice catch. I'd suggest sending the patch to bug-gnu-emacs,= and seeing if people have other similar insight. Cheers and thanks for catching this issue and proposing a fix! Cl=C3=A9ment. --nCNnthiaxjPbS7usb3tpGUc9RlJwR2u3m-- --BBj3dgI5C41TA2xMSUsOtUEs7nDjPT3b2 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXnU3JAAoJEPqg+cTm90wjuO8QAKxQGV7vQ8ViREUtMxHp9voG RxM3nGiu+Q7r8PL1OzJH1G7lDcTnPGEfMgDHR4ciJVcJIeslXR52VjD75Hg8aFIJ kmn4/JJGJd1B0+D5OQebWVsGsqHYsmv4PFEj7lxZFBK/s/dIz1Zkl2HM7P2+2rK3 IMaOjQ76K5SXswgcIDqlFKnfe/c0eb96sgOTAWjUECq+SSjRdDEGQZxg1GV+1Tc9 de9+RkmkHoM9CX4ARjFY2sOyU1hzVccFcAaIw6jm4ccQyCDSmyBA2Do34ktC080T OhilebM5wPgsW3MznBlUTMfd3SbSFXl4zCmqCtatntpe20ZGnZr5ssh10/6v7hZw KD7oFhDExSvKMAtSo9kgJ1c+3mikHTZ1jZC8mYfmh5uqVFDfSDp4zPMpGgZeh6ER +TDpHTsMc96QpveCDVInZZJzrKSV1oJNmxTVJKTAfTNit+ONvnZwuLEGnm9TW1gb YaoZG6iH0djloJKSXcwdK5gvGt8S5c8cXDDjnjkmcOQNXtCsvANfzgTR0JHOnhnR zaxngxZF3asghVHI41TtiCTvFkNmBY7xcwXpmuXL9vQktSU5/tQhGvSikTxWBQlf G0X5DHKSApTHv696VhMwG9W+W2Duv1m1pdfelks4DALLN8aC2XryUA6ZEk9BwOo5 SH3rqXr+jrID3Pn7pG6v =UZAl -----END PGP SIGNATURE----- --BBj3dgI5C41TA2xMSUsOtUEs7nDjPT3b2--