From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Nikolay Kudryavtsev Newsgroups: gmane.emacs.devel Subject: Re: Patches for Emacs 25.2 Date: Sat, 31 Dec 2016 07:20:28 +0300 Message-ID: <3e723e03-6fff-7500-aa91-e8de73519490@gmail.com> References: <877f96t9oc.fsf@gmx.de> <837f96xgp5.fsf@gnu.org> <87zim2rtck.fsf@gmx.de> <9181f38b-8d6c-c61e-90b0-d44a9e048c9e@gmail.com> <87wph6qd1d.fsf@gmx.de> <831szexb54.fsf@gnu.org> <83shrtx5dv.fsf@gnu.org> <752ec49c-da5b-bf86-e31d-294c362c04cb@gmail.com> <877f95deig.fsf@gmx.de> <6f656e32-a44c-f874-3290-f47b8828078e@yandex.ru> <87oa1r64vg.fsf@gmx.de> <2d749ac6-636b-14f2-e5a9-dcc0e9ba7541@yandex.ru> <8760nzfunl.fsf@gmx.de> <05d06a0a-e6df-5d54-01bf-7bb9447a2f7e@yandex.ru> <158f0095-926f-2b8e-034c-4a05a1f08175@yandex.ru> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1483158046 21298 195.159.176.226 (31 Dec 2016 04:20:46 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 31 Dec 2016 04:20:46 +0000 (UTC) User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 Cc: Michael Albinus , emacs-devel@gnu.org To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Dec 31 05:20:42 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cNB9t-0004wR-Em for ged-emacs-devel@m.gmane.org; Sat, 31 Dec 2016 05:20:41 +0100 Original-Received: from localhost ([::1]:42529 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cNB9y-00016O-Bb for ged-emacs-devel@m.gmane.org; Fri, 30 Dec 2016 23:20:46 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43654) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cNB9q-00014v-Hp for emacs-devel@gnu.org; Fri, 30 Dec 2016 23:20:39 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cNB9l-000301-9k for emacs-devel@gnu.org; Fri, 30 Dec 2016 23:20:38 -0500 Original-Received: from mail-lf0-x234.google.com ([2a00:1450:4010:c07::234]:34939) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cNB9l-0002zl-2R for emacs-devel@gnu.org; Fri, 30 Dec 2016 23:20:33 -0500 Original-Received: by mail-lf0-x234.google.com with SMTP id b14so245610708lfg.2 for ; Fri, 30 Dec 2016 20:20:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:subject:to:references:cc:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=2+uEp3YjXfNq6KEQ3JYbzm3Zg/uWYUzwWqMk9EH0GLo=; b=Yn6utQZEMOS9rcl3n1vlBQKGQfl+hCTKzsT19nCjTg7wd9+ReiG9eKJtVb3QwnbUZB Ut52/UZ9OQ80NKGAdLQtA6VwXGT3OiAHzZaBb50Ow100iGNwmgPAq+wFFhy2boABgnRJ SuTU/VBo311zrWFyZ2uLiY702DPTahpdzHq3oKDJK7ttSmUtcmS6CUk55Nd+BlJWT51/ DfSTuK0dfSOLc9eeLjYls8A+/ad1+H6orZh79aF8t9S/5DZKqoVM+1Jg5xaNYXyJDwcX /u0M90vMNEz0VcAnvqQi9Tpdl3jRomyeHqEOgss12QllEiRDMpNaDoO4IVry23tfI/Za dlPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:subject:to:references:cc:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=2+uEp3YjXfNq6KEQ3JYbzm3Zg/uWYUzwWqMk9EH0GLo=; b=o80Aje0BvHzyhaP26r0GAQJxlCKNlSaHbOUz+p5jl1uXvChOlcgc2nfH2QhQqS8kMP sU7ffbfQsmDssg2sVmSk3Bi8K41+kQG2MtWhADYhB6JoMjImSIBUELuKQ33iCaFUhs7m iLZ+S2VFwZ3US340y+3NaCMAKnq9iZv4sR8B1cSYpNwBPVYhdjpflYY5Pmvx0Bn4Ib9d AFKUiztCw+QuLJB8fgMuSt5srfPwW4ET1UTL0UiwGjbSzq9uRHmLClCz9LYrcmVNvTSs UyM6OyxAIBkAuHTP6+zvw9UNtLknDh2noTV+//sDINIuXTTz9REiAT7s+IuSoUWTJW9Z t92w== X-Gm-Message-State: AIkVDXKIm+r8OK9sFCVvApfivmhMDbCkwvTI3+K3lroNtrwt0eomhkyRJx4F9+n+VP15Wg== X-Received: by 10.46.32.135 with SMTP id g7mr17352243lji.70.1483158031201; Fri, 30 Dec 2016 20:20:31 -0800 (PST) Original-Received: from [192.168.199.6] (broadband-95-84-209-126.nationalcablenetworks.ru. [95.84.209.126]) by smtp.gmail.com with ESMTPSA id s127sm14066969lja.31.2016.12.30.20.20.29 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 30 Dec 2016 20:20:30 -0800 (PST) X-Google-Original-From: Nikolay Kudryavtsev In-Reply-To: <158f0095-926f-2b8e-034c-4a05a1f08175@yandex.ru> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:4010:c07::234 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:211016 Archived-At: Sorry, I don't follow on what you have in mind for removing that check. When we commit to git on a server we now create a file with path like "/pscp:server:/tmp/tramp.29256XNq" which we store in msg-file local variable. After we created that file we need to: a) Create a git command like "git commit -F /tmp/tramp.29256XNq". Here we need the remote part of path only. b) Write to that file. Here we need the absolute path. We also extract some args during writing. With this in mind I don't see how we can get rid of (file-remote-p msg-file 'localname) other than storing it in a local variable, which is a questionable improvement. Note: we cannot use file-local-name here, since it was only introduced on master. I guess I'm kind of late(again) with the new pretest out, but I really think this bug is pretty major and worth the effort, though YMMV. -- Best Regards, Nikolay Kudryavtsev