From: Drew Adams <drew.adams@oracle.com>
To: Noam Postavsky <npostavs@users.sourceforge.net>
Cc: 25777@debbugs.gnu.org
Subject: bug#25777: 25.1; [PATCH] `rectangle--pos-cols' should not move point
Date: Mon, 27 Feb 2017 11:21:34 -0800 (PST) [thread overview]
Message-ID: <3e265625-6c16-424c-9fb2-6a7144dcc349@default> (raw)
In-Reply-To: <CAM-tV-8f0+Xq_XX9ib_XNjx+V7j4LRZ9TAOCi1uqbLod7awtXg@mail.gmail.com>
> > Just as, for Emacs 24.5, I reused some code from rect.el to
> > do what I need to get the rectangle columns, so I reused
> > the corresponding code from Emacs 25.
> >
> > Look at function `apply-on-rectangle'. In Emacs 25 it calls
> > `rectangle--pos-cols' to get the rectangle columns - and so
> > do I. In Emacs 24.5 it also does just what I do (I stole
> > the code) to obtain those columns.
>
> In both 24.5 and 25.1, apply-on-rectangle wraps its body in
> save-excursion, and in both versions the body contains no nested
> save-excursions. So it looks to me like the regression is in your code
> which decides not to call save-excursion when running on Emacs 25.
OK, clearly I'm not getting through to you. The bug will remain, and
I'll wrap my calls to `rectangle--pos-cols' in `save-excursion'.
For the record:
1. I do not call `apply-on-rectangle'.
2. The purpose of `rectangle--pos-cols', just as was the purpose
of the previous (Emacs 24.5) code, is to return the rectangle
columns. Nothing more. Its purpose is not to move point and
leave it in some other place that is not a rectangle corner.
3. `rectangle--pos-cols' is a general function. It should not
be considered internal. It is useful generally - I have
reused it, as one example. (I have not used `apply-on-rectangle'.)
Is there a reason to have `rectangle--pos-cols' move point,
instead of use `save-excursion'? You've given none. Do you
argue that performance matters here? What's the argument in
favor of not having this code be as clean as it was in Emacs
24.5? Why favor this regression?
next prev parent reply other threads:[~2017-02-27 19:21 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-17 17:51 bug#25777: 25.1; [PATCH] `rectangle--pos-cols' should not move point Drew Adams
2017-02-19 17:38 ` Drew Adams
2017-02-27 1:37 ` npostavs
2017-02-27 6:24 ` Drew Adams
2017-02-27 13:44 ` npostavs
2017-02-27 17:51 ` Drew Adams
2017-02-27 18:50 ` Noam Postavsky
2017-02-27 19:21 ` Drew Adams [this message]
2017-02-27 19:47 ` Noam Postavsky
2017-02-27 20:35 ` Drew Adams
2017-02-28 4:57 ` npostavs
2017-02-28 15:11 ` Drew Adams
2017-03-02 1:21 ` npostavs
2017-03-02 2:32 ` Drew Adams
2017-03-02 18:13 ` Drew Adams
2017-03-03 2:09 ` npostavs
2017-03-03 6:29 ` Drew Adams
2017-03-03 13:28 ` npostavs
2017-03-03 16:44 ` Drew Adams
2017-03-03 18:16 ` Noam Postavsky
2017-03-03 19:17 ` Drew Adams
2019-06-24 17:10 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3e265625-6c16-424c-9fb2-6a7144dcc349@default \
--to=drew.adams@oracle.com \
--cc=25777@debbugs.gnu.org \
--cc=npostavs@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.