From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#59662: 29.0.50; [PATCH] Add treesit--indent-defun Date: Sat, 3 Dec 2022 17:59:04 +0200 Message-ID: <3e25eadb-3f2b-f92d-8b18-bf1daca91b64@yandex.ru> References: <5B538888-E454-4F75-B3B8-AB20E10B3E89@gmail.com> <83o7sniokt.fsf@gnu.org> <4D5A1640-4F0F-4C21-8ED6-770B88A870EA@thornhill.no> <83r0xhdluq.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23009"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Cc: casouri@gmail.com, 59662@debbugs.gnu.org, theo@thornhill.no, casouri@gmail.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Dec 03 17:02:05 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p1Uxn-0005Ym-PN for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 03 Dec 2022 17:02:03 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p1Uwl-0001eF-RH; Sat, 03 Dec 2022 11:01:00 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p1Uvr-0000Eb-NI for bug-gnu-emacs@gnu.org; Sat, 03 Dec 2022 11:00:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p1Uvr-0002iP-5b for bug-gnu-emacs@gnu.org; Sat, 03 Dec 2022 11:00:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p1Uvq-0004fI-PD for bug-gnu-emacs@gnu.org; Sat, 03 Dec 2022 11:00:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 03 Dec 2022 16:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59662 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 59662-submit@debbugs.gnu.org id=B59662.167008315617901 (code B ref 59662); Sat, 03 Dec 2022 16:00:02 +0000 Original-Received: (at 59662) by debbugs.gnu.org; 3 Dec 2022 15:59:16 +0000 Original-Received: from localhost ([127.0.0.1]:52024 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p1Uv5-0004ef-Vs for submit@debbugs.gnu.org; Sat, 03 Dec 2022 10:59:16 -0500 Original-Received: from mail-wr1-f50.google.com ([209.85.221.50]:41825) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p1Uv3-0004eZ-B9 for 59662@debbugs.gnu.org; Sat, 03 Dec 2022 10:59:13 -0500 Original-Received: by mail-wr1-f50.google.com with SMTP id q7so12337011wrr.8 for <59662@debbugs.gnu.org>; Sat, 03 Dec 2022 07:59:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=Sykb2Ll/hvYP13v0XT7S+L9Y+WVd3Mc2pxmZIT0mQQU=; b=NYc0jjk1msT1PgpTs0+37jyrnatkOzedTgPCKHLi+n3u1mmqO26XEquxjNutmSSPGz 8ijH6NYEqmHPPvJCZI6NDWNb9w/+3cWK4ZKrTURRnT+Ao7gCFQ1YhF7mP2xQ5B7fzZgf SJCD98nDMbwMzjmm9bDm388lbB51f1x4zSsaEfLMezE980ctekv94lrm/VJrsqYHIx7h 8F3YGn9DCRzr4Hk9sSFev+PI5AHO9IyNoce8YQ3GhGdlMYcrsIZHK+3v+y6s3IKO5ple HF93CeSppr3X+/PSHHCSBU2x3lp7tFUaQLIPf1T3c1T6UgliUyQAEIJPSpN/dTSTwHlE oRFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Sykb2Ll/hvYP13v0XT7S+L9Y+WVd3Mc2pxmZIT0mQQU=; b=kwvI3qxYC2+K+f9aZxBftwgb/SxcObIO58piugWRswKiYzt93Bt2aZGv+Uk7hVzGel knNOyiyOJqzEgMfocurZMMZ5lCFUbat54WeQk2JWkqsPYt4mXO7GK9puhJkGwkNIMsRo vqrd6qzBZxb2suFrOD9vZJFzuPiMQuVhpw3j7q7320FavBu2eiczEi2/HARov65D0GEp LBgVLE3I53Tc7/1ESj+LJVev/6FwvKJN+VQU1K193KheUNbvRcBkaxRDmLywzt8RPb/J uyKaI9ME4FMnILV0vS9kWBbc9bgd4PyR1TKF48FIRGsTwL1GJuw04y+dXpv2u9T2CRWX Ey9g== X-Gm-Message-State: ANoB5pms8O3px9vajNsA2uEDqMsfxLzk3GYF6TefXPLvhaJ0jBILjTTd Fw2sBRDWFrpgMJuUPxj/uAg= X-Google-Smtp-Source: AA0mqf7JKSqbQQFysyNwqwbB2jJ1B+N+fOKmzDugt1gTTtgleAryykU84UjEzsiGmwCu88A22O7k9w== X-Received: by 2002:a5d:4344:0:b0:22e:3430:475d with SMTP id u4-20020a5d4344000000b0022e3430475dmr47164636wrr.65.1670083147313; Sat, 03 Dec 2022 07:59:07 -0800 (PST) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id o37-20020a05600c512500b003cf5ec79bf9sm13745079wms.40.2022.12.03.07.59.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 03 Dec 2022 07:59:06 -0800 (PST) Content-Language: en-US In-Reply-To: <83r0xhdluq.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:249852 Archived-At: On 03/12/2022 08:47, Eli Zaretskii wrote: >> Date: Sat, 3 Dec 2022 00:27:51 +0200 >> Cc: 59662@debbugs.gnu.org, casouri@gmail.org >> From: Dmitry Gutov >> >> On 02/12/2022 22:07, Theodor Thornhill via Bug reports for GNU Emacs, >> the Swiss army knife of text editors wrote: >>> >>> On 2 December 2022 20:53:13 CET, Dmitry Gutov wrote: >>>> On 01/12/2022 09:13, Eli Zaretskii wrote: >>>>> After all, until now this functionality and the "C-c C-q" >>>>> binding was only in CC Mode. >>>> There is also the 'M-q' binding in the popular paredit-mode. >>>> >>>> It runs paredit-reindent-defun. >>> Yeah. My first iteration was piggybacking on fill-paragraph-function to get that binding, but I believe that was undesirable. >> >> IME it's quite handy to have in modes where there is separation between >> (rigid) code and strings/comments. >> >> Not sure if that's all of prog-mode descendants, or if there will be >> exceptions. > > I'm okay with making "C-c C-q" work in more modes than just C-related ones, > but please do that on master, not on the release branch. > > As for M-q, it should be bound to a fill-SOMETHING command, not to a > indent-SOMETHING command. So from my POV paredit-mode should be fixed to > use some other sequence for paredit-reindent-defun, perhaps even "C-c C-q", > but that is IMO an unrelated issue. > > And if you wanted to suggest that an indent-defun command in c-ts-mode be > bound to M-q, then I'm very much against that: M-q already has a useful > command bound to it in CC Mode, and should do something similar in > c-ts-mode; I believe we are discussing that in bug#59763. Both c-fill-paragraph and the proposed ts-c-fill-paragraph perform fill-region when inside a string or comment. Otherwise, do nothing. paredit-reindent-defun, like I described, does all that too. But when outside strings and comments, it reindents the current defun. AFAICT, these behaviors are quite compatible. But paredit's binding seems to be useful in more contexts.