From: Jim Porter <jporterbugs@gmail.com>
To: miha@kamnitnik.top, 50806@debbugs.gnu.org
Cc: Lars Ingebrigtsen <larsi@gnus.org>
Subject: bug#50806: 27.2; [PATCH] Optimize ansi-color.el
Date: Sun, 3 Oct 2021 13:16:05 -0700 [thread overview]
Message-ID: <3e19d87f-371b-31d5-cc1a-dd0b22659acf@gmail.com> (raw)
In-Reply-To: <87k0itc2ap.fsf@miha-pc>
On 10/3/2021 12:54 PM, miha--- via Bug reports for GNU Emacs, the Swiss
army knife of text editors wrote:
> Ok, thanks. I have actually already prepared patches for all these
> features: full-color in ansi-color.el and term.el and also "basic" ANSI
> escapes 1-8 for term.el that you mentioned.
>
> I guess there's no harm in sending them right now.
I took a brief look at these and they seem reasonable to my eyes. It'll
be nice to have (mostly) complete support for reading ANSI colors in Emacs.
Thinking about it a bit more, one thing that might be nice to add for
the first patch would be some additional tests to be sure that
`ansi-color-context-region' and `ansi-color-context' work as expected
(i.e. testing that multiple calls to `ansi-color-apply-on-region' and
similar produce the correct results). That's one of the trickier bits in
ansi-color.el (to me, anyway), and it'd be good to be sure all the
various cases still work there. That said, it might be best to let the
maintainers take a look before spending too much time on further tests.
>> I see you posted an updated patch that doesn't merge these vectors. I
>> don't have an opinion here, although if we do merge them, it would
>> probably be nice to get that into Emacs 28; other packages might
>> conceivably want to let-bind those[1].
>
> Indeed, if we wanted to merge them we'd have to do it in Emacs 28.
> That's why I think its best to simply leave them un-merged.
If there's a performance benefit to merging them, I think it would be
nice to do so while we have the chance. Perhaps a patch that just merges
the two vectors, and nothing else, would make sense for Emacs 28. Best
to ask the maintainers in this case too, though.
next prev parent reply other threads:[~2021-10-03 20:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-25 22:32 bug#50806: 27.2; [PATCH] Optimize ansi-color.el miha--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-03 16:31 ` miha--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-03 17:53 ` Jim Porter
2021-10-03 19:54 ` miha--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-03 20:16 ` Jim Porter [this message]
2021-10-04 10:17 ` miha--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-03 19:59 ` miha--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-04 9:27 ` Lars Ingebrigtsen
2021-10-04 10:07 ` miha--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-05 6:56 ` Lars Ingebrigtsen
2021-10-05 11:18 ` miha--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-06 8:51 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3e19d87f-371b-31d5-cc1a-dd0b22659acf@gmail.com \
--to=jporterbugs@gmail.com \
--cc=50806@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=miha@kamnitnik.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.