From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#35353: 26.2; Buffer *xref*: (1) hard-coded mouse-1, (2) major mode name Date: Fri, 3 May 2019 01:48:30 +0300 Message-ID: <3df72e2b-7b73-52b4-07f4-4fb746a51b6e@yandex.ru> References: <96cafba3-7ba2-4e87-8f9d-e53825fd1dde@default> <94feda5f-7afa-4ab5-96f8-60dfaba7e0a4@default> <469bf659-07b6-8172-287c-2abc53582447@yandex.ru> <83zhoi74vl.fsf@gnu.org> <44b1aa8a-c06c-61f7-0948-0fd20605e938@yandex.ru> <83y34273mu.fsf@gnu.org> <2979c506-20e4-4b9f-0215-6f0241238678@yandex.ru> <83v9z6732b.fsf@gnu.org> <7837cd5b-819b-66b1-c14d-d8742f3860b5@yandex.ru> <017d79f2-f98b-2e61-4abe-5ce9495008b3@orcon.net.nz> <70e7fbc3-aeb5-460f-9a59-e5dfc902d15f@default> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="199796"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 Cc: 35353@debbugs.gnu.org To: Drew Adams , Phil Sainty Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri May 03 00:49:15 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hMKVu-000ptA-DA for geb-bug-gnu-emacs@m.gmane.org; Fri, 03 May 2019 00:49:14 +0200 Original-Received: from localhost ([127.0.0.1]:59492 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMKVt-0001GA-B3 for geb-bug-gnu-emacs@m.gmane.org; Thu, 02 May 2019 18:49:13 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:49239) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMKVj-0001Fn-KW for bug-gnu-emacs@gnu.org; Thu, 02 May 2019 18:49:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hMKVi-0004qO-L4 for bug-gnu-emacs@gnu.org; Thu, 02 May 2019 18:49:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33711) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hMKVi-0004qA-An for bug-gnu-emacs@gnu.org; Thu, 02 May 2019 18:49:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hMKVi-0002VI-2X for bug-gnu-emacs@gnu.org; Thu, 02 May 2019 18:49:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 02 May 2019 22:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35353 X-GNU-PR-Package: emacs Original-Received: via spool by 35353-submit@debbugs.gnu.org id=B35353.15568373239598 (code B ref 35353); Thu, 02 May 2019 22:49:02 +0000 Original-Received: (at 35353) by debbugs.gnu.org; 2 May 2019 22:48:43 +0000 Original-Received: from localhost ([127.0.0.1]:47255 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hMKVO-0002Uk-OO for submit@debbugs.gnu.org; Thu, 02 May 2019 18:48:42 -0400 Original-Received: from mail-lj1-f195.google.com ([209.85.208.195]:44785) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hMKVL-0002UW-Ff for 35353@debbugs.gnu.org; Thu, 02 May 2019 18:48:41 -0400 Original-Received: by mail-lj1-f195.google.com with SMTP id c6so3678372lji.11 for <35353@debbugs.gnu.org>; Thu, 02 May 2019 15:48:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ZPepzmouZMvEvcOqrGHz2fWp8KZwZ5mmHIpI9bKNSR0=; b=c+N9hHnGlRAiAezd8vmZZeuRXUifv9ZtVz7lr+GcH1k0us/uHSadPsuspz10wY84bz rsRUTGMmgUfmwdPnklJ6A1E5ZTtHj/bgntzY1dUoWNEx+i24PoInbTxe/rYVYA/FI7e6 Rp3KE7/E8mHaa5fkNbM1QT2X8I84WWZrZQy7LdzbXWiVfu1eIUzAUGJgnQyUoTEfnXV1 B++SUhKptV4SBtiKbp8bMxvArvS2EmhDUvtmxrb52U8od4h2tTmF5IoqBJf96Mjl8sjk RZXUQDX56qCoLq4BF9fJipd7PpYOdOzGF3U96qoFuxzrDUWxdZlfjK/j9qovvnTnAvD1 OVpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ZPepzmouZMvEvcOqrGHz2fWp8KZwZ5mmHIpI9bKNSR0=; b=iJjNx81JTMLYF7s2kQRaojbFuOuKoJ+qqWbrtxJhfPH9sLEsloAr7pyQhooYTezlrk w9RaDOil7YjCksFfqlL0AJT3JiGuWM4cufZmpXwBKwFX4cYWiuFKkTL33hm5u2jb4OZQ l3tBxruU820lPn3p8W9YDgxfSgREn1/tGjFwnSl+AmWc5V9mydiRjQyN1zw5Cu1d3x0V Q5iNlfoqDNrYZCyNe/TCaaZkR569k2E9nzkeBm7d2Uacmo6RN0Jm8VW/EMDV0gjIjfUB 509Fa7cwvoJvb4icoSPugs2xuHd3dODEYqL7G9L0kPDPoezQb4xkqlnw/gploEYJoffl 5nZw== X-Gm-Message-State: APjAAAUSp2NbYYK2DhQjVd8fZ7vQanGgZHW7AH+ZXMoDMkc4d5Asbxss 4ym4SoTuAC/2CZIk2A5W3lnZcF+A+o0= X-Google-Smtp-Source: APXvYqzlu8QQu1XHnrfmhXzSY1zvJ2sLa/N0m8iQnYnM3SVHlSPbTCtaM3UrECzKvUbPEfINnyZnag== X-Received: by 2002:a2e:9dcb:: with SMTP id x11mr3237727ljj.123.1556837313063; Thu, 02 May 2019 15:48:33 -0700 (PDT) Original-Received: from [192.168.1.3] ([185.105.174.23]) by smtp.googlemail.com with ESMTPSA id p82sm49735ljp.37.2019.05.02.15.48.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 02 May 2019 15:48:32 -0700 (PDT) In-Reply-To: <70e7fbc3-aeb5-460f-9a59-e5dfc902d15f@default> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:158673 Archived-At: On 22.04.2019 16:08, Drew Adams wrote: > I > see only `C-o' (`xref-show-location-at-point'), > whose name says it does that, but only for point, > not for the mouse position. (And when I try `C-o' > it too switches to another window, the same as `RET'.) It doesn't do that over here. > In any case, how is Xref different from, say, Occur > wrt mouse actions and the general interaction? What > makes it so special that it should be problematic to > fix this bug? Honestly, it's quite easy. I'm pasting the code patch below. Would you write the NEWS entry for it? And any necessary manual changes would be nice as well. diff --git a/lisp/progmodes/xref.el b/lisp/progmodes/xref.el index c7f015b94f..6dcdd75c84 100644 --- a/lisp/progmodes/xref.el +++ b/lisp/progmodes/xref.el @@ -722,8 +722,9 @@ xref--next-error-function (defvar xref--button-map (let ((map (make-sparse-keymap))) (define-key map [(control ?m)] #'xref-goto-xref) - (define-key map [mouse-1] #'xref-goto-xref) - (define-key map [mouse-2] #'xref--mouse-2) + (define-key map [follow-link] 'mouse-face) + (define-key map [mouse-2] #'xref-goto-xref) + (define-key map [mouse-3] #'xref--mouse-3) map)) (defun xref--mouse-2 (event)