From: Paul Eggert <eggert@cs.ucla.edu>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 53358@debbugs.gnu.org
Subject: bug#53358: 29.0.50; Compilation output messed up again
Date: Sun, 23 Jan 2022 23:25:13 -0800 [thread overview]
Message-ID: <3dd42ada-f681-6714-bc29-cb8dbb57e1eb@cs.ucla.edu> (raw)
In-Reply-To: <8735lgm5xh.fsf@gnus.org>
[-- Attachment #1: Type: text/plain, Size: 271 bytes --]
On 1/22/22 02:16, Lars Ingebrigtsen wrote:
> This is with a "make -j16 bootstrap" after doing a "make" after "git
> clean -xf", to ensure that all the files are rebuilt.
Oh, I messed up and used ifdef when I should have used ifneq. I
installed the attached to fix that.
[-- Attachment #2: 0001-Avoid-glitches-in-ELC-lines-in-build-output.patch --]
[-- Type: text/x-patch, Size: 1212 bytes --]
From eeb84de340e6f1fd53c56336b3a02e502212cf78 Mon Sep 17 00:00:00 2001
From: Paul Eggert <eggert@cs.ucla.edu>
Date: Sun, 23 Jan 2022 23:22:04 -0800
Subject: [PATCH] Avoid glitches in ELC lines in build output
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
* src/verbose.mk.in (AM_V_ELC, AM_V_ELN): Use ifneq not ifdef, as
we want have_working_info’s value expanded (Bug#53358).
---
src/verbose.mk.in | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/verbose.mk.in b/src/verbose.mk.in
index eb99e42695..4ec7788442 100644
--- a/src/verbose.mk.in
+++ b/src/verbose.mk.in
@@ -56,7 +56,7 @@ AM_V_CCLD = @$(info $ CCLD $@)
AM_V_CXXLD = @$(info $ CXXLD $@)
ifeq ($(HAVE_NATIVE_COMP)-$(NATIVE_DISABLED)-$(ANCIENT),yes--)
-ifdef have_working_info
+ifneq (,$(have_working_info))
AM_V_ELC = @$(info $ ELC+ELN $@)
AM_V_ELN = @$(info $ ELN $@)
else
@@ -64,7 +64,7 @@ AM_V_ELC = @echo " ELC+ELN " $@;
AM_V_ELN = @echo " ELN " $@;
endif
else
-ifdef have_working_info
+ifneq (,$(have_working_info))
AM_V_ELC = @$(info $ ELC $@)
else
AM_V_ELC = @echo " ELC " $@;
--
2.32.0
next prev parent reply other threads:[~2022-01-24 7:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-19 8:20 bug#53358: 29.0.50; Compilation output messed up again Lars Ingebrigtsen
2022-01-19 8:36 ` Lars Ingebrigtsen
2022-01-19 9:07 ` Eli Zaretskii
2022-01-19 9:16 ` Lars Ingebrigtsen
2022-01-19 23:32 ` Paul Eggert
2022-01-19 23:53 ` Paul Eggert
2022-01-20 8:10 ` Lars Ingebrigtsen
2022-01-20 18:21 ` Paul Eggert
2022-01-21 9:24 ` Lars Ingebrigtsen
2022-01-21 22:52 ` Paul Eggert
2022-01-22 10:16 ` Lars Ingebrigtsen
2022-01-24 7:25 ` Paul Eggert [this message]
2022-01-24 9:47 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3dd42ada-f681-6714-bc29-cb8dbb57e1eb@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=53358@debbugs.gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.