From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#35916: [PATCH] checkdoc fixes in bookmark.el Date: Sun, 26 May 2019 20:52:42 -0700 (PDT) Message-ID: <3d7f02e2-c064-4da4-b6e0-e7b52d0d357d@default> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="165662"; mail-complaints-to="usenet@blaine.gmane.org" To: Stefan Kangas , 35916@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon May 27 05:53:11 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hV6hD-000gvM-0P for geb-bug-gnu-emacs@m.gmane.org; Mon, 27 May 2019 05:53:11 +0200 Original-Received: from localhost ([127.0.0.1]:39553 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hV6hB-0008W1-RU for geb-bug-gnu-emacs@m.gmane.org; Sun, 26 May 2019 23:53:09 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:46092) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hV6h5-0008Vw-Bi for bug-gnu-emacs@gnu.org; Sun, 26 May 2019 23:53:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hV6h4-0000KA-En for bug-gnu-emacs@gnu.org; Sun, 26 May 2019 23:53:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38837) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hV6h4-0000K1-B6 for bug-gnu-emacs@gnu.org; Sun, 26 May 2019 23:53:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hV6h4-00083T-8Y for bug-gnu-emacs@gnu.org; Sun, 26 May 2019 23:53:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 27 May 2019 03:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35916 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 35916-submit@debbugs.gnu.org id=B35916.155892917830954 (code B ref 35916); Mon, 27 May 2019 03:53:02 +0000 Original-Received: (at 35916) by debbugs.gnu.org; 27 May 2019 03:52:58 +0000 Original-Received: from localhost ([127.0.0.1]:52381 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hV6gz-00083A-DY for submit@debbugs.gnu.org; Sun, 26 May 2019 23:52:58 -0400 Original-Received: from userp2130.oracle.com ([156.151.31.86]:35326) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hV6gx-00082t-UT for 35916@debbugs.gnu.org; Sun, 26 May 2019 23:52:56 -0400 Original-Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x4R3n9DR063199; Mon, 27 May 2019 03:52:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=esxiTSSflHu36r3Rq2UGeV84GhIXNo7/2M1yfHKeA4g=; b=huOIVQ9KEZAHKaoPoGhXu4uNl92EPzCkI8NEB0624ranp227h1CRFv/oq4eDspZ5rndW pJNHbjepAM5g90dkOORZz8EUkVvC2PGJu0H6vniolMRGKSGLPWhmxk4B2rtTk2qxNsTl AEBDDSOqZ6IEOOgqD87KT9rezSRlH9ha3kGYTHOB8n5GE7ifOAIktMcRhDXaGstXSLgT 2r+D9MPrmLbPdrm6IuZgSMaytUIwDdE4/hMYRdIHLEIBBcJIQlWx62l28y05gDaX1S2x VpnxurNK876s85UqPrgxh5h3AW5aoiOgwzhzavWjf2T6fASUx4G1VVRn3AMhEm+QXzZj iQ== Original-Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by userp2130.oracle.com with ESMTP id 2spw4t3w11-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 27 May 2019 03:52:49 +0000 Original-Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x4R3pmGE007484; Mon, 27 May 2019 03:52:48 GMT Original-Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserp3030.oracle.com with ESMTP id 2sqcmjhjs2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 27 May 2019 03:52:48 +0000 Original-Received: from abhmp0007.oracle.com (abhmp0007.oracle.com [141.146.116.13]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x4R3qhA8010684; Mon, 27 May 2019 03:52:44 GMT In-Reply-To: X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4849.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9269 signatures=668687 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1905270025 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9269 signatures=668687 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1905270025 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:159801 Archived-At: (Minor feedback.)=20 1. This one is wrong, IMO: - HANDLER is a function that provides the bookmark-jump behavior for a + HANDLER is a function that provides the `bookmark-jump' behavior for a That use of "bookmark-jump" is just an adjective, not the name of the speci= fic command `bookmark-jump'. The point of the handler is to provide alternative behavior from what comma= nd `bookmark-jump' provides. But in all cases that alternative is some kin= d of a "bookmark-jump behavior" - not behavior of command `bookmark-jump' b= ut some bookmark-jumping behavior. You could in fact alternatively say "bookmark-jumping behavior". But there= 's no need to (and it's not about a bookmark jumping but about jumping to a= bookmark location). 2. This one has a typo: +If the annotation does not exists, do nothing." ^ exist 3. This one makes some helpful corrections, but Emacs doesn't call this a "file path". It calls it an "absolute file name". + "Change the file path of the bookmark on the current line. +Prompt with completion for the new path." All the other changes look like improvements, to me. Thx. (And bug reports #35917 and #35918 are also welcome.)