From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Reto Zimmermann Newsgroups: gmane.emacs.bugs Subject: bug#63251: 28.2; vhdl-mode contribution Date: Thu, 4 May 2023 15:56:42 +0200 Message-ID: <3d52f4b8-a8d8-0eb7-1b61-8c5c8310bc1c@gnu.org> References: <83mt2kllq8.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6915"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Cc: 63251@debbugs.gnu.org To: Eli Zaretskii , Cyril Arnould Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu May 04 16:01:20 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1puZWK-0001fu-6G for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 04 May 2023 16:01:20 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1puZW5-0008HC-Ck; Thu, 04 May 2023 10:01:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1puZSK-0007O5-MT for bug-gnu-emacs@gnu.org; Thu, 04 May 2023 09:57:12 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1puZSA-0000TV-BY for bug-gnu-emacs@gnu.org; Thu, 04 May 2023 09:57:12 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1puZS9-0005RM-S2 for bug-gnu-emacs@gnu.org; Thu, 04 May 2023 09:57:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Reto Zimmermann Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 04 May 2023 13:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63251 X-GNU-PR-Package: emacs Original-Received: via spool by 63251-submit@debbugs.gnu.org id=B63251.168320861120893 (code B ref 63251); Thu, 04 May 2023 13:57:01 +0000 Original-Received: (at 63251) by debbugs.gnu.org; 4 May 2023 13:56:51 +0000 Original-Received: from localhost ([127.0.0.1]:51602 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1puZRy-0005Qv-V7 for submit@debbugs.gnu.org; Thu, 04 May 2023 09:56:51 -0400 Original-Received: from asave02.hostfactory.ch ([217.150.252.154]:39798) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1puZRu-0005Qk-2o for 63251@debbugs.gnu.org; Thu, 04 May 2023 09:56:49 -0400 Original-Received: from server09.hostfactory.ch ([185.117.170.110]) by asave02.hostfactory.ch with esmtps (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1puZRq-00075y-V3; Thu, 04 May 2023 15:56:44 +0200 Original-Received: from [192.168.0.99] (77-56-245-67.dclient.hispeed.ch [77.56.245.67]) (Authenticated sender: reto@retoweb.net) by server09.hostfactory.ch (Postfix) with ESMTPSA id C1FD2600241BB; Thu, 4 May 2023 15:56:41 +0200 (CEST) Content-Language: en-US In-Reply-To: <83mt2kllq8.fsf@gnu.org> X-PPP-Message-ID: <168320860207.15714.1218128604380003203@server09.hostfactory.ch> X-PPP-Vhost: retoweb.net X-Originating-IP: 185.117.170.110 X-SpamExperts-Domain: outboundprotection.hostfactory.ch X-SpamExperts-Username: 185.117.170.110 Authentication-Results: hostfactory.ch; auth=pass smtp.auth=185.117.170.110@outboundprotection.hostfactory.ch X-SpamExperts-Outgoing-Class: ham X-SpamExperts-Outgoing-Evidence: Combined (0.19) X-Recommended-Action: accept X-Filter-ID: Pt3MvcO5N4iKaDQ5O6lkdGlMVN6RH8bjRMzItlySaT8fqpyGU+JKm7iH73NU12oXPUtbdvnXkggZ 3YnVId/Y5jcf0yeVQAvfjHznO7+bT5zWeeXfe8rOJaVknViDr+wSeeTGE6/jLakLVHLNXqEJIhxS lJfpC26YA1p3y1AvmgZGfE8dHb9EGwzAhulvvFKhS+D2vI6B8nXTKx6M89rgzb9x5lMX6MhbABoo mERJbytaa40DxZPJuLUk3zkVKd8p4CuEXwMMCcu55/Z5CMTXnATZv3yedj9bxcXA/piha0/6oZjM /85swxkmKciKJwjqgDi+/7T16DN8cGs8VO04+YvoyRoynzCZCifNLhKZU97iVUdm9my+LflbFqbt gFcIEmJdZutYAM85hpsRCgzMqwCLV82M5MY/DVZtIrYIsdPUNrOF2YK2uKlri+LH134sPEg+PVRT iaxPY52n0Pp/846HfW6p0vld2I/++zLm8KrifXYuDMhUEM3aQb/Gz0q0UJqTJuY710nJBeCWvY4Q XlZnXtPburoqP/j1uizZfx9DFxQeM5hKKDqHvwRqP46o31/E3ahF5MMcDI7KdpjQKZ4xqPIc0G6k bpHbawWavOrDYwYZzM+Usa8X+GuUY3CVXj3gjnaj+6UA0UPkADHoS6gJylT+GdeVzzo8fCPU9s2+ 535SEn7rjFiHERuQKNS8YLXq+u4v0mZOOS2cVS/DC44pfZuA8vIitSY8vMUDbvJIIlqT7HdthvnW /HDJedAt00JnDHy8VhAbXwypogrG9boETNcXg0/k5loninDL6ejmGs1Fa3xRHcJFHrX8LUVeKy// ID+N6a23qUSq5sK6rs4Fql/GuR+Ch X-Report-Abuse-To: spam@asave01.hostfactory.ch X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:261015 Archived-At: On 2023-05-04 07:16, Eli Zaretskii wrote: >> From: Cyril Arnould >> Date: Wed, 3 May 2023 19:40:18 +0000 >> >> Following bug#62508, I've taken a bit of a closer look at the compiler >> regexp for ModelSim. I've modified it so that it can differentiate >> between Errors, Warnings and Notes when highlighting. I also make use of >> Xilinx Vivado at work, for which I've added a new compiler entry: >> >> >> --- a/lisp/progmodes/vhdl-mode.el >> +++ b/lisp/progmodes/vhdl-mode.el >> @@ -286,7 +286,7 @@ vhdl-compiler-alist >> ;; counter_rtl.vhd(29):Conditional signal assignment line__29 >> ("ModelSim" "vcom" "-93 -work \\1" "make" "-f \\1" >> nil "vlib \\1; vmap \\2 \\1" "./" "work/" "Makefile" "modelsim" >> - ("^\\(ERROR\\|WARNING\\|\\*\\* Error\\|\\*\\* Warning\\)[^:]*:\\( *\\[[0-9]+]\\| ([^)]+)\\)? \\([^ \t\n]+\\)(\\([0-9]+\\)):" 3 4 nil) >> + ("^\\(?:\\(?1:ERROR\\|\\*\\* Error\\)\\|\\(?2:WARNING\\|\\*\\* Warning\\)\\|\\(?3:NOTE\\|\\*\\* Note\\)\\)[^:]*:\\( *\\[[0-9]+]\\| ([^)]+)\\)? \\(?4:[^ \t\n]+\\)(\\(?5:[0-9]+\\)):" 4 5 nil (2 . 3)) >> ("" 0) >> ("\\1/_primary.dat" "\\2/\\1.dat" "\\1/_primary.dat" >> "\\1/_primary.dat" "\\1/body.dat" downcase)) >> @@ -385,6 +385,13 @@ vhdl-compiler-alist >> nil "mkdir \\1" "./" "work/" "Makefile" "xilinx" >> ("^ERROR:HDLParsers:[0-9]+ - \"\\([^ \t\n]+\\)\" Line \\([0-9]+\\)\\." 1 2 nil) ("" 0) >> nil) >> + ;; Xilinx Vivado: >> + ;; ERROR: [VRFC 10-1412] syntax error near o_idle [test.vhd:23] >> + ("Xilinx Vivado" "xvhdl" "" "make" "-f \\1" >> + nil "mkdir \\1" "./" "work" "Makefile" "vivado" >> + ("^\\(?:\\(?1:ERROR\\)\\|\\(?2:WARNING\\)\\|\\(?3:INFO\\)\\): \\(.+\\) \\[\\(?4:[^ \t\n]+\\):\\(?5:[0-9]+\\)\\]" 4 5 nil (2 . 3)) ("" 0) >> + ("\\1/entity" "\\2/\\1" "\\1/configuration" >> + "\\1/package" "\\1/body" downcase)) >> ) >> "List of available VHDL compilers and their properties. >> Each list entry specifies the following items for a compiler: >> >> >> The patch was generated from the emacs master branch. I would greatly >> appreciate it if these changes could find their way in some form into a >> future emacs release. > Reto, any comments on these changes? > > Thanks. The changes look good to me. Thanks, Reto