From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: xref-query-replace-in-results error message after xref-find-definitions, was: Re: bug#58158: 29.0.50; [overlay] Interval tree iteration considered harmful Date: Wed, 12 Oct 2022 16:47:15 +0300 Message-ID: <3ca55cea-712b-2e89-cdac-3a1893e3c53e@yandex.ru> References: <831qruh67o.fsf@gnu.org> <83y1u2foli.fsf@gnu.org> <83zgehe6iq.fsf@gnu.org> <95113379-99d8-eba4-f980-a7fca11430d5@yandex.ru> <834jwfmn5a.fsf@gnu.org> <838rlohzeo.fsf@gnu.org> <83mta2g91p.fsf@gnu.org> <237a3e26-03b8-a2a9-90bd-d50c3670a131@yandex.ru> <83wn96efyn.fsf@gnu.org> <5bb803bf-f51b-c175-f908-c60066d6967d@yandex.ru> <83v8oqeeqf.fsf@gnu.org> <7c0849be-145e-e073-49b5-63749e8d8282@yandex.ru> <83sfjuecyw.fsf@gnu.org> <83k056e4dz.fsf@gnu.org> <83h70ae23f.fsf@gnu.org> <21c2aec6-ee5e-c794-de3c-808356e72eb9@yandex.ru> <831qrdei3t.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40603"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Oct 12 15:50:43 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oic8B-000APf-G4 for ged-emacs-devel@m.gmane-mx.org; Wed, 12 Oct 2022 15:50:43 +0200 Original-Received: from localhost ([::1]:53848 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oic89-0001fv-ST for ged-emacs-devel@m.gmane-mx.org; Wed, 12 Oct 2022 09:50:41 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48378) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oic5A-0008U3-Ol for emacs-devel@gnu.org; Wed, 12 Oct 2022 09:47:36 -0400 Original-Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329]:52128) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oic58-0006Vi-Hw; Wed, 12 Oct 2022 09:47:36 -0400 Original-Received: by mail-wm1-x329.google.com with SMTP id n9so4880278wms.1; Wed, 12 Oct 2022 06:47:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=PM+WaOLppY/UPX9xWtzHwAyE6AUM6CtR9pkd9C115LE=; b=CtD9BtQ4j15FzbwRDQhVp9jNW+t+/5vtFNq3GAj3dY6OpxMhnBFgrb3xdQ3B93cvSx vW6dAB/o9LGvsJSUhAityaI2gZ7hlPjI7Jad4g6Tpq5C/W7PuJI2dSL685bYCkW9ab3v eZ3NjpLEm32kvini00oAbMSq6bW08FSR6stycA+tOG7ja8thSySxlK8zSUoT+CHMCS20 DArZJJPnE1gws7467oHn0DQ2l67vdmGstzw3fYvbETdpvPJ+JI0HznxrTYFXbNG6tv6J 2ih4UCRrw6hRgX/PjKHyH3jv7L12ae5pA38GXgI3t1QX8fkuoYLZbsYfhjbXApOccz2h 3zVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=PM+WaOLppY/UPX9xWtzHwAyE6AUM6CtR9pkd9C115LE=; b=uXgAyn/vjL6k1EI2aRANH2vtQRCFfP0H7oBUhQAKyKtv089uKKujdRIfH7Os5iDQCX ViAqaC2wN9gWimwlqz7fRofRUeCfwwaBrSlf3Ocyp3JLT/PSV+OQRgphOKFoFJGe4Iml q6doZnQJUxM9s0gzJiTPbP0lybauvU/69A6fuTvoblksbIaGvvDOOtUit20R4nBu5ZqI /c6qPNaENQCVUw5SvWJR7lODrbaK/W3YSvHwcD0kUb1vz8wRXiUSHXn+KkaDPuqI82/x eJJDrJEylCW4Gd+NuOrRCyoKqQQFvMbqS21UkfyEopy74W7LpD1wI+PUvzXmmqk8ne25 4Ocw== X-Gm-Message-State: ACrzQf2WpgjeZOBJ+B+neylMNPzgdQjQski8QRMpCJJ6OuIhlkpNRfOx KrlVR0aUnRWM9x8DJ5LPCrA6BFYIOCg= X-Google-Smtp-Source: AMsMyM7o2PezACv25O8o28K0gsZeO7m4rE3qqeWtEIUpkQD3gCPMysSjVPL8Yljz5nM87Sa6O7xWyA== X-Received: by 2002:a1c:7407:0:b0:3c6:cc25:c02f with SMTP id p7-20020a1c7407000000b003c6cc25c02fmr2842270wmc.124.1665582436970; Wed, 12 Oct 2022 06:47:16 -0700 (PDT) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id u7-20020a05600c19c700b003bf6da9d2cesm1888225wmq.28.2022.10.12.06.47.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 Oct 2022 06:47:16 -0700 (PDT) Content-Language: en-US In-Reply-To: <831qrdei3t.fsf@gnu.org> Received-SPF: pass client-ip=2a00:1450:4864:20::329; envelope-from=raaahh@gmail.com; helo=mail-wm1-x329.google.com X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.25, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, NICE_REPLY_A=-0.528, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:297610 Archived-At: On 12.10.2022 08:17, Eli Zaretskii wrote: >> Let's drop the "global" adjective, though: whether the command works >> "globally", "locally", or etc, depends on how the user made the search. > The "global" part is important, though: it's supposed to hint on why > find-definition results cannot be used. The opposite of "global" here > is "partial", not "local". If you can suggest a better word for > "global" here, please do. I think you're trying hard to make it clearer, but it still won't have 100% the intended effect. And it makes the error more likely to confuse the user and make them misunderstand how things work: 1) Saying "Cannot perform global replacement in find-definition results", with the explicit qualifier "global", potentially implies that a "local" replacement in find-definition results can be done. But it cannot. We can't do either currently for technical reasons. We don't want to do "local" replacements in find-definition results also for logical reasons, but that's just the reason why we're not in a hurry to remove the technical limitation. 2) The message implies 'r' is limited to "global" replacement. But it can easily do "partial" replacement, as long as the command that produces the list returns "match xrefs". dired-do-find-regexp, for example. Or project-find-regexp, when called with C-u, and the user specifies a specific directory. They will return a "partial" list of matches, compared to the full project search.