From: Max Nikulin <manikulin@gmail.com> To: 54764@debbugs.gnu.org, eggert@cs.ucla.edu Cc: orgmode <emacs-orgmode@gnu.org> Subject: bug#54764: encode-time: make DST and TIMEZONE fields of the list argument optional ones Date: Sat, 30 Apr 2022 18:22:11 +0700 [thread overview] Message-ID: <3c017c45-c82a-cb0e-6352-fabb21e7ac37@gmail.com> (raw) In-Reply-To: <42fc4072-4f8f-c6d3-ca39-2308f4597523@cs.ucla.edu> On 26/04/2022 02:49, Paul Eggert wrote: > On 4/25/22 08:37, Paul Eggert wrote: > > I'll be happy to review the revised org-encode-time implementation, > whenever you think it could use a review. (Sorry, I've lost track of > what the proposal is.) I suspended my activity due to discussions of other changes and waiting for commits related to your fixes of `org-parse-time-string' and `org-store-link' that do not require introducing of `org-encode-time-1'. I mean excerpts from https://debbugs.gnu.org/cgi/bugreport.cgi?att=1;msg=10;bug=54764;filename=0001-Improve-Org-usage-of-timestamps.patch I posted a corrected version of my `org-encode-time' macro, but I did not add you to Cc (I sent reply through news.gmane.io), and it has no special case to check whether `encode-time' supports 6 elements list argument: Max Nikulin to emacs-orgmode. [DRAFT][PATCH v2] org-encode-time compatibility and convenience helper. Sun, 24 Apr 2022 18:34:40 +0700. https://list.orgmode.org/t43cki$ct$1@ciao.gmane.io In my drafts I have the following changes in tests related to `org-parse-time-string': diff --git a/testing/lisp/test-org.el b/testing/lisp/test-org.el index 6aecc3af8..551d17d64 100644 --- a/testing/lisp/test-org.el +++ b/testing/lisp/test-org.el @@ -268,15 +268,15 @@ (ert-deftest test-org/org-parse-time-string () "Test `org-parse-time-string'." (should (equal (org-parse-time-string "2012-03-29 16:40") - '(0 40 16 29 3 2012 nil nil nil))) + '(0 40 16 29 3 2012 nil -1 nil))) (should (equal (org-parse-time-string "[2012-03-29 16:40]") - '(0 40 16 29 3 2012 nil nil nil))) + '(0 40 16 29 3 2012 nil -1 nil))) (should (equal (org-parse-time-string "<2012-03-29 16:40>") - '(0 40 16 29 3 2012 nil nil nil))) + '(0 40 16 29 3 2012 nil -1 nil))) (should (equal (org-parse-time-string "<2012-03-29>") - '(0 0 0 29 3 2012 nil nil nil))) + '(0 0 0 29 3 2012 nil -1 nil))) (should (equal (org-parse-time-string "<2012-03-29>" t) - '(0 nil nil 29 3 2012 nil nil nil)))) + '(0 nil nil 29 3 2012 nil -1 nil)))) (ert-deftest test-org/closest-date () "Test `org-closest-date' specifications."
WARNING: multiple messages have this Message-ID (diff)
From: Max Nikulin <manikulin@gmail.com> To: 54764@debbugs.gnu.org, eggert@cs.ucla.edu Cc: orgmode <emacs-orgmode@gnu.org> Subject: Re: bug#54764: encode-time: make DST and TIMEZONE fields of the list argument optional ones Date: Sat, 30 Apr 2022 18:22:11 +0700 [thread overview] Message-ID: <3c017c45-c82a-cb0e-6352-fabb21e7ac37@gmail.com> (raw) In-Reply-To: <42fc4072-4f8f-c6d3-ca39-2308f4597523@cs.ucla.edu> On 26/04/2022 02:49, Paul Eggert wrote: > On 4/25/22 08:37, Paul Eggert wrote: > > I'll be happy to review the revised org-encode-time implementation, > whenever you think it could use a review. (Sorry, I've lost track of > what the proposal is.) I suspended my activity due to discussions of other changes and waiting for commits related to your fixes of `org-parse-time-string' and `org-store-link' that do not require introducing of `org-encode-time-1'. I mean excerpts from https://debbugs.gnu.org/cgi/bugreport.cgi?att=1;msg=10;bug=54764;filename=0001-Improve-Org-usage-of-timestamps.patch I posted a corrected version of my `org-encode-time' macro, but I did not add you to Cc (I sent reply through news.gmane.io), and it has no special case to check whether `encode-time' supports 6 elements list argument: Max Nikulin to emacs-orgmode. [DRAFT][PATCH v2] org-encode-time compatibility and convenience helper. Sun, 24 Apr 2022 18:34:40 +0700. https://list.orgmode.org/t43cki$ct$1@ciao.gmane.io In my drafts I have the following changes in tests related to `org-parse-time-string': diff --git a/testing/lisp/test-org.el b/testing/lisp/test-org.el index 6aecc3af8..551d17d64 100644 --- a/testing/lisp/test-org.el +++ b/testing/lisp/test-org.el @@ -268,15 +268,15 @@ (ert-deftest test-org/org-parse-time-string () "Test `org-parse-time-string'." (should (equal (org-parse-time-string "2012-03-29 16:40") - '(0 40 16 29 3 2012 nil nil nil))) + '(0 40 16 29 3 2012 nil -1 nil))) (should (equal (org-parse-time-string "[2012-03-29 16:40]") - '(0 40 16 29 3 2012 nil nil nil))) + '(0 40 16 29 3 2012 nil -1 nil))) (should (equal (org-parse-time-string "<2012-03-29 16:40>") - '(0 40 16 29 3 2012 nil nil nil))) + '(0 40 16 29 3 2012 nil -1 nil))) (should (equal (org-parse-time-string "<2012-03-29>") - '(0 0 0 29 3 2012 nil nil nil))) + '(0 0 0 29 3 2012 nil -1 nil))) (should (equal (org-parse-time-string "<2012-03-29>" t) - '(0 nil nil 29 3 2012 nil nil nil)))) + '(0 nil nil 29 3 2012 nil -1 nil)))) (ert-deftest test-org/closest-date () "Test `org-closest-date' specifications."
next prev parent reply other threads:[~2022-04-30 11:22 UTC|newest] Thread overview: 106+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-04-07 12:37 bug#54764: encode-time: make DST and TIMEZONE fields of the list argument optional ones Max Nikulin 2022-04-09 7:52 ` Paul Eggert 2022-04-09 11:36 ` Max Nikulin 2022-04-10 3:57 ` Max Nikulin 2022-04-13 14:40 ` Max Nikulin 2022-04-13 14:40 ` Max Nikulin 2022-04-13 18:35 ` Paul Eggert 2022-04-13 18:35 ` Paul Eggert 2022-04-14 13:19 ` Max Nikulin 2022-04-14 13:19 ` Max Nikulin 2022-04-14 22:46 ` Paul Eggert 2022-04-15 2:14 ` Tim Cross 2022-04-15 2:14 ` Tim Cross 2022-04-15 17:23 ` Max Nikulin 2022-04-15 17:23 ` Max Nikulin 2022-04-16 19:23 ` Paul Eggert 2022-04-21 16:59 ` Max Nikulin 2022-04-21 16:59 ` Max Nikulin 2022-04-16 19:23 ` Paul Eggert 2022-04-19 2:02 ` Paul Eggert 2022-04-19 2:02 ` Paul Eggert 2022-04-19 5:50 ` Eli Zaretskii 2022-04-19 5:50 ` Eli Zaretskii 2022-04-19 22:22 ` Paul Eggert 2022-04-19 22:22 ` Paul Eggert 2022-04-20 7:23 ` Eli Zaretskii 2022-04-20 7:23 ` Eli Zaretskii 2022-04-20 18:19 ` Paul Eggert 2022-04-20 18:19 ` Paul Eggert 2022-04-20 18:41 ` Eli Zaretskii 2022-04-20 18:41 ` Eli Zaretskii 2022-04-20 19:01 ` Paul Eggert 2022-04-20 19:01 ` Paul Eggert 2022-04-20 19:14 ` Eli Zaretskii 2022-04-20 19:14 ` Eli Zaretskii 2022-04-20 19:23 ` Paul Eggert 2022-04-20 19:30 ` Eli Zaretskii 2022-04-20 19:30 ` Eli Zaretskii 2022-04-21 0:11 ` Paul Eggert 2022-04-21 0:11 ` Paul Eggert 2022-04-21 6:44 ` Eli Zaretskii 2022-04-21 6:44 ` Eli Zaretskii 2022-04-21 15:30 ` Max Nikulin 2022-04-21 15:58 ` Eli Zaretskii 2022-04-21 17:23 ` Max Nikulin 2022-04-21 18:46 ` Eli Zaretskii 2022-04-21 23:56 ` Paul Eggert 2022-04-21 23:56 ` Paul Eggert 2022-04-22 5:01 ` Eli Zaretskii 2022-04-22 5:01 ` Eli Zaretskii 2022-04-22 5:23 ` Time resolution in Emacs " Eli Zaretskii 2022-04-22 18:22 ` Paul Eggert 2022-04-22 18:52 ` Corwin Brust 2022-04-22 21:26 ` Paul Eggert 2022-04-23 6:27 ` Time resolution in Emacs Eli Zaretskii 2022-04-24 0:56 ` Paul Eggert 2022-04-24 6:10 ` Eli Zaretskii 2022-04-24 11:47 ` Max Nikulin 2022-04-24 12:23 ` Eli Zaretskii 2022-04-25 15:32 ` Paul Eggert 2022-04-25 16:01 ` Eli Zaretskii 2022-04-22 19:35 ` Time resolution in Emacs argument optional ones Eli Zaretskii 2022-04-22 21:52 ` Paul Eggert 2022-04-23 6:51 ` Time resolution in Emacs Eli Zaretskii 2022-04-25 15:34 ` Paul Eggert 2022-04-25 16:10 ` Eli Zaretskii 2022-04-25 16:38 ` Paul Eggert 2022-04-25 16:57 ` Eli Zaretskii 2022-04-25 16:54 ` Max Nikulin 2022-04-25 17:02 ` Eli Zaretskii 2022-04-25 19:27 ` Paul Eggert 2022-04-29 15:19 ` Max Nikulin 2022-04-29 16:07 ` Eli Zaretskii 2022-04-20 19:23 ` bug#54764: encode-time: make DST and TIMEZONE fields of the list argument optional ones Paul Eggert 2022-04-23 14:35 ` Bernhard Voelker 2022-04-23 14:35 ` Bernhard Voelker 2022-04-20 15:07 ` Max Nikulin 2022-04-20 18:29 ` Paul Eggert 2022-04-20 18:29 ` Paul Eggert 2022-04-25 15:30 ` Max Nikulin 2022-04-25 15:30 ` Max Nikulin 2022-04-25 15:37 ` Paul Eggert 2022-04-25 15:37 ` Paul Eggert 2022-04-25 19:49 ` Paul Eggert 2022-04-25 19:49 ` Paul Eggert 2022-04-30 11:22 ` Max Nikulin [this message] 2022-04-30 11:22 ` Max Nikulin 2022-05-01 2:32 ` Paul Eggert 2022-05-01 2:32 ` Paul Eggert 2022-05-01 17:15 ` Max Nikulin 2022-05-01 17:15 ` Max Nikulin 2022-04-20 15:07 ` Max Nikulin 2022-04-14 22:46 ` Paul Eggert 2022-04-13 15:12 ` Max Nikulin 2022-04-13 15:12 ` Max Nikulin 2022-04-16 16:26 ` Max Nikulin 2022-04-17 1:58 ` Paul Eggert 2022-04-17 1:58 ` Paul Eggert 2022-04-20 16:56 ` Max Nikulin 2022-04-20 16:56 ` Max Nikulin 2022-04-20 19:17 ` Paul Eggert 2022-04-20 19:17 ` Paul Eggert 2022-04-16 16:26 ` Max Nikulin 2022-04-09 7:52 ` Paul Eggert [not found] ` <handler.54764.D54764.165091617725815.notifdone@debbugs.gnu.org> 2022-04-25 21:16 ` Glenn Morris 2022-04-26 1:18 ` Paul Eggert
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=3c017c45-c82a-cb0e-6352-fabb21e7ac37@gmail.com \ --to=manikulin@gmail.com \ --cc=54764@debbugs.gnu.org \ --cc=eggert@cs.ucla.edu \ --cc=emacs-orgmode@gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index https://git.savannah.gnu.org/cgit/emacs.git https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.