From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#66732: tree-sitter fontification doesn't update multi-line syntax reliably Date: Sun, 17 Dec 2023 20:32:29 +0200 Message-ID: <3beef57a-12c5-0ea0-d6d7-752d0aa4fb8d@gutov.dev> References: <878r7s5cdf.fsf@honnef.co> <83fs1tbou1.fsf@gnu.org> <835y1zo3rw.fsf@gnu.org> <2ce274aa-6d01-4d0a-b10c-07f821343fed@gmail.com> <50920549-006c-0153-2471-02e41a3dada7@gutov.dev> <8c7cd429-bdc3-4fac-ad1c-fbad793bf1a0@gmail.com> <231ebcd1-ec30-0432-82e7-d63e11cd65f7@gutov.dev> <765D713E-9923-4F66-9044-9D69C104C9B0@gmail.com> <33fe5d61-5022-67c5-6a65-babde4fb7f91@gutov.dev> <92CACD38-9534-4A07-8DE3-CE8408272FB6@gmail.com> <59CC46F7-867E-4C74-83EC-49B41DF0FAB8@gmail.com> <2C418114-3773-4D62-90CB-E4C7F1B7D467@gmail.com> <029f6911-c4f5-1217-73bf-f57b7f941ae2@gutov.dev> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18997"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Cc: Eli Zaretskii , 66732@debbugs.gnu.org, Stefan Monnier , dominik@honnef.co To: Yuan Fu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 17 19:33:25 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rEvx5-0004eF-Sp for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 17 Dec 2023 19:33:25 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rEvwl-00075F-Lx; Sun, 17 Dec 2023 13:33:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rEvwj-000755-GS for bug-gnu-emacs@gnu.org; Sun, 17 Dec 2023 13:33:01 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rEvwj-00031M-7n for bug-gnu-emacs@gnu.org; Sun, 17 Dec 2023 13:33:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rEvwk-0005BX-3D for bug-gnu-emacs@gnu.org; Sun, 17 Dec 2023 13:33:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 17 Dec 2023 18:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66732 X-GNU-PR-Package: emacs Original-Received: via spool by 66732-submit@debbugs.gnu.org id=B66732.170283796419897 (code B ref 66732); Sun, 17 Dec 2023 18:33:02 +0000 Original-Received: (at 66732) by debbugs.gnu.org; 17 Dec 2023 18:32:44 +0000 Original-Received: from localhost ([127.0.0.1]:59016 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rEvwR-0005Ao-M5 for submit@debbugs.gnu.org; Sun, 17 Dec 2023 13:32:44 -0500 Original-Received: from wout5-smtp.messagingengine.com ([64.147.123.21]:41171) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rEvwP-0005AX-MN for 66732@debbugs.gnu.org; Sun, 17 Dec 2023 13:32:42 -0500 Original-Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id DF72E32009B5; Sun, 17 Dec 2023 13:32:33 -0500 (EST) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Sun, 17 Dec 2023 13:32:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1702837953; x=1702924353; bh=Ff74qZXLgY0/+JPHvmxZ51qcNn1Sr/Bc/QEOJWxJfgo=; b= h7axhdOyfCAdA+GTsPy78EASG/St5vaHwq0KaTY9X/V99QUPVTe3fKeDSgqt1/os 8jNxgfAturdhnH2/YAkkqOfm23UO2XhyyLgPGXTsg8BhTzqqSlwD9/HUHZEbVZC0 hjz9S7BwDUPWYzdg8VMSlhTSL45Nw90THrjwkzEvJGBX2vB0svYq3lDCo2YRA5rF Lq03P/AsxC9YyQWkxrpDneHqKpdhlbx0M6pZ4LNV+x1eRAPedA7iGfgsNAVEyOLy reZSuM/Xorp68Su9BB/UHSZZft5sXhE16tUk8GB6uoXa9K37M9B8llQQzuxbqS9o WLqyrKSbZgdjih2Etx6jtw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1702837953; x= 1702924353; bh=Ff74qZXLgY0/+JPHvmxZ51qcNn1Sr/Bc/QEOJWxJfgo=; b=T Ah8L7T3oanyZthudlBdO+4h53bXuw9oxWybpzOTzXSxy/2/VILxPsyXjZlCX4K4a 8UbJbSCGfa9/ZQx7ZjZwXs/n27DH6KqtdSmeYdyK1ycAZkizqxSBNH1zfU8Wr41N BvxuJVHWQdbkfmI69z/BEmb7ok17PtdUGaVlyJEoccimU4QZSBGKlC3szvcJ5OG5 WyuGKfwoKO4z//ySZEznZMgpgIZ7vYcbvvG/D51xE47j0BhDOWru30qe+qJRspeS wTSCabqokt9tOx88L3R1f5/qRuHAMwugr8b2nhMpt4bwYqkLNmFmk3wFn4JPjnq1 cFl3TzUn8K8CeltlA+XQg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrvddtiedguddufecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefkffggfgfuvfevfhfhjggtgfesthejredttdefjeenucfhrhhomhepffhm ihhtrhihucfiuhhtohhvuceoughmihhtrhihsehguhhtohhvrdguvghvqeenucggtffrrg htthgvrhhnpeeigfetveehveevffehledtueekieeikeeufeegudfgfeeghfdulefgfeev ledvveenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe gumhhithhrhiesghhuthhovhdruggvvh X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 17 Dec 2023 13:32:31 -0500 (EST) Content-Language: en-US In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:276434 Archived-At: On 17/12/2023 03:16, Yuan Fu wrote: > +(defun treesit--pre-syntax-ppss (&rest _) > + "Force reparse and consequently run all notifiers. > + > +Similar to font-lock, we want to update the `syntax' text > +property before `syntax-ppss' starts working on the text." > + (treesit--pre-redisplay) > + nil) This callback might be the best place to inform syntax-propertize about the extended bounds which need to be re-parsed, so I'm not sure about Stefan's suggestion to return nil here. Even calling syntax-ppss-flush-cache wouldn't be a full solution, because that wouldn't update the value of START in syntax-propertize.