From: Drew Adams <drew.adams@oracle.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Karl Fogel <kfogel@red-bean.com>,
15746@debbugs.gnu.org, Leo Liu <sdl.web@gmail.com>
Subject: bug#15746: 24.3; [PATCH] bookmark should confirm when overwrite
Date: Tue, 29 Oct 2013 19:35:02 -0700 (PDT) [thread overview]
Message-ID: <3bb8958a-dd47-469b-9ee5-2891ba575344@default> (raw)
In-Reply-To: <jwvd2mn1pgg.fsf-monnier+emacsbugs@gnu.org>
> How 'bout the following:
> - change bookmark-set to emit a clear message when it updates an
> existing message, as well as recording the previous value
> somewhere.
> - provide a bookmark-undo command so the user can undo his
> bookmark-set when he discovers that he has just changed an
> existing bookmark by mistake.
> This way, we avoid prompting Drew annoyingly when he knows full well
> he's updating the bookmark.
> Leo, would that be sufficient to avoid the regrets, or did you
> realize too late for a bookmark-undo to be of any use?
To quote a famous person ;-), that would really be overthinking this.
The simple solution, which I expect everyone might be able to agree
to, is to have two different commands. And to bind them both to keys,
at least on `bookmark-map'. Choose the default behavior you like for
the traditional key, `C-x r m'. For the other command use, e.g.,
`C-x r M'. Not a big deal. Users can get either behavior at any time.
Update `bookmark-set' to check not only the case in question (same
name as existing bookmark, and no prefix arg) but also a global
variable. Define the new command by let-binding that variable around
`call-interactively' of `bookmark-set'.
next prev parent reply other threads:[~2013-10-30 2:35 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-29 3:32 bug#15746: 24.3; [PATCH] bookmark should confirm when overwrite Leo Liu
2013-10-29 14:20 ` Drew Adams
2013-10-29 18:24 ` Karl Fogel
2013-10-29 20:09 ` Drew Adams
2013-10-29 20:51 ` Karl Fogel
2013-10-29 22:16 ` Drew Adams
2013-10-30 4:31 ` Karl Fogel
2013-10-30 14:07 ` Drew Adams
2013-10-30 2:11 ` Stefan Monnier
2013-10-30 2:35 ` Drew Adams [this message]
2013-10-30 2:56 ` Leo Liu
2013-10-30 3:14 ` Stefan Monnier
2013-10-30 3:36 ` Leo Liu
2013-10-30 3:57 ` Stefan Monnier
2013-10-30 14:07 ` Drew Adams
2013-10-30 18:17 ` Stefan Monnier
2013-10-30 1:28 ` Leo Liu
2013-10-30 2:26 ` Drew Adams
2015-11-08 19:27 ` bug#15746: Fix committed to master Karl Fogel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3bb8958a-dd47-469b-9ee5-2891ba575344@default \
--to=drew.adams@oracle.com \
--cc=15746@debbugs.gnu.org \
--cc=kfogel@red-bean.com \
--cc=monnier@iro.umontreal.ca \
--cc=sdl.web@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.