From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#52237: 29.0.50; [PATCH] Doubled separators in context-menu-mode Date: Sat, 4 Dec 2021 14:09:50 -0800 Message-ID: <3b763b93-0077-c14d-3940-d0c033f5cfb8@gmail.com> References: <0bbe5580-8e05-4e18-5b91-04b41b6f19bc@gmail.com> <07494cfd-0608-acb9-2839-e7ecbef4610c@gmail.com> <86h7bouq5f.fsf@mail.linkov.net> <53e0f3fd-d630-a384-c488-27fec72e6386@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11732"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 52237@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Dec 04 23:11:57 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mtdG9-0002tG-Cu for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 04 Dec 2021 23:11:57 +0100 Original-Received: from localhost ([::1]:44948 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mtdG8-00038s-D6 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 04 Dec 2021 17:11:56 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:60840) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mtdEI-0001Hk-Bi for bug-gnu-emacs@gnu.org; Sat, 04 Dec 2021 17:10:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44041) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mtdEI-0004Kx-3r for bug-gnu-emacs@gnu.org; Sat, 04 Dec 2021 17:10:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mtdEH-0006HJ-QY for bug-gnu-emacs@gnu.org; Sat, 04 Dec 2021 17:10:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 04 Dec 2021 22:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52237 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo patch Original-Received: via spool by 52237-submit@debbugs.gnu.org id=B52237.163865579824120 (code B ref 52237); Sat, 04 Dec 2021 22:10:01 +0000 Original-Received: (at 52237) by debbugs.gnu.org; 4 Dec 2021 22:09:58 +0000 Original-Received: from localhost ([127.0.0.1]:55587 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mtdEE-0006Gx-7r for submit@debbugs.gnu.org; Sat, 04 Dec 2021 17:09:58 -0500 Original-Received: from mail-pf1-f173.google.com ([209.85.210.173]:37749) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mtdED-0006Gl-3h for 52237@debbugs.gnu.org; Sat, 04 Dec 2021 17:09:57 -0500 Original-Received: by mail-pf1-f173.google.com with SMTP id 8so6439422pfo.4 for <52237@debbugs.gnu.org>; Sat, 04 Dec 2021 14:09:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:from:to:cc:references:message-id:date:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=XMhWcXo/9JDUFLlaLhJ7c6tvglqMkQaiskt3yY6YMls=; b=Zls6+AQGZudxHfvm4k0FKcygPdh/L3Dt4U4ojGGgC+hX15d7W5TkI5Pzp7UUFGRXr+ 0ssqzBq/7U4blCjDLw/SuFsdI3kyt2Gzqc28jxNyhNUiRcIo4O7aec80Tp3XQoDYwjOm VVacvUtCT1rU5ibqmeA+0u8rty9STyCbFzCs4FnLXxIDc8gV7a+9JLfY1xdvMhVmR763 h7qWbD6wXSyvOkbJygbp1/LThZ99dCGlDqwxFH3K9D9G3KyqYs+pf9LI+NO2a0LPh4+E kytNvfZNuM5s0VJozSnrpn6Kv37dr4UKN3UxYvqtT0r0uOT09WZSXIXX+YDg93iGPQnE LkwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=XMhWcXo/9JDUFLlaLhJ7c6tvglqMkQaiskt3yY6YMls=; b=VLhVhwpg8Tfhcn5SXCwO4Fr3fB2nNG6JUcMka2vsaxIvZ/nhnuQs/DIBVko0jIL0H+ 6CWIK8gXEUqHtbRh8ogHy1qsWpS/km6nl/m6+eCG1kKz/PAm6TNKEuHep79coSW0MBjx 6LR2gt13Pl1pk54R6GqkD7BjM1B61CKU+OAtNWBl7p3/eVnyt6505ta0YVxeSwB5YTmI qHGabR2X0LLbTAyjgSJIoOLYFrepO5N7TWmfiOTASv6CXMmq+TA067MWyYC+FXWogR4d nxU6rcRtGixEmb408vh9jA9DAcKkoNWoy2Thb/+QD1fPsWozElsED/MraCmLibQzq62u CL8g== X-Gm-Message-State: AOAM5333HFRvGhhEYYRGYagt8/I3OBoOQsxGFKohhU25C9rSaYGGgdGr QNJ4JPJT0Bbfz+p0pXpZ6stcJ6+XMyQ= X-Google-Smtp-Source: ABdhPJx6pHsWN9j2iu6dgFyUk5J58vrqQQQ3lrA41ZBq/A4s9I6Kbz0dDx8eMtjPmUq4j0noa6fELQ== X-Received: by 2002:a05:6a00:1946:b0:44d:8136:a4a4 with SMTP id s6-20020a056a00194600b0044d8136a4a4mr27520866pfk.46.1638655791310; Sat, 04 Dec 2021 14:09:51 -0800 (PST) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id k3sm8010748pff.211.2021.12.04.14.09.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 04 Dec 2021 14:09:51 -0800 (PST) In-Reply-To: <53e0f3fd-d630-a384-c488-27fec72e6386@gmail.com> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:221532 Archived-At: On 12/4/2021 12:56 PM, Jim Porter wrote: > On 12/4/2021 11:50 AM, Juri Linkov wrote: >> `context-menu-middle-separator' is a function, so it requires the >> `context-menu-' prefix.  It adds the menu item [middle-separator]. >> Since "middle" is an adjective, the word order can't be >> "separator-middle". >> But "buffers-separator" doesn't look nicer than `separator-buffers'. > > I think `FOO-separator' is the best choice here for the separators > themselves. `FOO' acts as a noun adjunct[1], modifying the underlying > object: a separator. For functions that just make a separator, they'd be > named `MODULE-[FOO-]-separator', with `FOO-' being optional if it would > be redundant with the module name. So then > `context-menu-middle-separator' is the right function name, and it adds > a separator named `middle-separator'. > > `buffers-separator' is a bit of an odd phrasing since, as the Wikipedia > article mentions, "Noun adjuncts were traditionally mostly singular". > However, I think it's still a bit easier to read that correctly as "the > separator used to mark the buffers", whereas `separator-buffers' reads > more like "buffers used to separate things" to me. > > Since this should just be a trivial renaming, hopefully we can merge > that into Emacs 28 so we're not locked into the current names. > > [1] https://en.wikipedia.org/wiki/Noun_adjunct Ok, filed bug#52286 for this: https://lists.gnu.org/archive/html/bug-gnu-emacs/2021-12/msg00327.html