From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#49277: 28.0.50; [PATCH] Fix ediff3 with window-combinaison-resize Date: Wed, 30 Jun 2021 09:37:46 +0200 Message-ID: <3b5f00bf-0572-8ca8-462b-d87f01bfe17e@gmx.at> References: <87im1wy3va.fsf@riseup.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18292"; mail-complaints-to="usenet@ciao.gmane.io" To: Trust me I am a Doctor , 49277@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jun 30 09:38:13 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lyUnU-0004fj-II for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 30 Jun 2021 09:38:12 +0200 Original-Received: from localhost ([::1]:48332 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lyUnT-0004Sc-J6 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 30 Jun 2021 03:38:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40806) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lyUnL-0004RZ-8p for bug-gnu-emacs@gnu.org; Wed, 30 Jun 2021 03:38:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44817) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lyUnK-0002vE-UM for bug-gnu-emacs@gnu.org; Wed, 30 Jun 2021 03:38:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lyUnK-00059G-So for bug-gnu-emacs@gnu.org; Wed, 30 Jun 2021 03:38:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 Jun 2021 07:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49277 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 49277-submit@debbugs.gnu.org id=B49277.162503867719772 (code B ref 49277); Wed, 30 Jun 2021 07:38:02 +0000 Original-Received: (at 49277) by debbugs.gnu.org; 30 Jun 2021 07:37:57 +0000 Original-Received: from localhost ([127.0.0.1]:56362 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lyUnF-00058q-Ie for submit@debbugs.gnu.org; Wed, 30 Jun 2021 03:37:57 -0400 Original-Received: from mout.gmx.net ([212.227.17.21]:50187) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lyUnE-00058d-4h for 49277@debbugs.gnu.org; Wed, 30 Jun 2021 03:37:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1625038667; bh=il5blwk1Xsc4IDBTEcXNrqjM6ZYdOr+QbdgNk4AZshc=; h=X-UI-Sender-Class:Subject:To:References:From:Date:In-Reply-To; b=YEoOOY0erVIPKQaUqf5WZ51darRuTlM73W9n6eNAhxBFFuMgHDw7ZpJV/SNN4sMIZ aOAKijxc32a4pcqKpA7esqup6KnK7QyOs6BGkuFaKfgOYVfGuCa7rU6OPuR6VYTxtG B7pxfo+kmgQNwAiBME4US1KUz+OgQpVCmgf9DfSo= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from [192.168.1.102] ([46.125.249.76]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MOiDX-1la3ca0uZ5-00QCmo; Wed, 30 Jun 2021 09:37:47 +0200 In-Reply-To: <87im1wy3va.fsf@riseup.net> Content-Language: en-US X-Provags-ID: V03:K1:Czlu5kG2TH2yKacga4/R38QS3kxM+2tSllW1f4G+DySAeCv+zOp 1eEAelKQDfvBRiCN7HPFyOqiDGulexN7mBgyrc80w6RNDnxg783Xx9Oeg7I0NXxVOfnmDTo dIh4LuNtzSbUsj0aARvRgf2U+P3y2IwPGNNEHPq0p0uyN1MtICzvawkUh7/HIEbj1zfAn+z 1UHGQFMrr+a7vrkoQ1s6g== X-UI-Out-Filterresults: notjunk:1;V03:K0:Fe8qBW/mxH0=:NhHeVoIP4ITup7ht2gDVz3 h12R/ucEfhEwrRfn4pXhQH2KEkRSVhDXiFWnOYmho161J6LkXJcS5XoemVTF+r7O0VEpGXgtb bFPfPXA1sHdr/HxRiluqm9i42MAHo7rODQr1hl1UqKewFzCeKmeIloSHhV0WTRuDoOL35RThb FtsYFQrWaOqA5tTPEuLftP8waCIziuKSWy1TWJXovO/s96DqhelpZ2mdF7yJY6ictpPSPRbCZ zoN9iCYzia6ZARQ4fmQVmUyCSnohFAb0LOHjBHCOeEQyOV6Mw9JE5N6qI+QVu0H+ZtmL//7DG X7eyXhBdQssKMwTIa2t4UUmQXdUiU5r+/Q7NfTdGjpkegGTe/lwpcCNfiUkd/ksgmJZHnXqKd E7774u1m5BA+v9JTq46uuW+1HKHsjkx6p7SSBkkrqSP2umns247MqwN1BZ8GLUTW0uLx7jrMT OKT3FA9wM/wf4G8RTcIWMMi4qlmevjgjndZdWeP/GgW6ky5ApLSLUYd4K8+WfCOnBzB1hvtWk paOee6VQ6a4ukxwOQ0lOp9X0OX73JdFV7jClkggKU016emmpMZTyg29gIlhGV/Df/nHCjx8wY jS+Kc5qb3wJJmgwAdlHympwZZiXHtHjGkf/pT17q+WRpIEkbpjSgXUlWipBRjtF+dl8nW79WH ejB9VV3mMTm14OEyFQQEKTr4xiiH7sprzHp0lqFPY6Ky5QG2dQ5niTzyKi7zDtM9iUUqotBxo IfScsbIztcq2/S3DM8odjM50iOhk3e5HcMb1YyJGklkljehGxUqs0ATnXDYoVkwDoh0PUsGh X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:209140 Archived-At: > I have a bug when calling ediff3, the layout is not a balanced. > > Ultimately I found that combining this settings were the culprit : > > (setq window-combination-resize t > even-window-sizes nil) > > ;; you can test it with eg : > (setq default-directory "/home/user") > (ediff3 ".bashrc" > ".bash_history" > ".bash_logout") > > Removing the manual resizing when splitting windows and relying rather > on 'window-combinaison-resize' to balance the layout, solve the issue. I think we can easily do that but it does not handle the (setq window-combination-resize t even-window-sizes nil ediff-window-setup-function 'ediff-setup-windows-plain) case here. Shouldn't we fix that too? Thanks, martin