all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: martin rudalics <rudalics@gmx.at>
To: Trust me I am a Doctor <pillule@riseup.net>, 49277@debbugs.gnu.org
Subject: bug#49277: 28.0.50; [PATCH] Fix ediff3 with window-combinaison-resize
Date: Wed, 30 Jun 2021 09:37:46 +0200	[thread overview]
Message-ID: <3b5f00bf-0572-8ca8-462b-d87f01bfe17e@gmx.at> (raw)
In-Reply-To: <87im1wy3va.fsf@riseup.net>

 > I have a bug when calling ediff3, the layout is not a balanced.
 >
 > Ultimately I found that combining this settings were the culprit :
 >
 > (setq window-combination-resize t
 >        even-window-sizes nil)
 >
 > ;; you can test it with eg :
 > (setq default-directory "/home/user")
 > (ediff3 ".bashrc"
 >          ".bash_history"
 >          ".bash_logout")
 >
 > Removing the manual resizing when splitting windows and relying rather
 > on 'window-combinaison-resize' to balance the layout, solve the issue.

I think we can easily do that but it does not handle the

(setq window-combination-resize t
       even-window-sizes nil
       ediff-window-setup-function 'ediff-setup-windows-plain)

case here.  Shouldn't we fix that too?

Thanks, martin





  reply	other threads:[~2021-06-30  7:37 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-29 16:24 bug#49277: 28.0.50; [PATCH] Fix ediff3 with window-combinaison-resize Trust me I am a Doctor
2021-06-30  7:37 ` martin rudalics [this message]
2021-07-08 13:33   ` marmote-te
2021-07-19 16:07     ` Lars Ingebrigtsen
2021-07-20  7:20       ` martin rudalics
2021-07-21 11:12         ` Trust me I am a Doctor
2021-08-18  8:02           ` martin rudalics
2021-08-18 18:25             ` Trust me I am a Doctor
2021-08-18 18:25             ` Trust me I am a Doctor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3b5f00bf-0572-8ca8-462b-d87f01bfe17e@gmx.at \
    --to=rudalics@gmx.at \
    --cc=49277@debbugs.gnu.org \
    --cc=pillule@riseup.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.