From: Jim Porter <jporterbugs@gmail.com>
To: Vincenzo Pupillo <v.pupillo@gmail.com>, 64985@debbugs.gnu.org
Subject: bug#64985: 30.0.50; package-recompile-all and package-recompile do not recompile anything, seems related to the patch associated with bug #64985
Date: Fri, 4 Aug 2023 13:05:56 -0700 [thread overview]
Message-ID: <3af9fde7-4cee-d38f-c626-f9c29d472049@gmail.com> (raw)
In-Reply-To: <2359232.ElGaqSPkdT@fedora>
[-- Attachment #1: Type: text/plain, Size: 337 bytes --]
On 8/4/2023 12:37 PM, Vincenzo Pupillo wrote:
> It seems to be a problem related to the patch attached to the bug #64985
> My byte-compile-ignore-files is nil as a result, If I've made no mistake,
> (mapconcat #'identity byte-compile-ignore-files "\\|") is an empty string.
> Could this be the problem?
Oops. Does this patch fix things?
[-- Attachment #2: 0001-Fix-handling-of-byte-compile-ignore-files-when-nil.patch --]
[-- Type: text/plain, Size: 1179 bytes --]
From 1ca1492a15eb97e7ab7929fd2166f1bf53e8dbbb Mon Sep 17 00:00:00 2001
From: Jim Porter <jporterbugs@gmail.com>
Date: Fri, 4 Aug 2023 13:01:35 -0700
Subject: [PATCH] Fix handling of 'byte-compile-ignore-files' when nil
Before this fix, when 'byte-compile-ignore-files' was nil,
'byte-recompile-directory' would ignore every file (bug#64985).
* lisp/emacs-lisp/bytecomp.el (byte-recompile-directory): Handle case
when 'byte-compile-ignore-files' is nil.
---
lisp/emacs-lisp/bytecomp.el | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/lisp/emacs-lisp/bytecomp.el b/lisp/emacs-lisp/bytecomp.el
index 65ccb60726f..d093d95a775 100644
--- a/lisp/emacs-lisp/bytecomp.el
+++ b/lisp/emacs-lisp/bytecomp.el
@@ -1923,7 +1923,9 @@ byte-recompile-directory
(let ((directories (list default-directory))
(default-directory default-directory)
(ignore-files-regexp
- (mapconcat #'identity byte-compile-ignore-files "\\|"))
+ (if byte-compile-ignore-files
+ (mapconcat #'identity byte-compile-ignore-files "\\|")
+ regexp-unmatchable))
(skip-count 0)
(fail-count 0)
(file-count 0)
--
2.25.1
next prev parent reply other threads:[~2023-08-04 20:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-01 6:20 bug#64985: 29.1; [PATCH] Byte-compilation of packages via package-vc doesn't correctly handle .elpaignore wildcards Jim Porter
2023-08-01 11:21 ` Eli Zaretskii
2023-08-01 19:22 ` Jim Porter
2023-08-01 12:20 ` Philip Kaludercic
2023-08-01 16:10 ` Jim Porter
2023-08-01 16:18 ` Jim Porter
2023-08-01 17:29 ` Mattias Engdegård
2023-08-01 18:10 ` Jim Porter
2023-08-01 18:32 ` Philip Kaludercic
2023-08-01 19:18 ` Jim Porter
2023-08-01 19:21 ` Philip Kaludercic
2023-08-02 18:08 ` Jim Porter
2023-08-04 19:37 ` bug#64985: 30.0.50; package-recompile-all and package-recompile do not recompile anything, seems related to the patch associated with bug #64985 Vincenzo Pupillo
2023-08-04 20:05 ` Jim Porter [this message]
2023-08-05 17:12 ` Mattias Engdegård
2023-08-05 17:16 ` Jim Porter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3af9fde7-4cee-d38f-c626-f9c29d472049@gmail.com \
--to=jporterbugs@gmail.com \
--cc=64985@debbugs.gnu.org \
--cc=v.pupillo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.