all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* org-agenda-phases-of-moon tries to call wrong function
@ 2017-04-16 13:50 Teemu Likonen
  2017-04-16 18:48 ` Paul Eggert
  0 siblings, 1 reply; 7+ messages in thread
From: Teemu Likonen @ 2017-04-16 13:50 UTC (permalink / raw)
  To: emacs-devel; +Cc: Glenn Morris, Paul Eggert, Carsten Dominik


[-- Attachment #1.1: Type: text/plain, Size: 386 bytes --]

(Cc'ing to hopefully right people.)

Org-agenda-mode has an "M" key for org-agenda-phases-of-moon command
which tries to call function calendar-phases-of-moon. That function
doesn't exist anymore and should be calendar-lunar-phases instead. The
bug is in the master and emacs-25 branches. The attached trivial patch
fixes the problem (and I can push it myself if someone gives an OK).


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: 0001-Fix-org-agenda-s-command-for-calendar-lunar-phases.patch --]
[-- Type: text/x-diff, Size: 1053 bytes --]

From b8b3d36eb6f5a8134955170657621828c9ebbf32 Mon Sep 17 00:00:00 2001
From: Teemu Likonen <tlikonen@iki.fi>
Date: Sun, 16 Apr 2017 16:14:22 +0300
Subject: [PATCH] Fix org-agenda's command for calendar-lunar-phases

Function org-agenda-phases-of-moon tries to call a non-existing
function calendar-phases-of-moon. The correct function is
calendar-lunar-phases.
---
 lisp/org/org-agenda.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/org/org-agenda.el b/lisp/org/org-agenda.el
index c870ddd..153e377 100644
--- a/lisp/org/org-agenda.el
+++ b/lisp/org/org-agenda.el
@@ -9533,7 +9533,7 @@ org-agenda-execute-calendar-command
 (defun org-agenda-phases-of-moon ()
   "Display the phases of the moon for the 3 months around the cursor date."
   (interactive)
-  (org-agenda-execute-calendar-command 'calendar-phases-of-moon))
+  (org-agenda-execute-calendar-command 'calendar-lunar-phases))
 
 (defun org-agenda-holidays ()
   "Display the holidays for the 3 months around the cursor date."
-- 
2.1.4


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 454 bytes --]

^ permalink raw reply related	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2017-07-03  7:22 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-04-16 13:50 org-agenda-phases-of-moon tries to call wrong function Teemu Likonen
2017-04-16 18:48 ` Paul Eggert
2017-04-17 16:55   ` Glenn Morris
2017-04-18  3:15     ` Richard Stallman
2017-04-18 16:58       ` Glenn Morris
2017-04-18 21:52         ` Richard Stallman
2017-07-03  7:22           ` Bastien

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.