From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: emacs-28 6b89578: ; * lisp/progmodes/flymake.el: Update the minimum Emacs version. Date: Tue, 21 Dec 2021 19:19:22 +0300 Message-ID: <3a5e0b87-a867-d910-5e77-438f1f682259@yandex.ru> References: <20211209150232.17813.54295@vcs0.savannah.gnu.org> <20211209150233.DE3FB207E0@vcs0.savannah.gnu.org> <4fe1d55e-96fe-ed42-e7b9-afe86f24700b@yandex.ru> <8335mn2tm0.fsf@gnu.org> <33e24936-0da0-0398-dd52-ae6fd32f4b09@yandex.ru> <59BC79DE-1574-4744-B4FA-B50A801D52A8@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23573"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 To: Eli Zaretskii , emacs-devel@gnu.org, =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Dec 21 17:22:14 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mzhu2-0005tC-Oe for ged-emacs-devel@m.gmane-mx.org; Tue, 21 Dec 2021 17:22:14 +0100 Original-Received: from localhost ([::1]:39544 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mzhu0-0006WB-V5 for ged-emacs-devel@m.gmane-mx.org; Tue, 21 Dec 2021 11:22:12 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:45864) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mzhsW-0004ze-Bq for emacs-devel@gnu.org; Tue, 21 Dec 2021 11:20:40 -0500 Original-Received: from [2a00:1450:4864:20::42c] (port=42506 helo=mail-wr1-x42c.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mzhsT-0003DX-Gc; Tue, 21 Dec 2021 11:20:39 -0500 Original-Received: by mail-wr1-x42c.google.com with SMTP id c4so27998026wrd.9; Tue, 21 Dec 2021 08:20:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=J3bLgI5Z3Mn8McdkwVJRhj28c9mUIODuG+AvvwXh07o=; b=S0FP5HTGUsu8L+T/H/w2m7+CplF+oauBmAI3Wvsq5uzEvL1V2ZI5Dvg5asK8zO47g3 m212JHyOElDHwPSTuuS1oOBuQA10ZoKSFQbetklIpwx77Vwf20W1DKxeAJT7NkC+Nffw 75X87dXfJOWXAWGGKllFUa89+7opxPLRi8ZQZRmYEsezH9T+8t4WUhEmf7KIeKLoWvcK 7iURrdU9I1RWypAAny6If/8apSM07gl3DoVu1JIqfc6nsBOP10/8fhM41M20lnnyzH4x J1TTMGsC6n0xeBWnT8WZ3RB4cqU0CpVT+ieDXH5ai8PPyPPQijUawoN3svjTbMMVEfDa agAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=J3bLgI5Z3Mn8McdkwVJRhj28c9mUIODuG+AvvwXh07o=; b=H4dQ+txoZHe17MLlFwLjafZ3WsEsASnmCBDQIAxHb5Ny76sT9Xm3DOYfAXjnYZZxTh PP/xvAo1GSA0GBbnMPNLbvOwtV8VvDyViq5evvL1n6MaYfkSNIDlx3jx4372PgCMrJnD 52flBeGPj4ut6brswtswg/B/sBkhOqNL1txIWjKW/hvcg3XBbSL+qBjvB/61TXwVsXdN TNX9pxziRsqX9EQnfrSr1oXJ/6KIsY3WsG91WrQyLUs0KHOr27mk0lPkNHxJyjD/kbil gfYjFAWAGrVfKMzKksc439K1tzk+g4xI7yYJ4HhIN/ZhVLLq44v3mL4CE85OgduXPyOz kLHw== X-Gm-Message-State: AOAM531mdb3dmkA7Oto/Akxewra31UmsHku3xRZeY2Ww+Lk9KXgE0QhF jtNOoUQxYyPyKS3A40XY2344TGNp/9e8VA== X-Google-Smtp-Source: ABdhPJz6qLb/fkigiTPnNVtYEp7dOvud9EQdBAya51EUnTPf9WPo37WFVVTM8RvmTaq4UNCJptBZYw== X-Received: by 2002:adf:dc12:: with SMTP id t18mr3369481wri.566.1640103634969; Tue, 21 Dec 2021 08:20:34 -0800 (PST) Original-Received: from [10.112.109.103] ([185.209.196.172]) by smtp.googlemail.com with ESMTPSA id e18sm13569419wrx.36.2021.12.21.08.20.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Dec 2021 08:20:34 -0800 (PST) In-Reply-To: <59BC79DE-1574-4744-B4FA-B50A801D52A8@gnu.org> Content-Language: en-US X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::42c (failed) Received-SPF: pass client-ip=2a00:1450:4864:20::42c; envelope-from=raaahh@gmail.com; helo=mail-wr1-x42c.google.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, NICE_REPLY_A=-2.012, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:282600 Archived-At: On 21.12.2021 08:57, Eli Zaretskii wrote: > On December 21, 2021 6:08:25 AM GMT+02:00, Dmitry Gutov wrote: >> On 20.12.2021 18:17, Eli Zaretskii wrote: >>>> From: Dmitry Gutov >>>> Date: Mon, 20 Dec 2021 03:07:08 +0300 >>>> >>>> Hi Eli, >>>> >>>> On 09.12.2021 18:02, Eli Zaretskii wrote: >>>>> -;; Package-Requires: ((emacs "26.1") (eldoc "1.1.0") (project "0.7.1")) >>>>> +;; Package-Requires: ((emacs "28.1") (eldoc "1.1.0") (project "0.7.1")) >>>> Could you explain that change? >>> See >>> >>> https://lists.gnu.org/archive/html/help-gnu-emacs/2021-12/msg00166.html >> >> That doesn't seem like a good idea: other packages depend on it being >> compatible with Emacs 26. >> >> The change that broke that should be reverted instead. >> >> > > I'm okay with doing that provided that the patch to revert is simple and safe. Please show the patch. I think I will let Joao take point on that. Note that the Package-Requires header in emacs-28 doesn't matter much. The problem will arise when that change is merged to master and then (sometime later) the Version header is also bumped in flymake.el. From that POV your change in emacs-28 wasn't necessary either, but we can ignore that branch and fix it better on master (do the revert of the previous change).