From: Dmitry Gutov <dgutov@yandex.ru>
To: "Eli Zaretskii" <eliz@gnu.org>,
emacs-devel@gnu.org, "João Távora" <joaotavora@gmail.com>
Subject: Re: emacs-28 6b89578: ; * lisp/progmodes/flymake.el: Update the minimum Emacs version.
Date: Tue, 21 Dec 2021 19:19:22 +0300 [thread overview]
Message-ID: <3a5e0b87-a867-d910-5e77-438f1f682259@yandex.ru> (raw)
In-Reply-To: <59BC79DE-1574-4744-B4FA-B50A801D52A8@gnu.org>
On 21.12.2021 08:57, Eli Zaretskii wrote:
> On December 21, 2021 6:08:25 AM GMT+02:00, Dmitry Gutov <dgutov@yandex.ru> wrote:
>> On 20.12.2021 18:17, Eli Zaretskii wrote:
>>>> From: Dmitry Gutov<dgutov@yandex.ru>
>>>> Date: Mon, 20 Dec 2021 03:07:08 +0300
>>>>
>>>> Hi Eli,
>>>>
>>>> On 09.12.2021 18:02, Eli Zaretskii wrote:
>>>>> -;; Package-Requires: ((emacs "26.1") (eldoc "1.1.0") (project "0.7.1"))
>>>>> +;; Package-Requires: ((emacs "28.1") (eldoc "1.1.0") (project "0.7.1"))
>>>> Could you explain that change?
>>> See
>>>
>>> https://lists.gnu.org/archive/html/help-gnu-emacs/2021-12/msg00166.html
>>
>> That doesn't seem like a good idea: other packages depend on it being
>> compatible with Emacs 26.
>>
>> The change that broke that should be reverted instead.
>>
>>
>
> I'm okay with doing that provided that the patch to revert is simple and safe. Please show the patch.
I think I will let Joao take point on that.
Note that the Package-Requires header in emacs-28 doesn't matter much.
The problem will arise when that change is merged to master and then
(sometime later) the Version header is also bumped in flymake.el.
From that POV your change in emacs-28 wasn't necessary either, but we
can ignore that branch and fix it better on master (do the revert of the
previous change).
next prev parent reply other threads:[~2021-12-21 16:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20211209150232.17813.54295@vcs0.savannah.gnu.org>
[not found] ` <20211209150233.DE3FB207E0@vcs0.savannah.gnu.org>
2021-12-20 0:07 ` emacs-28 6b89578: ; * lisp/progmodes/flymake.el: Update the minimum Emacs version Dmitry Gutov
2021-12-20 15:17 ` Eli Zaretskii
2021-12-21 4:08 ` Dmitry Gutov
2021-12-21 5:57 ` Eli Zaretskii
2021-12-21 16:19 ` Dmitry Gutov [this message]
2021-12-21 16:43 ` João Távora
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3a5e0b87-a867-d910-5e77-438f1f682259@yandex.ru \
--to=dgutov@yandex.ru \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=joaotavora@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.