From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Phil Sainty Newsgroups: gmane.emacs.bugs Subject: bug#35351: 27.0.50; Enable derived modes to run their own very-early 'change-major-mode-hook' code Date: Tue, 23 Apr 2019 11:18:31 +1200 Message-ID: <3a0b9268-4800-1513-8422-065a74bb6b36@orcon.net.nz> References: <85237c18-768d-089b-221a-fe70b0ba4379@orcon.net.nz> <7db75b50-1925-8c1e-acc5-c393b701e6a3@orcon.net.nz> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="145786"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 Cc: 35351@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Apr 23 01:24:37 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hIiId-000bgq-Vm for geb-bug-gnu-emacs@m.gmane.org; Tue, 23 Apr 2019 01:24:36 +0200 Original-Received: from localhost ([127.0.0.1]:45516 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hIiIc-0000BZ-Sm for geb-bug-gnu-emacs@m.gmane.org; Mon, 22 Apr 2019 19:24:34 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:40475) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hIiIQ-00009i-07 for bug-gnu-emacs@gnu.org; Mon, 22 Apr 2019 19:24:22 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hIiDG-0000Jl-PB for bug-gnu-emacs@gnu.org; Mon, 22 Apr 2019 19:19:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38327) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hIiDG-0000JZ-3J for bug-gnu-emacs@gnu.org; Mon, 22 Apr 2019 19:19:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hIiDF-0003Gj-Su for bug-gnu-emacs@gnu.org; Mon, 22 Apr 2019 19:19:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Phil Sainty Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 22 Apr 2019 23:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35351 X-GNU-PR-Package: emacs Original-Received: via spool by 35351-submit@debbugs.gnu.org id=B35351.155597511612534 (code B ref 35351); Mon, 22 Apr 2019 23:19:01 +0000 Original-Received: (at 35351) by debbugs.gnu.org; 22 Apr 2019 23:18:36 +0000 Original-Received: from localhost ([127.0.0.1]:51870 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hIiCq-0003G5-IM for submit@debbugs.gnu.org; Mon, 22 Apr 2019 19:18:36 -0400 Original-Received: from smtp-3.orcon.net.nz ([60.234.4.44]:37958) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hIiCo-0003Fw-Rv for 35351@debbugs.gnu.org; Mon, 22 Apr 2019 19:18:35 -0400 Original-Received: from [150.107.172.17] (port=33802 helo=[192.168.20.103]) by smtp-3.orcon.net.nz with esmtpa (Exim 4.86_2) (envelope-from ) id 1hIiCl-0001BO-IZ; Tue, 23 Apr 2019 11:18:31 +1200 In-Reply-To: Content-Language: en-GB X-GeoIP: NZ X-Spam_score: -2.9 X-Spam_score_int: -28 X-Spam_bar: -- X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:158088 Archived-At: On 23/04/19 2:39 AM, Stefan Monnier wrote: >> I'm now unsure whether :after-hook was intended to be interpreted >> as "this is a bit like a *hook* which runs *after* everything >> else has happened"; or if it meant "do this thing *after* the >> mode *hook*" (or indeed after after-change-major-mode-hook). > > Oh, you're absolutely right, it's called ":after-hook" because it > runs after the mode-hook. Which means :before-hook definitely isn't a good name for the new keyword. Should I go with :eval-before ? And should I add :eval-after as an alias for :after-hook, for naming symmetry? (Even if :after-hook makes better sense than you initially thought, it's maybe still not the best name for it.) >> In the initial commit I've used an approach which will run the >> parent's :before-hook > > That seems backward to me. > >> Possibly it should be child-before-parent on the basis that the >> author then has more influence over the order in which things >> happen? > > Exactly. Cool. I'm switching that around. -Phil