From: Phil Sainty <psainty@orcon.net.nz>
To: Stefan Monnier <monnier@IRO.UMontreal.CA>
Cc: 35351@debbugs.gnu.org
Subject: bug#35351: 27.0.50; Enable derived modes to run their own very-early 'change-major-mode-hook' code
Date: Tue, 23 Apr 2019 11:18:31 +1200 [thread overview]
Message-ID: <3a0b9268-4800-1513-8422-065a74bb6b36@orcon.net.nz> (raw)
In-Reply-To: <jwvlg02qfbk.fsf-monnier+emacs@gnu.org>
On 23/04/19 2:39 AM, Stefan Monnier wrote:
>> I'm now unsure whether :after-hook was intended to be interpreted
>> as "this is a bit like a *hook* which runs *after* everything
>> else has happened"; or if it meant "do this thing *after* the
>> mode *hook*" (or indeed after after-change-major-mode-hook).
>
> Oh, you're absolutely right, it's called ":after-hook" because it
> runs after the mode-hook.
Which means :before-hook definitely isn't a good name for the new
keyword.
Should I go with :eval-before ?
And should I add :eval-after as an alias for :after-hook, for naming
symmetry? (Even if :after-hook makes better sense than you initially
thought, it's maybe still not the best name for it.)
>> In the initial commit I've used an approach which will run the
>> parent's :before-hook
>
> That seems backward to me.
>
>> Possibly it should be child-before-parent on the basis that the
>> author then has more influence over the order in which things
>> happen?
>
> Exactly.
Cool. I'm switching that around.
-Phil
next prev parent reply other threads:[~2019-04-22 23:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-21 2:35 bug#35351: 27.0.50; Enable derived modes to run their own very-early 'change-major-mode-hook' code Phil Sainty
2019-04-21 2:45 ` Phil Sainty
2019-04-21 6:01 ` Richard Stallman
2019-04-21 6:23 ` Eli Zaretskii
2019-04-21 20:54 ` bug#35351: 27.0.50; " Stefan Monnier
2019-04-22 8:16 ` Phil Sainty
2019-04-22 14:39 ` Stefan Monnier
2019-04-22 23:18 ` Phil Sainty [this message]
2019-04-22 23:31 ` Phil Sainty
2019-04-23 2:08 ` Stefan Monnier
2019-04-23 3:52 ` Phil Sainty
2019-04-23 11:59 ` Stefan Monnier
2019-04-22 14:41 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3a0b9268-4800-1513-8422-065a74bb6b36@orcon.net.nz \
--to=psainty@orcon.net.nz \
--cc=35351@debbugs.gnu.org \
--cc=monnier@IRO.UMontreal.CA \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.