From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Pip Cet Newsgroups: gmane.emacs.devel Subject: Re: scratch/igc 26ea4b462a0: Fix GTK-related MPS crashes Date: Tue, 09 Jul 2024 17:19:37 +0000 Message-ID: <3PIe9r2EdB3_AfXh2PCLvHFUUfe3Lw_AzuftyFBUPSij-qEEJAjTQ9zz7BpqQuQhgzGYfc4XjRxkc_LDjDUKIaabmkrOGhosyxtPitzpqMg=@protonmail.com> References: <172010929191.25736.12718952666511242363@vcs2.savannah.gnu.org> <20240704160812.55782C2BC72@vcs2.savannah.gnu.org> <87zfqqzm43.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8406"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Andrea Corallo , emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jul 09 19:55:22 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sRF3i-0001q3-Kq for ged-emacs-devel@m.gmane-mx.org; Tue, 09 Jul 2024 19:55:22 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sRF2l-0004et-IZ; Tue, 09 Jul 2024 13:54:23 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sREVH-0002x6-4R for emacs-devel@gnu.org; Tue, 09 Jul 2024 13:19:47 -0400 Original-Received: from mail-40133.protonmail.ch ([185.70.40.133]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sREVF-0001zY-3P for emacs-devel@gnu.org; Tue, 09 Jul 2024 13:19:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1720545582; x=1720804782; bh=0y3CmZLIpe1SvT5VgJvIz/erx+TenMIxmuJJ1NXuHCo=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=By+fmUkbHzJAHt42Mk27KmNZfi7r0DZnl7trwgSqVGLyaJiPx3QBIyjNUKmhISnJo S5pm/Hyh30/H62+37O8WRWPxX4duh92KDb5ybHDeD8gH0KexfFQhdmjyEQJXwlFOod CqAAcKWX2M9uHYHjk7hS+25pkfM8FVpSTVEXE7G644IW2ymvad6/NjHtcrM/TGYEdc 7e3VwqDT6ET4p+koWBMO8PUJ5Y5ShCatrVn0s9XLqri+oZ9xF9fVX6WOmauhlCnwD5 Svw6CqLqrOCK9wHuAtG7ZovffXk0qQg5wP7Ho5vgExy03JJUF9hKEObCUU2VGdIswS 2CyqQGnJuDQRw== In-Reply-To: <87zfqqzm43.fsf@yahoo.com> Feedback-ID: 112775352:user:proton X-Pm-Message-ID: d19258f78d461f15f5a6c1bd5ecaa9f46bd3dd94 Received-SPF: pass client-ip=185.70.40.133; envelope-from=pipcet@protonmail.com; helo=mail-40133.protonmail.ch X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Tue, 09 Jul 2024 13:54:22 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:321568 Archived-At: On Tuesday, July 9th, 2024 at 14:16, Po Lu wrote: > Andrea Corallo acorallo@gnu.org writes: > > Pip Cet pipcet@protonmail.com writes: > >=20 > > > On Tuesday, July 9th, 2024 at 12:28, Andrea Corallo acorallo@gnu.org = wrote: > > >=20 > > > > Pip Cet via Mailing list for Emacs changes emacs-diffs@gnu.org writ= es: > > > >=20 > > > > > branch: scratch/igc > > > > > commit 26ea4b462a031a8e57ed3ef8f8d76ba3f88b1372 > > > > > Author: Pip Cet pipcet@protonmail.com > > > > > Commit: Pip Cet pipcet@protonmail.com > > > > >=20 > > > > > Fix GTK-related MPS crashes > > > > >=20 > > > > > * src/gtkutil.c (free_glib_user_data): New function. > > > > > (xg_list_insert, xg_list_remove): Conditionalize on !HAVE_MPS. > > > > > (qttip_cb, xg_create_frame_widgets) > > > > > (xg_create_frame_outer_widgets, create_dialog) > > > > > (make_cl_data, unref_cl_data, xg_mark_data) > > > > > (menuitem_highlight_callback, xg_create_one_menuitem) > > > > > (create_menus, xg_update_menu_item, xg_modify_menubar_widgets) > > > > > (draw_page, xg_print_frames_dialog, xg_create_toolbar) > > > > > (xg_im_context_commit, xg_widget_style_updated) > > > > > (tb_size_cb): Adjust to use `get_glib_user_data' and` g_signal_co= nnect_data'. > > > > > (xg_initialize): Remove linked list if HAVE_MPS. > > > > > * src/gtkutil.h (glib_user_data, get_glib_user_data): New helper > > > > > functions. > > > > > * src/xmenu.c (menubar_selection_callback) > > > > > (popup_selection_callback): Adjust to use `get_glib_user_data'. > > > >=20 > > > > Hello, > > > >=20 > > > > as on my system gsignal.h does not define G_CONNECT_DEFAULT but onl= y > > > > G_CONNECT_AFTER and G_CONNECT_SWAPPED this commit introduces the > > > > following on my system: > > >=20 > > > Thank you! Can you let me know which gtk/glib version that is? I'd > > > like to check the source code to make sure we can pass the right > > > flag instead. > > >=20 > > > I think we're okay just passing 0 instead. > > >=20 > > > Pip > >=20 > > Should be GTK 3.24.33 and glib 2.0. >=20 >=20 > Passing 0 is correct. Thank you both, just pushed a fix. Please let me know if it isn't working. Pip