Re: hl-line-mode is buffer-local in spite of its documentation

Re: hl-line-mode is buffer-local in spite of its documentation

[Lute Kamstra]

Peter S Galbraith <psg.debian.org@mixing.qc.dfo.ca> writes:

> hl-line.el says that `hl-line-mode' is a global mode and that:
>
> ;; You could make variable `hl-line-mode' buffer-local to avoid
> ;; highlighting specific buffers.
>
> but somehow hl-line-mode is always a buffer-local variable after
> invoking `emacs21 -q --no-site-file'.  The side-effect is that it
> doesn't work as expected.  If you turn it on, it is enabled in only
> that buffer and not globally.  If you turn it on in a second buffer,
> it works in both buffers now, but if you turn it off in one of those
> buffers then it doesn't work in either since the hooks are removed
> globally.

Thanks for you report.  You are right.  It is already fixed in CVS.
In fact, line highlighting has changed somewhat.  You can check it out
at:

http://savannah.gnu.org/cgi-bin/viewcvs/*checkout*/emacs/emacs/lisp/hl-line.el?rev=HEAD&content-type=text/plain


Regards,

  Lute Kamstra.

Re: hl-line-mode is buffer-local in spite of its documentation

[Kevin Rodgers]

Peter S Galbraith wrote:

> hl-line.el says that `hl-line-mode' is a global mode and that:
> 
> ;; You could make variable `hl-line-mode' buffer-local to avoid
> ;; highlighting specific buffers.
> 
> but somehow hl-line-mode is always a buffer-local variable after
> invoking `emacs21 -q --no-site-file'.  The side-effect is that it
> doesn't work as expected.  If you turn it on, it is enabled in only
> that buffer and not globally.


That's a documentation bug:

*** emacs-21.3/lisp/hl-line.el.orig	Sun Aug 26 06:08:58 2001
--- emacs-21.3/lisp/hl-line.el	Mon Sep  8 09:58:00 2003
***************
*** 25,31 ****

   ;;; Commentary:

! ;; Provides a global minor mode (toggled by M-x hl-line-mode) to
   ;; highlight, on a suitable terminal, the line in the current window
   ;; on which point is (except in a minibuffer window).  Done to satisfy
   ;; a request for a feature of Lesser Editors.
--- 25,32 ----

   ;;; Commentary:

! ;; Provides a local minor mode (toggled by M-x hl-line-mode) and
! ;; a global minor mode (toggled by M-x global-hl-line-mode) to
   ;; highlight, on a suitable terminal, the line in the current window
   ;; on which point is (except in a minibuffer window).  Done to satisfy
   ;; a request for a feature of Lesser Editors.
***************
*** 44,52 ****
   ;; `hl-line-highlight', on `post-command-hook', activates it again
   ;; across the window width.

- ;; You could make variable `hl-line-mode' buffer-local to avoid
- ;; highlighting specific buffers.
-
   ;;; Code:

   (defgroup hl-line nil
--- 45,50 ----

> If you turn it on in a second buffer,
> it works in both buffers now, but if you turn it off in one of those
> buffers then it doesn't work in either since the hooks are removed
> globally.

Since hl-line-highlight tests the value of hl-line-mode and hl-line-unhighlight
test the value of hl-line-overlay, perhaps it's not necessary to remove them
from pre-command-hook and post-command-hook respectively (in hl-line-mode).

-- 
Kevin Rodgers

hl-line-mode is buffer-local in spite of its documentation

[Peter S Galbraith]

hl-line.el says that `hl-line-mode' is a global mode and that:

;; You could make variable `hl-line-mode' buffer-local to avoid
;; highlighting specific buffers.

but somehow hl-line-mode is always a buffer-local variable after
invoking `emacs21 -q --no-site-file'.  The side-effect is that it
doesn't work as expected.  If you turn it on, it is enabled in only
that buffer and not globally.  If you turn it on in a second buffer,
it works in both buffers now, but if you turn it off in one of those
buffers then it doesn't work in either since the hooks are removed
globally.

Peter

In GNU Emacs 21.2.1 (i386-debian-linux-gnu, X toolkit, Xaw3d scroll bars)
 of 2002-03-22 on raven, modified by Debian
configured using `configure  i386-debian-linux-gnu --prefix=/usr --sharedstatedir=/var/lib --libexecdir=/usr/lib --localstatedir=/var/lib --infodir=/usr/share/info --mandir=/usr/share/man --with-pop=yes --with-x=yes --with-x-toolkit=athena --without-gif'
Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: C
  locale-coding-system: nil
  default-enable-multibyte-characters: t


Recent input:
<help-echo> <help-echo> <escape> h l - l i n e - 
m o d e <return> C-h v h l - m o <tab> <backspace> 
<backspace> l i <tab> m <tab> <return> <escape> x r 
e p o t <backspace> r t <tab> <return>

Recent messages:
Loading image...done
Loading tooltip...done
For information about the GNU Project and its goals, type C-h C-p.
Loading hl-line...done
Hl-Line mode enabled
Loading view...done
Loading pp...done
Loading /usr/lib/emacs/21.2/i386-debian-linux-gnu/fns-21.2.1.el (source)...done
Type C-x 1 to remove help window.  C-M-v to scroll the help.
Loading emacsbug...done