* prompt of cvs-do-removal
@ 2003-08-22 10:13 Masatake YAMATO
2003-08-22 23:52 ` Stefan Monnier
2003-08-25 22:27 ` Kevin Rodgers
0 siblings, 2 replies; 4+ messages in thread
From: Masatake YAMATO @ 2003-08-22 10:13 UTC (permalink / raw)
Cc: emacs-devel
When I delete multiple files at once on *cvs* buffer, I can know
which files will be deleted easily because files are marked with `*'
and font-lock puts different color on the lines started from `*'.
In other hand, When I delete one file by `r(cvs-mode-remove)',
sometime I cannot know which file will be deleted easily because
the file is not marked with `*'.
With next patch, the file name is shown in the prompt when pcl-cvs user
tries to delete a file with `r'.
Masatake
P.S. Thank you for reviewing my patch every time.
2003-08-05 Masatake YAMATO <jet@gyve.org>
* pcvs.el (cvs-do-removal): Show the deleted file name
on the prompt.
cvs diff: warning: unrecognized response `access control disabled, clients can connect from any host' from cvs server
Warning: Remote host denied X11 forwarding.
Index: lisp/pcvs.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/pcvs.el,v
retrieving revision 1.59
diff -u -r1.59 pcvs.el
--- lisp/pcvs.el 23 May 2003 19:31:02 -0000 1.59
+++ lisp/pcvs.el 22 Aug 2003 10:00:44 -0000
@@ -2043,7 +2043,9 @@
(shrink-window-if-larger-than-buffer))))
(if (not (or silent
(unwind-protect
- (yes-or-no-p (format "Delete %d files? " (length files)))
+ (if (eq 1 (length files))
+ (yes-or-no-p (format "Delete file: \"%s\" ? " (cvs-fileinfo->file (car files))))
+ (yes-or-no-p (format "Delete %d files? " (length files))))
(cvs-bury-buffer tmpbuf cvs-buffer))))
(progn (message "Aborting") nil)
(dolist (fi files)
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: prompt of cvs-do-removal
2003-08-22 10:13 prompt of cvs-do-removal Masatake YAMATO
@ 2003-08-22 23:52 ` Stefan Monnier
2003-08-25 22:27 ` Kevin Rodgers
1 sibling, 0 replies; 4+ messages in thread
From: Stefan Monnier @ 2003-08-22 23:52 UTC (permalink / raw)
Cc: monnier, emacs-devel
> When I delete multiple files at once on *cvs* buffer, I can know
> which files will be deleted easily because files are marked with `*'
> and font-lock puts different color on the lines started from `*'.
>
> In other hand, When I delete one file by `r(cvs-mode-remove)',
> sometime I cannot know which file will be deleted easily because
> the file is not marked with `*'.
>
> With next patch, the file name is shown in the prompt when pcl-cvs user
> tries to delete a file with `r'.
Looks good, please install it.
Thank you,
Stefan
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: prompt of cvs-do-removal
2003-08-22 10:13 prompt of cvs-do-removal Masatake YAMATO
2003-08-22 23:52 ` Stefan Monnier
@ 2003-08-25 22:27 ` Kevin Rodgers
2003-08-31 2:14 ` Masatake YAMATO
1 sibling, 1 reply; 4+ messages in thread
From: Kevin Rodgers @ 2003-08-25 22:27 UTC (permalink / raw)
Masatake YAMATO wrote:
> P.S. Thank you for reviewing my patch every time.
...
> - (yes-or-no-p (format "Delete %d files? " (length files)))
> + (if (eq 1 (length files))
> + (yes-or-no-p (format "Delete file: \"%s\" ? " (cvs-fileinfo->file (car files))))
> + (yes-or-no-p (format "Delete %d files? " (length files))))
Wouldn't = be more appropriate than eq there? And you may want to bind (length files) to a local
variable, so you don't have to re-evaluate it.
--
Kevin Rodgers
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: prompt of cvs-do-removal
2003-08-25 22:27 ` Kevin Rodgers
@ 2003-08-31 2:14 ` Masatake YAMATO
0 siblings, 0 replies; 4+ messages in thread
From: Masatake YAMATO @ 2003-08-31 2:14 UTC (permalink / raw)
Cc: emacs-devel
> Masatake YAMATO wrote:
>
> > P.S. Thank you for reviewing my patch every time.
> ...
> > - (yes-or-no-p (format "Delete %d files? " (length files)))
> > + (if (eq 1 (length files))
> > + (yes-or-no-p (format "Delete file: \"%s\" ? " (cvs-fileinfo->file (car files))))
> > + (yes-or-no-p (format "Delete %d files? " (length files))))
>
> Wouldn't = be more appropriate than eq there? And you may want to bind (length files) to a local
>
> variable, so you don't have to re-evaluate it.
>
> --
> Kevin Rodgers
Thank you for suggestions. I've applied your suggestions and installed.
Masatake YAMATO
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2003-08-31 2:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-08-22 10:13 prompt of cvs-do-removal Masatake YAMATO
2003-08-22 23:52 ` Stefan Monnier
2003-08-25 22:27 ` Kevin Rodgers
2003-08-31 2:14 ` Masatake YAMATO
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.