From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.devel Subject: Re: High-res Customize icons Date: Thu, 22 Oct 2020 11:33:17 -0400 Message-ID: <3F4129E2-33AA-4BC2-9D86-DFC00B44B198@gmail.com> References: <6AEA7E43-DB35-458F-AFF2-B45DCBDC136F@gmail.com> <83a734fecm.fsf@gnu.org> <9713d235-11d4-b593-210a-e389c265e8ad@gmail.com> <83368vfxtl.fsf@gnu.org> <83imhre827.fsf@gnu.org> <83a733e56k.fsf@gnu.org> <834ktbe2ve.fsf@gnu.org> <83zharvkcc.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.4\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19915"; mail-complaints-to="usenet@ciao.gmane.io" Cc: chad , =?utf-8?Q?Cl=C3=A9ment_Pit-Claudel?= , emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Oct 22 17:35:40 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kVcct-000522-En for ged-emacs-devel@m.gmane-mx.org; Thu, 22 Oct 2020 17:35:39 +0200 Original-Received: from localhost ([::1]:38682 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kVccs-0004fw-Et for ged-emacs-devel@m.gmane-mx.org; Thu, 22 Oct 2020 11:35:38 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40164) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kVcai-0003KT-DD for emacs-devel@gnu.org; Thu, 22 Oct 2020 11:33:28 -0400 Original-Received: from mail-qk1-x72e.google.com ([2607:f8b0:4864:20::72e]:45145) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kVcaf-0005Rb-Sm; Thu, 22 Oct 2020 11:33:24 -0400 Original-Received: by mail-qk1-x72e.google.com with SMTP id 188so1817853qkk.12; Thu, 22 Oct 2020 08:33:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=ytnZg8fhSu2xMRUa1S9cu8E/b3uiRFHmQ+4PT9IQUp0=; b=jHglEU+HVmh8qxk+M/RgKf6a8vTMclb3QtIK1kW6AKGtiD1zFOtwJWwa/+wof8tS2h VUuy7FxoL20Ss7PtrJ53+TgaXHI4V0wGf8d5QqZ4HZJJbdRojwkXTeC3Hctg/lpyxn8n f6NIZG76cq6zGqwnmff+J48Mhf6vOPKQkA3wf5PaLrdH+i8nrUFEQI47Rp6xI1AS+T6B 0OlYseKVYGRdR/uarhfnfvSlzGy6HyKJu5uYOkX04p8GSC7DXEcYjkPTDxpqo8ycVHXz XvBZWiVOfdjgz3m9ox1aazCBTVGgghndc5PtfiYYsjtEIuqvsm+UirBFi2CsEuVwVGRm QvYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=ytnZg8fhSu2xMRUa1S9cu8E/b3uiRFHmQ+4PT9IQUp0=; b=Z5UskpDoudkAyICKiyUXkW/ASxLuI8nr0s5BvhIpBrML7PAGYsnmqJ2exMAmXovbHc Rpx2iHLyjLRELFsPwhgqVDyVCM/sgGD8mkmIIuy9/31pzovqtlUDAIjHppfhaEAFi7yD 63oTxaB2jNXMHLPLyHXhDGlRTfHj4EtcHyDyKw2NJXBY7MGu9zzLF4ONNOdMHbAnR30C bNSP0nZfqFuEk6CQu2r9Wb7gg//e1khcWmmm88L5ot40JqrSxdiDb6Z32vgum+U1h0HA LJq/C/31F922bOmvgMTf3WjLDYrz+cFKYOXG1FMhv/UDjBgjjnsZQBm1DEVLlVkLQz71 yUkw== X-Gm-Message-State: AOAM532CYvuCuqdUcTUb4qvZr8502DgQIerGiS1HIuRXkJ+P55/fc7y5 ppABj6H81rkVUhtc4Yu7nvJumjzV3HmyWYC+ X-Google-Smtp-Source: ABdhPJzQLbbNvPD/XMPkcsgq+IL54cUOcgbWgmiKZXYBQZrvPhw80XVCrrJQCKVRTWaVGZK0fw+3yA== X-Received: by 2002:a05:620a:570:: with SMTP id p16mr3117903qkp.396.1603380799071; Thu, 22 Oct 2020 08:33:19 -0700 (PDT) Original-Received: from [192.168.1.10] (c-174-60-229-153.hsd1.pa.comcast.net. [174.60.229.153]) by smtp.gmail.com with ESMTPSA id b14sm1188501qkg.116.2020.10.22.08.33.18 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 22 Oct 2020 08:33:18 -0700 (PDT) In-Reply-To: <83zharvkcc.fsf@gnu.org> X-Mailer: Apple Mail (2.3608.120.23.2.4) Received-SPF: pass client-ip=2607:f8b0:4864:20::72e; envelope-from=casouri@gmail.com; helo=mail-qk1-x72e.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, FREEMAIL_REPLY=1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:258297 Archived-At: > On May 1, 2020, at 9:46 AM, Eli Zaretskii wrote: >=20 >> From: Yuan Fu >> Date: Wed, 22 Apr 2020 16:38:10 -0400 >> Cc: yandros@gmail.com, >> cpitclaudel@gmail.com, >> emacs-devel@gnu.org >>=20 >> Here is a patch for the high-res icons. Put both icon files under = /etc/images/custom. >>=20 >> In the patch I modified widget-image-find to look for @2x images. Can = we even modify find-image so it looks for @2x images (as an opt-in = feature)? That way Other applications (Magit, gdb-mi, etc) that uses = images icons in buffer and fringe could have high-res icons without = changing a line of code (assuming they use find-image). >=20 > I think Emacs should look in the hi-res subdirectory when the display > is high resolution. A defcustom sounds like a wrong way to handle > this issue. That could work too, so we will have images@2x and images@3x in addition = to the current images directory? Yuan=