From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Jason Rumney Newsgroups: gmane.emacs.devel,gmane.comp.lib.gnulib.bugs Subject: Re: [Jim Meyering] Re: [Bug-gnulib] strftime merge from Emacs Date: Wed, 11 Jun 2003 11:29:17 +0100 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: <3EE7047D.8060706@gnu.org> References: <200306111214.56921.bruno@clisp.org> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Trace: main.gmane.org 1055327880 5625 80.91.224.249 (11 Jun 2003 10:38:00 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Wed, 11 Jun 2003 10:38:00 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Wed Jun 11 12:37:58 2003 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 19Q2zO-0001SZ-00 for ; Wed, 11 Jun 2003 12:37:58 +0200 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 19Q3KK-00007g-00 for ; Wed, 11 Jun 2003 12:59:36 +0200 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.20) id 19Q2yj-0004pQ-M6 for emacs-devel@quimby.gnus.org; Wed, 11 Jun 2003 06:37:17 -0400 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.20) id 19Q2vG-0004Db-K3 for emacs-devel@gnu.org; Wed, 11 Jun 2003 06:33:42 -0400 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.20) id 19Q2ql-0002mP-88 for emacs-devel@gnu.org; Wed, 11 Jun 2003 06:29:04 -0400 Original-Received: from [209.61.173.204] (helo=integrasp.com) by monty-python.gnu.org with smtp (Exim 4.20) id 19Q2qg-0002k6-KL for emacs-devel@gnu.org; Wed, 11 Jun 2003 06:28:58 -0400 Original-Received: (qmail 27297 invoked from network); 11 Jun 2003 10:23:08 -0000 Original-Received: from host217-37-167-241.in-addr.btopenworld.com (HELO ntserver.altio.com) (217.37.167.241) by 66.216.96.43 with SMTP; 11 Jun 2003 10:23:08 -0000 Original-Received: from gnu.org (ALTIOJR [192.168.111.42]) by ntserver.altio.com with SMTP (Microsoft Exchange Internet Mail Service Version 5.5.2653.13) id MTF9XMK9; Wed, 11 Jun 2003 11:29:03 +0100 User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.3b) Gecko/20030210 X-Accept-Language: en-us, en Original-To: Bruno Haible In-Reply-To: <200306111214.56921.bruno@clisp.org> Original-cc: bug-gnulib@gnu.org X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1b5 Precedence: list List-Id: Emacs development discussions. List-Help: List-Post: List-Subscribe: , List-Archive: List-Unsubscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:15028 gmane.comp.lib.gnulib.bugs:523 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:15028 Bruno Haible wrote: > Jason Rumney wrote: > >>If HAVE_TZNAME means what I think it does, then the Windows port >>should define it. The problem in this case is that the declaration >>in strftime.c conflicts with the one in when built with >>MingW32, because of the fact that tzname[] actually resides within a >>shared library, so its method of dereferencing is not normal. > > > Would it work to add > #define tzname (*tzname) > to the config.h for mingw in this case? No, in the system headers, tzname is defined as __MINGW_IMPORT char *tzname[2]; The conflict is with the __MINGW_IMPORT, which is missing in the extern declaration in strftime.h I wonder why you need to redeclare tzname[] there, do header files not already declare it on platforms where HAVE_TZNAME is defined?