From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#65491: [PATCH] Improve performance allocating vectors Date: Sat, 16 Sep 2023 21:04:28 +0200 Message-ID: <3E9D73A8-BF51-4DBE-87D2-AECEFEA32A0E@gmail.com> References: <6B2EDD07-AAEB-40E8-B369-F634296BD3D9@gmail.com> <83v8cagkqv.fsf@gnu.org> <83ttrugkj2.fsf@gnu.org> <83r0mygi4y.fsf@gnu.org> <8758CDE8-40F1-48DB-9B94-38F771DC8C6C@gmail.com> <83o7i2gevi.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16197"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 65491@debbugs.gnu.org, eggert@cs.ucla.edu, monnier@iro.umontreal.ca To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 16 21:05:21 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qhabZ-0003z4-4w for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 16 Sep 2023 21:05:21 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qhabJ-0004gI-Gx; Sat, 16 Sep 2023 15:05:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qhabB-0004fn-IC for bug-gnu-emacs@gnu.org; Sat, 16 Sep 2023 15:04:57 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qhab8-0005IU-Rl for bug-gnu-emacs@gnu.org; Sat, 16 Sep 2023 15:04:57 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qhabF-0007VM-Vi for bug-gnu-emacs@gnu.org; Sat, 16 Sep 2023 15:05:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 16 Sep 2023 19:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65491 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 65491-submit@debbugs.gnu.org id=B65491.169489108628821 (code B ref 65491); Sat, 16 Sep 2023 19:05:01 +0000 Original-Received: (at 65491) by debbugs.gnu.org; 16 Sep 2023 19:04:46 +0000 Original-Received: from localhost ([127.0.0.1]:48531 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qhab0-0007Un-2Z for submit@debbugs.gnu.org; Sat, 16 Sep 2023 15:04:46 -0400 Original-Received: from mail-lf1-x135.google.com ([2a00:1450:4864:20::135]:61647) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qhaax-0007UZ-A7 for 65491@debbugs.gnu.org; Sat, 16 Sep 2023 15:04:44 -0400 Original-Received: by mail-lf1-x135.google.com with SMTP id 2adb3069b0e04-50305abe5f0so777752e87.2 for <65491@debbugs.gnu.org>; Sat, 16 Sep 2023 12:04:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1694891070; x=1695495870; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=pw8J4F1kfN7+JDt4k8l1d1HMqgHmbtp79NOLqjkFypQ=; b=jr7X0NxeCfiezpOVKt5HPlzITi+L15T55HwnTVbJRhMP7Z0jWMedmYENqc3t4jKcVi VdUL/ELqySwWuw7LTYGa0SEQa4DAlLJIVVTJ9LSE9jWkJ0vBMvkxyWVgURnx/816uw4M fAC+pz8+GEq1MXGBG6q+g2sNjVkzqNqAgjkIK96LQB2SNZyfxBDMhldHbcmPKIk5OR8K c4sy2jssIQTzjudAER8D+bSOU3qF9SHVJajRBxRX79C+afR1qlESnVX+IFcJDPPLQjnL GgFlIeCIWAuB5zWr36Lh/4ilg9QnhvARBP+nrixyA0zxOwh8gkJcKxbFO+TjLa5KjBPS lXWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694891070; x=1695495870; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=pw8J4F1kfN7+JDt4k8l1d1HMqgHmbtp79NOLqjkFypQ=; b=XIF7thx4o6R/yllDGEo78pf+CMNZazvLwoAqRWhWZkYmsPEK7NZ/y8wcR7DLuXV/xQ 7r5FVkYJRbAxDsM0WxgSEWhkGO7pNYwF494Kt7kku7d6IVc6nDqG7Xr50E+q4fXRJAE/ YPWtRUN16r2ZCng1Z+hx0oTcvaI9lOw6gOZ6xlSx+CSjGcCQ9M+0mYTN4gD0p71T6b3a V+EYBIjZ9awId6dF1UiAUlRU+iat6WRuc1oveczfh3k0RzQnDnytdOc2jOAk0xILsutw klnOpqpK4RFSUdfPrIcuUPCYoZOSTeBhupS0fBeixxdVNlCNbFBxxT5ERfxaqqM9jYnh 1+xg== X-Gm-Message-State: AOJu0YxkIVmKAgryBQzMCmYnRBdjG2CsLzbQ6F/DFAfEALs9km4fYntT 3NHupDC8ArfldxGG0/TlgqA= X-Google-Smtp-Source: AGHT+IHTOt2LaOK3rkh4TE0oii5v+BnQktq0uPmZakbxFW3QoY8wr8f1C6ESzdofX3h09xL7j0Gp4Q== X-Received: by 2002:ac2:5f69:0:b0:4f8:766f:8dc3 with SMTP id c9-20020ac25f69000000b004f8766f8dc3mr3850956lfc.32.1694891069848; Sat, 16 Sep 2023 12:04:29 -0700 (PDT) Original-Received: from smtpclient.apple (c188-150-165-235.bredband.tele2.se. [188.150.165.235]) by smtp.gmail.com with ESMTPSA id q2-20020ac24a62000000b00501c673e780sm1118457lfp.84.2023.09.16.12.04.28 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 16 Sep 2023 12:04:29 -0700 (PDT) In-Reply-To: <83o7i2gevi.fsf@gnu.org> X-Mailer: Apple Mail (2.3654.120.0.1.15) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:270644 Archived-At: 16 sep. 2023 kl. 20.19 skrev Eli Zaretskii : > I get it that you are confident, but I want to be confident as well, > and I'm not there yet. That's fine, I'm in no rush. I'll be happy to answer any questions you = may have. It's natural that our perspectives are different. =46rom my point of = view I have a well-researched and carefully tested change with = everything indicating that it's safe and an improvement. But when the = first thing you see is a flood of warnings, it's quite understandable = that it is taken as a sign that something is wrong. > Those special configurations have telltale traits that can be used in > cpp conditionals. IOW, we could have different definitions of XUNTAG > for different configurations. It isn't unheard off, and other macros, > including some that are involved in XUNTAG, do indeed have separate > definitions for several configurations. Certainly, but we didn't need multiple definitions for XUNTAG before and = nothing has changed in that respect. However, if you think that it would make the code easier to understand = we could separate the code into two or more #if clauses, although most = of the time a single definition is easier to maintain. In any case, that would be a separate change.