From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.devel Subject: Re: Tree-sitter navigation time grows as sqrt(line-number) Date: Thu, 17 Aug 2023 19:49:48 -0700 Message-ID: <3DA8CA36-7B5F-4992-BEDB-8D5699A47ABB@gmail.com> References: <87v8ddsqwe.fsf@web.de> <797b4f1c-222e-14c0-c802-6f23090c9c1f@gutov.dev> <2fe95bcd-c3b5-09de-067d-fe986b01f890@gutov.dev> <878ra9u2b1.fsf@web.de> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.600.7\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14738"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Dmitry Gutov , emacs-devel To: Felix Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Aug 18 04:50:53 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qWpZc-0003hx-J3 for ged-emacs-devel@m.gmane-mx.org; Fri, 18 Aug 2023 04:50:52 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qWpYu-00021v-Rh; Thu, 17 Aug 2023 22:50:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qWpYr-00021d-Gz for emacs-devel@gnu.org; Thu, 17 Aug 2023 22:50:06 -0400 Original-Received: from mail-pf1-x431.google.com ([2607:f8b0:4864:20::431]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qWpYo-0006zD-Rt for emacs-devel@gnu.org; Thu, 17 Aug 2023 22:50:04 -0400 Original-Received: by mail-pf1-x431.google.com with SMTP id d2e1a72fcca58-689f9576babso382865b3a.0 for ; Thu, 17 Aug 2023 19:50:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692327000; x=1692931800; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=YcWtYTRM620jnWMxAZwdzJ8fuwQ6h52n9E/jKVyEyc8=; b=VkJEyCUfK4Oq6SwPeQCL3OA6eXg4eE/4aMbUd3zmT5R61NrbCv5PI6aXNH5kVjGn5m 2sWhkPAdz/b1Moy/vpq2da0p15/9euDHCemR09/ZVASfnML1DTNt50ux200p5BxyvHql 7gvT/+OX/VRFk/MIIipiio5QCVKC1iCJDP/YWiK5o512C5UjObVtisfPGaUt8jypmeLr 8bN40ttvNvl0OfVmfJ/y9iwFIk211FKeca9EosuVuYETa4HYGhwGoXiFPE1jL3oL5IMc v9wwPuIe4hi4xU5ySZDF3xoYT6p8yXS29Q65ei2GYAecH/VWP2TfPfnHwILupB59RVPh 3Bxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692327000; x=1692931800; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YcWtYTRM620jnWMxAZwdzJ8fuwQ6h52n9E/jKVyEyc8=; b=jKIwpQzRzBHSI9mRyf2Lu67fNQcUwbtvcQt+xeJ6ifoGBkQH7DivesFcLayJtjirUb QBShpEAoa9+jVJp80mTA/cG2/XBjAD7g+kVlrXL6kTqXhANnbOKwwhUSMsko1jNwsHEF NNDPQcbdNl6mYM7VomWsqyPS5NxrNsjltlD3K8wwI/afn3m7vY8u4erE/g0lMu2yJZct KmxCIXfn74KxWLryAHC5L3aspoNb3aI3fPLauCQ2XaFV6KqAbkqpyGO90Wm2jeiDNAyk gVt1Bl+uvfeSZLyszN6Ma0TVjf3A3cy8LYx3wsCtSTZb7oLUnrRMGcttdxVrZtODRlK3 0qtA== X-Gm-Message-State: AOJu0YzpyZl1bxTjQnFuF2SFVZ6tPcrfQWtO/8y+PACqtxzRsGAZk9B/ 2zHyiwUZ0Cu+wG7Ne2tHNKQ= X-Google-Smtp-Source: AGHT+IEqPi/Uto4VvS2Cu8xig3JI9rloC3MSYVavI8kxHnTWUh5qu8sHdXimFbxg0d7+aYvQcWAZ1A== X-Received: by 2002:a05:6a20:4426:b0:13e:2080:aba2 with SMTP id ce38-20020a056a20442600b0013e2080aba2mr2189571pzb.38.1692327000528; Thu, 17 Aug 2023 19:50:00 -0700 (PDT) Original-Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id c5-20020a170902d90500b001bc21222e34sm463543plz.285.2023.08.17.19.49.59 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 17 Aug 2023 19:50:00 -0700 (PDT) In-Reply-To: <878ra9u2b1.fsf@web.de> X-Mailer: Apple Mail (2.3731.600.7) Received-SPF: pass client-ip=2607:f8b0:4864:20::431; envelope-from=casouri@gmail.com; helo=mail-pf1-x431.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:308880 Archived-At: > On Aug 17, 2023, at 8:15 AM, Felix wrote: >=20 >=20 > Dmitry Gutov writes: >=20 >> On 17/08/2023 17:36, Dmitry Gutov wrote: >>> On 17/08/2023 17:25, Dmitry Gutov wrote: >>>> On 17/08/2023 17:08, Felix wrote: >>>>> Hi, >>>>>=20 >>>>> I tried that patch, and it crashes emacs whenever i try to scroll = inside >>>>> a tree-sitter managed buffer. >>>>>=20 >>>>> GNU Emacs 30.0.50 (build 22, x86_64-pc-linux-gnu, GTK+ Version >>>>> 3.24.38, cairo version 1.17.8) of 2023-08-17 >>>>>=20 >>>>> compiled with pgtk running on wayland. >>>>=20 >>>> Thanks for testing. Does that happen in any ts mode, or some >>>> particular ones? >>>>=20 >>>> If you run Emacs from the terminal, could you post the error = backtrace? >>>>=20 >>>> (Please keep emacs-devel in Cc). >>> For my part, I don't see it crash when scrolling (in ruby-ts-mdoe or >>> js-ts-mode, including larges files), but the test scenario by JD >>> does make it crash. >>> When running under GDB, the backtrace simply looks like this: >>> #0 0x00007ffff63bf93d in ts_tree_root_node (self=3D0x0) at >>> lib/src/tree.c:36 >>> #1 0x00007ffff63a54e5 in ts_node_parent (self=3D...) at = lib/src/node.c:462 >>> #2 0x00005555557f0d17 in Ftreesit_node_parent >>> (node=3DXIL(0x5555574908c5)) at treesit.c:1906 >>> #3 0x000055555576f62b in eval_sub (form=3D) at = eval.c:2511 >>> #4 0x000055555576f987 in Fsetq (args=3D) at = eval.c:483 >>> #5 0x000055555576f368 in eval_sub (form=3D) at = eval.c:2462 >>> #6 0x000055555576ff75 in Fprogn (body=3DXIL(0)) at eval.c:436 >>> ... >>=20 >> Try this one. >>=20 >> I've read the tree-sitter docs a bit more, and also dropped the = "else" >> case because it was unreachable anyway. I doesn't crash anymore here. >>=20 >> [2. text/x-patch; treesit-node-parent.diff]... >=20 > This one doesn't crash while scrolling. So I guess the cursor stuff caused the crash. But we shouldn=E2=80=99t = fix it by using tree_sitter_node_parent, we purposefully replaced it = using the cursor API, see bug#60054. Yuan=