Re: Re: [PATCH] Proposed command: org-agenda-clock-goto

[Carsten Dominik <carsten.dominik@gmail.com>]

On Aug 7, 2010, at 10:14 AM, Bastien wrote:

> Bernt Hansen <bernt@norang.ca> writes:
>
>> I'm not against this change since I've never used J in the agenda  
>> before
>> (mostly because I wasn't aware of this key binding at all).
>
> C-c C-x C-j is now bound to org-agenda-clock-goto in agenda buffers  
> and
> to org-clock-goto is org buffers.
>
> I hesitated long, and I'm still not convinved this is the best choice.
>
> Since `J' is an agenda-only keybinding, maybe using `J' would make  
> more
> sense.

I have not looked up which way it is now,
but thinking again it seems to me that this would be the right way:

C-c C-x C-j jumps to the entry in the org buffer, both from the agenda
and from normal buffers.

"J" would then be available to find the clock entry in the agenda, if
it is present there.  We could extend this command to show the clock
entry in the other window if the line cannot be found in the agenda
window...

- Carsten

>
> What's your take on this?
>
>> Is there a way to rebind agenda keys in case I want to use J for
>> something different (similar to the user speed key settings?)
>
> (org-defkey org-agenda-mode-map "J" 'your-function)


In general, he best way to do user keys is to bind them in the
mode hook of the mode you need them for, in this
case org-agenda-mode-hook.

>
>> I don't really want to overwrite the standard org-agenda-keymap
>> bindings but it might be useful to have user bindings that on top of
>> those as we do for the speed key settings.

I think doing the hook think is good enough for this case.
The speed key implementation is different.

- Carsten