From: Carsten Dominik <dominik@science.uva.nl>
To: Wanrong Lin <wanrong.lin@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: Re: Bug: Invalid face reference
Date: Fri, 29 Feb 2008 21:46:40 +0100 [thread overview]
Message-ID: <3C6351DB-D627-4948-B9A2-2EB66DB1D77A@science.uva.nl> (raw)
In-Reply-To: <47C86EBC.5070303@gmail.com>
OK, thanks.
- Carsten
On Feb 29, 2008, at 9:44 PM, Wanrong Lin wrote:
>
> I already did so. So far there is no problem. If I don't report
> anything, I think you can assume in the next release that I have no
> problem at all with the htmlize advice removed.
>
> Wanrong
>
> Carsten Dominik wrote:
>> I am taking this patch thanks!
>>
>> This might indeed make the advice for htmlize unnecessary - could
>> you please
>> remove it your own setup and test this for a long while? And then
>> report back?
>>
>> Thanks!
>>
>> - Carsten
>>
>> On Feb 29, 2008, at 7:41 PM, Wanrong Lin wrote:
>>
>>> Found the bug and fixed it as following (see the comment line
>>> marked with <WL>)
>>> -------------
>>> (defun org-agenda-align-tags (&optional line)
>>> "Align all tags in agenda items to `org-agenda-tags-column'."
>>> (let ((inhibit-read-only t) l c)
>>> (save-excursion
>>> (goto-char (if line (point-at-bol) (point-min)))
>>> (while (re-search-forward (org-re "\\([ \t]+\\)\\(:
>>> [[:alnum:]_@:]+:\\)[ \t]*$")
>>> (if line (point-at-eol) nil) t)
>>> (add-text-properties
>>> (match-beginning 2) (match-end 2)
>>> ;; <WL>: bug fix against 5.22a
>>> (list 'face (delq nil (list 'org-tag (get-text-property
>>> (match-beginning 2)
>>> 'face)))))
>>> (setq l (- (match-end 2) (match-beginning 2))
>>> c (if (< org-agenda-tags-column 0)
>>> (- (abs org-agenda-tags-column) l)
>>> org-agenda-tags-column))
>>> (delete-region (match-beginning 1) (match-end 1))
>>> (goto-char (match-beginning 1))
>>> (insert (org-add-props
>>> (make-string (max 1 (- c (current-column))) ?\ )
>>> (text-properties-at (point))))))))
>>>
>>>
>>> Wanrong Lin wrote:
>>>> More update:
>>>>
>>>> In a tag search result buffer, I move the cursor to a tag, and
>>>> eval (get-text-property (point) 'face), and I get: (org-tag
>>>> nil). So this "nil" is causing the problem, but I don't know
>>>> where it is sneaked in.
>>>>
>>>> Wanrong
>>>>
>>>>> Just some update:
>>>>>
>>>>> I called (org-restart-font-lock) function inside my tag search
>>>>> result buffer, and I can see a new "Invalid face reference: nil
>>>>> [X times]" message is generated in the "*Messages*" buffer, with
>>>>> "X" keeps increasing. I have "jit-lock-mode" (Just in time font
>>>>> locking) enabled in my emacs config, so I guess that ticking "X"
>>>>> number is from the background font locking process.
>>>>>
>>>>> It seems something is wrong with font locking for tags. But this
>>>>> only happens in tag search result buffer. It does not happen in
>>>>> regular agenda buffer.
>>>>>
>>>>> I don't know how to proceed to pin-point this. Can any of you
>>>>> guys also reproduce this? Any suggestions? Thank you.
>>>>>
>>>>> Wanrong
>>>>>
>>>>>
>>>>
>>>>
>>>
>>>
>>>
>>> _______________________________________________
>>> Emacs-orgmode mailing list
>>> Remember: use `Reply All' to send replies to the list.
>>> Emacs-orgmode@gnu.org
>>> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
>>
>
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Remember: use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
prev parent reply other threads:[~2008-02-29 20:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-27 23:34 Bug: Invalid face reference Wanrong Lin
2008-02-28 1:31 ` Bastien
2008-02-28 2:08 ` Wanrong Lin
2008-02-28 16:38 ` Wanrong Lin
2008-02-29 17:19 ` Wanrong Lin
2008-02-29 18:41 ` Bastien
2008-02-29 18:41 ` Wanrong Lin
2008-02-29 18:48 ` Wanrong Lin
2008-02-29 20:10 ` Carsten Dominik
2008-02-29 20:44 ` Wanrong Lin
2008-02-29 20:46 ` Carsten Dominik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3C6351DB-D627-4948-B9A2-2EB66DB1D77A@science.uva.nl \
--to=dominik@science.uva.nl \
--cc=emacs-orgmode@gnu.org \
--cc=wanrong.lin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.